Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rhs commented on the pull request:
https://github.com/apache/qpid-proton/pull/17#issuecomment-94437344
Looks good to me, assuming all the tests pass and what not, I'm +1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/17#issuecomment-93824913
@dnwe I think I copied that CMake code directly from qpid. I'll look at
doing something like you suggested - the CMake output does look clunky.
---
If your
I've received no further feedback at all about this review request.
Do people want me to create a reviewboard item instead?
For reference, this proposed change incorporates all the discussion -
although I haven't necessarily agreed with everyone else's points!
For clarity the main issue that I
-
From: Andrew Stitcher astitc...@redhat.com
To: proton@qpid.apache.org
Sent: Wednesday, April 15, 2015 4:06:05 PM
Subject: Re: [GitHub] qpid-proton pull request: PROTON-334: SASL
Implementation for Prot...
I've received no further feedback at all about this review request.
Do people
Github user astitcher commented on the pull request:
https://github.com/apache/qpid-proton/pull/17#issuecomment-91137151
See the wiki for more information and context:
https://cwiki.apache.org/confluence/x/B5cWAw
---
If your project is set up for it, you can reply to this email
GitHub user astitcher opened a pull request:
https://github.com/apache/qpid-proton/pull/17
PROTON-334: SASL Implementation for Proton-C using Cyrus SASL
This work Adds some new APIs to the transport and connection
objects to make a higher level abstraction for authentication.
