Re: PROTON-772: New proton logging code

2014-12-17 Thread Alan Conway
. We may want to expose some form of logging as API but this > > is probably to rushed. The purpose of this work was to allow users of > > the proton library to control where protons logging goes, not to provide > > a general purpose logging API for developers using proton. > >

Re: PROTON-772: New proton logging code

2014-12-16 Thread Rafael Schloming
On Tue, Dec 16, 2014 at 10:48 AM, Andrew Stitcher wrote: > > On Mon, 2014-12-15 at 11:51 -0500, Alan Conway wrote: > > On Fri, 2014-12-12 at 15:09 -0500, Andrew Stitcher wrote: > > > Alan recently landed a change which stops the proton library from > > > writing directly to stderr/stdout - this is

Re: PROTON-772: New proton logging code

2014-12-16 Thread Andrew Stitcher
On Mon, 2014-12-15 at 11:51 -0500, Alan Conway wrote: > On Fri, 2014-12-12 at 15:09 -0500, Andrew Stitcher wrote: > > Alan recently landed a change which stops the proton library from > > writing directly to stderr/stdout - this is a good thing (IMO). > > > > However I question a couple of things:

Re: PROTON-772: New proton logging code

2014-12-15 Thread Alan Conway
On Fri, 2014-12-12 at 15:09 -0500, Andrew Stitcher wrote: > Alan recently landed a change which stops the proton library from > writing directly to stderr/stdout - this is a good thing (IMO). > > However I question a couple of things: > > 1. This change adds to the external API and so should have

Re: PROTON-772: New proton logging code

2014-12-12 Thread Andrew Stitcher
er" To: proton@qpid.apache.org, "qpid developers" Cc: acon...@apache.org Sent: Friday, December 12, 2014 3:25:53 PM Subject: PROTON-772: New proton logging code Alan recently landed a change which stops the proton library from writing directly to stderr/stdout - this is a good thing (IMO).

PROTON-772: New proton logging code

2014-12-12 Thread Andrew Stitcher
Alan recently landed a change which stops the proton library from writing directly to stderr/stdout - this is a good thing (IMO). However I question a couple of things: 1. This change adds to the external API and so should have been reviewed (again IMO). reviews.apache.org now does work with the

PROTON-772: New proton logging code

2014-12-12 Thread Andrew Stitcher
Alan recently landed a change which stops the proton library from writing directly to stderr/stdout - this is a good thing (IMO). However I question a couple of things: 1. This change adds to the external API and so should have been reviewed (again IMO). reviews.apache.org now does work with the

PROTON-772: New proton logging code

2014-12-12 Thread Andrew Stitcher
Alan recently landed a change which stops the proton library from writing directly to stderr/stdout - this is a good thing (IMO). However I question a couple of things: 1. This change adds to the external API and so should have been reviewed (again IMO). reviews.apache.org now does work with the

PROTON-772: New proton logging code

2014-12-12 Thread Andrew Stitcher
Alan recently landed a change which stops the proton library from writing directly to stderr/stdout - this is a good thing (IMO). However I question a couple of things: 1. This change adds to the external API and so should have been reviewed (again IMO). reviews.apache.org now does work with the