[jira] [Commented] (PROTON-686) va_copy is C99 (not C89) and is not supported by the Microsoft Visual Studio C compiler before VS 2013

2014-09-16 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14135089#comment-14135089
 ] 

ASF subversion and git services commented on PROTON-686:


Commit 1625220 from [~astitcher] in branch 'proton/trunk'
[ https://svn.apache.org/r1625220 ]

PROTON-686, PROTON-???: Fix recent changes to compile on windows

 va_copy is C99 (not C89) and is not supported by the Microsoft Visual Studio 
 C compiler before VS 2013
 --

 Key: PROTON-686
 URL: https://issues.apache.org/jira/browse/PROTON-686
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.8
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher
Priority: Blocker

 in r1625123 proton-c/src/engine/string.c was introduced: this uses va_copy() 
 in pn_string_vaddf(). 
 However this does not exist in the Microsoft C Compiler before VS 2013 (which 
 has most of the useful C99 features in it).
 It is probable that the macro could be a simple assignment in any case as 
 vsprintf() can't change the arguments.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (PROTON-687) Memory corruption in proton-test

2014-09-16 Thread Cliff Jansen (JIRA)
Cliff Jansen created PROTON-687:
---

 Summary: Memory corruption in proton-test
 Key: PROTON-687
 URL: https://issues.apache.org/jira/browse/PROTON-687
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c, python-binding
Affects Versions: 0.8
Reporter: Cliff Jansen


proton-test will fail with memory violations.  Deallocated memory is accessed, 
usually with benign results but less often on Windows.

The attached crude patch allows the bug to be discovered on Linux as well.

It is not clear to me if the problem is with the swig wrapper, or whether this 
just exposes a reference counting bug in proton-c.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (PROTON-687) Memory corruption in proton-test

2014-09-16 Thread Cliff Jansen (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Cliff Jansen updated PROTON-687:

Attachment: segv.patch

 Memory corruption in proton-test
 

 Key: PROTON-687
 URL: https://issues.apache.org/jira/browse/PROTON-687
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c, python-binding
Affects Versions: 0.8
Reporter: Cliff Jansen
 Attachments: segv.patch


 proton-test will fail with memory violations.  Deallocated memory is 
 accessed, usually with benign results but less often on Windows.
 The attached crude patch allows the bug to be discovered on Linux as well.
 It is not clear to me if the problem is with the swig wrapper, or whether 
 this just exposes a reference counting bug in proton-c.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)