[GitHub] qpid-proton pull request: PROTON-576: modified UTF-8 encoder fixes
GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/10 PROTON-576: modified UTF-8 encoder fixes Commit 5069bb6 applied a modified version of a patch I submitted, to ensure that the UTF-8 encoder (and UTF-8 byte length calculator) would cope with surrogate pairs. This commit fixes an issue with three byte characters in the = 0x range being incorrectly detected as invalid four byte surrogates. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton fix-proton-576 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/10.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #10 commit 6ed99b97164d1bdb463b3bdbfc0507e0e603949e Author: Dominic Evans dominic.ev...@uk.ibm.com Date: 2015-03-04T16:21:46Z PROTON-576: modified UTF-8 encoder fixes Commit 5069bb6 applied a modified version of a patch I submitted, to ensure that the UTF-8 encoder (and UTF-8 byte length calculator) would cope with surrogate pairs. This commit fixes an issue with three byte characters in the = 0x range being incorrectly detected as invalid four byte surrogates. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (PROTON-576) proton-j: codec support for UTF-8 encoding and decoding appears broken?
[
https://issues.apache.org/jira/browse/PROTON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14347249#comment-14347249
]
ASF GitHub Bot commented on PROTON-576:
---
Github user gemmellr commented on the pull request:
https://github.com/apache/qpid-proton/pull/10#issuecomment-77209715
I had a chat with Rob and he thought the change looked ok. Could you make a
new JIRA though and merge it against that, since PROTON-576 was already release
in 0.8.
proton-j: codec support for UTF-8 encoding and decoding appears broken?
---
Key: PROTON-576
URL: https://issues.apache.org/jira/browse/PROTON-576
Project: Qpid Proton
Issue Type: Bug
Components: proton-j
Affects Versions: 0.7
Reporter: Dominic Evans
Fix For: 0.8
Attachments: 02_fix_stringtype_encode_decode.patch, PROTON-576.patch
It seems like Proton-J has its own custom UTF-8 encoder, but relies on Java
String's built-in UTF-8 decoder. However, the code doesn't seem quite right
and complex double byte UTF-8 like emoji ('') can quite easily fail to
parse:
| | Cause:1 :- java.lang.IllegalArgumentException: Cannot parse
String
| | Message:1 :- Cannot parse String
| | StackTrace:1 :- java.lang.IllegalArgumentException: Cannot parse
String
| | at
org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:48)
| | at
org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:36)
| | at
org.apache.qpid.proton.codec.DecoderImpl.readRaw(DecoderImpl.java:945)
| | at
org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:172)
| | at
org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:124)
| | at
org.apache.qpid.proton.codec.DynamicTypeConstructor.readValue(DynamicTypeConstructor.java:39)
| | at
org.apache.qpid.proton.codec.DecoderImpl.readObject(DecoderImpl.java:885)
| | at
org.apache.qpid.proton.message.impl.MessageImpl.decode(MessageImpl.java:629)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] qpid-proton pull request: PROTON-576: modified UTF-8 encoder fixes
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-proton/pull/10#issuecomment-77209715 I had a chat with Rob and he thought the change looked ok. Could you make a new JIRA though and merge it against that, since PROTON-576 was already release in 0.8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (PROTON-833) transport can emit detach frames with an invalid channel number after session end
Robbie Gemmell created PROTON-833: - Summary: transport can emit detach frames with an invalid channel number after session end Key: PROTON-833 URL: https://issues.apache.org/jira/browse/PROTON-833 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.8 Reporter: Robbie Gemmell The transport can emit detach frames with an invalid channel number if a local link close(+detach?) call is performed (in response to a remote detach) after a local session close is performed. When a session is locally closed by a client with open links on it, if the 'broker' sends detach frames for any of those links then the application might then do a local close on them in response. The client transport then emits detach 'response' frames as a result of this, after the session end frame has been sent. A side effect of calling close on the session is that the channel number is unmapped when the end frame is sent, and the relevant variable set to the value -1. When the transport sends the detaches outlined above it then uses the -1 value, which is treated as channel 65535 when sent as the unsigned channel number. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
