Re: jprofiler hotspot results for java engine clients
Thanks Rafi. I do indeed see a difference in how long it takes to send the messages when I use all the credit at once. However, I was seeing an overall slowdown in how long it takes to settle all the messages. The rest of this message is just a commentary and theory on the slowdown. I'm sending 100,000 messages. The receiver is calling .drain(10) Scenario 1 - I send a single message in onFlow: - The total time it takes before all messages are SENT is approx 6 seconds - The total time it takes before all messages are SETTLED is approx 6 seconds - The settlements come in as the messages are sent Scenario 2 - I send as many messages as I have credit for in onFlow: - The total time it takes before all messages are SENT is approx 1.5 seconds - The total time it takes before all messages are SETTLED is approx 22 seconds - The settlements start after all messages are sent One clue as to the reason for the dramatic increase in total settlement time is that the rate of settlement increases as the number of deliveries remaining to be settled decreases. In my receiver, I'm printing a '*' for every 1000 settlements. At first the *s come about .5 seconds apart, but they increase in speed in what appears to be a linear fashion. >From this I'm guessing there is a list traversal of all unsettled deliveries >happening in the engine. And indeed, if I decrease the receiver's credit >window to .drain(1000), the settlements come in as expected. Scenario 3 - I send as many messages as I have credit for in onFlow but the credit window is 1000 - The total time it takes before all messages are SENT is approx 4 seconds - The total time it takes before all messages are SETTLED is approx 4 seconds - The settlements come in as each batch of messages are sent I'll do a jprofiler run on the receiver for scenario 2 and see what I find. - Original Message - > From: "Rafael Schloming" > To: proton@qpid.apache.org > Sent: Friday, October 10, 2014 12:55:45 PM > Subject: Re: jprofiler hotspot results for java engine clients > > I think if you change the innermost "if" statement in your onFlow handler > to a "while" you should see significantly improved performance. > > Flow events are generated when credit levels change. This happens at two > different times, 1) when the receiver grants more credit to the sender, and > 2) when the sender actually uses some of that credit by writing a message > to the wire. The way you have coded your event handler, even if the > receiver sends you 10,000 credits, you are only going to send a single > message until you get another flow event, and this won't happen until you > write the first message out onto the wire. This is going to introduce some > added processing and latency and therefore be significantly less efficient > than if you use up your credit in larger chunks than one message at a time. > > --Rafael > > > On Thu, Oct 9, 2014 at 2:48 PM, Ernest Allen wrote: > > > - Original Message - > > > From: "Rafael Schloming" > > > To: proton@qpid.apache.org > > > Sent: Thursday, October 9, 2014 10:43:09 AM > > > Subject: Re: jprofiler hotspot results for java engine clients > > > > > > Can you include a bit more context? The 6-7 seconds for 100,000 messages > > > seems a bit slow compared to what I've been able to measure. Was it over > > > loopback or a real network? Was the profiler running when those > > > measurements were made? How big are the messages, etc? > > > > It was just on my laptop using 0.0.0.0. I'll try on a more powerful lab > > machine. > > The profiler was not running. I ran both from command line. > > The messages are small: "Hello World". > > I'm starting the clock after all connections are made, just before I send > > the 1st message. > > I stop the clock when the last message is remotelySettled in the > > onDelivery event handler. > > > > I'm just sending a single message every time the onFlow handler is called. > > I could put a loop in onFlow and send all the messages at once. > > I was able to reduce the time to a little over 5 seconds by removing all > > string manipulations out of the onFlow event handler. > > > > > > > > ---Rafael > > > > > > On Thu, Oct 9, 2014 at 10:10 AM, Ernest Allen wrote: > > > > > > > There are some java apps based on the 0.8 engine api available at > > > > https://github.com/ErnieAllen/jprofile-clients. They are based on the > > > > clients at https://github.com/rhs/qpid-proton-demo > > > > They will send/receive 100,000 messages and measure the elapsed time. > > They > > > > are averaging between 6 and 7 seconds for the 100,000 messages. > > > > > > > > I used these clients to run jprofiler. Reports showing which java > > methods > > > > are hotspots are at > > > > http://misc-eapages.rhcloud.com/jprofiler-results/send/Hot_Spots.html > > > > http://misc-eapages.rhcloud.com/jprofiler-results/recv/Hot_Spots.html > > > > > > > > If anyone has suggestions as to how to improve the clients' throughput > > or >
Re: jprofiler hotspot results for java engine clients
I think if you change the innermost "if" statement in your onFlow handler to a "while" you should see significantly improved performance. Flow events are generated when credit levels change. This happens at two different times, 1) when the receiver grants more credit to the sender, and 2) when the sender actually uses some of that credit by writing a message to the wire. The way you have coded your event handler, even if the receiver sends you 10,000 credits, you are only going to send a single message until you get another flow event, and this won't happen until you write the first message out onto the wire. This is going to introduce some added processing and latency and therefore be significantly less efficient than if you use up your credit in larger chunks than one message at a time. --Rafael On Thu, Oct 9, 2014 at 2:48 PM, Ernest Allen wrote: > - Original Message - > > From: "Rafael Schloming" > > To: proton@qpid.apache.org > > Sent: Thursday, October 9, 2014 10:43:09 AM > > Subject: Re: jprofiler hotspot results for java engine clients > > > > Can you include a bit more context? The 6-7 seconds for 100,000 messages > > seems a bit slow compared to what I've been able to measure. Was it over > > loopback or a real network? Was the profiler running when those > > measurements were made? How big are the messages, etc? > > It was just on my laptop using 0.0.0.0. I'll try on a more powerful lab > machine. > The profiler was not running. I ran both from command line. > The messages are small: "Hello World". > I'm starting the clock after all connections are made, just before I send > the 1st message. > I stop the clock when the last message is remotelySettled in the > onDelivery event handler. > > I'm just sending a single message every time the onFlow handler is called. > I could put a loop in onFlow and send all the messages at once. > I was able to reduce the time to a little over 5 seconds by removing all > string manipulations out of the onFlow event handler. > > > > > ---Rafael > > > > On Thu, Oct 9, 2014 at 10:10 AM, Ernest Allen wrote: > > > > > There are some java apps based on the 0.8 engine api available at > > > https://github.com/ErnieAllen/jprofile-clients. They are based on the > > > clients at https://github.com/rhs/qpid-proton-demo > > > They will send/receive 100,000 messages and measure the elapsed time. > They > > > are averaging between 6 and 7 seconds for the 100,000 messages. > > > > > > I used these clients to run jprofiler. Reports showing which java > methods > > > are hotspots are at > > > http://misc-eapages.rhcloud.com/jprofiler-results/send/Hot_Spots.html > > > http://misc-eapages.rhcloud.com/jprofiler-results/recv/Hot_Spots.html > > > > > > If anyone has suggestions as to how to improve the clients' throughput > or > > > would like to see a different jprofiler graph, please let me know. > > > > > > -Ernie > > > > > > > > > > > >
apologies for the deluge of jira/commit related emails
I rebased the branch on which I have been developing some examples. I did this using got svn (quite possibly incorrectly) resulting in a commit to branch per original commit. Sorry for the noise. I'll post some information about progress on the examples and supporting toolkit over on the user list shortly.
[jira] [Commented] (PROTON-660) Fix openssl.c build on windows
[ https://issues.apache.org/jira/browse/PROTON-660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166804#comment-14166804 ] ASF subversion and git services commented on PROTON-660: Commit 1630874 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630874 ] PROTON-660: Fix openssl.c build on windows > Fix openssl.c build on windows > -- > > Key: PROTON-660 > URL: https://issues.apache.org/jira/browse/PROTON-660 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 > Environment: Windows 7, VS2013 >Reporter: Bozo Dragojevic >Assignee: Andrew Stitcher > Fix For: 0.8 > > Attachments: 0001-PROTON-660-Fix-openssl.c-build-on-windows.patch, > 25_openssl_fix_for_windows_CMakeLists.patch, > 25_openssl_fix_for_windows_data.h.patch, > 25_openssl_fix_for_windows_platform.h.patch > > > Compiled openssl-1.0.1i from source > Proton finds it, but openssl.c does not compile without small adjustments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-705) Windows: Allow C based tests to run directly from ctest/Visual Studio without having to set up environment
[ https://issues.apache.org/jira/browse/PROTON-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166806#comment-14166806 ] ASF subversion and git services commented on PROTON-705: Commit 1630877 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630877 ] PROTON-705: Fix tests on windows so that they run directly from a build (without having to fix up the environment with config.bat) > Windows: Allow C based tests to run directly from ctest/Visual Studio without > having to set up environment > -- > > Key: PROTON-705 > URL: https://issues.apache.org/jira/browse/PROTON-705 > Project: Qpid Proton > Issue Type: Improvement >Affects Versions: 0.7, 0.8 > Environment: Windows >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > Fix For: 0.8 > > > Currently the C based tests need a path correctly set up to find the > qpid-proton DLL. It would make a whole lot of sense if the build could do > that automatically when it tries to run the tests. Especially as it already > knows where it just built the DLL anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-705) Windows: Allow C based tests to run directly from ctest/Visual Studio without having to set up environment
[ https://issues.apache.org/jira/browse/PROTON-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166808#comment-14166808 ] ASF subversion and git services commented on PROTON-705: Commit 1630878 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630878 ] PROTON-705: Work with older versions of CMake too > Windows: Allow C based tests to run directly from ctest/Visual Studio without > having to set up environment > -- > > Key: PROTON-705 > URL: https://issues.apache.org/jira/browse/PROTON-705 > Project: Qpid Proton > Issue Type: Improvement >Affects Versions: 0.7, 0.8 > Environment: Windows >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > Fix For: 0.8 > > > Currently the C based tests need a path correctly set up to find the > qpid-proton DLL. It would make a whole lot of sense if the build could do > that automatically when it tries to run the tests. Especially as it already > knows where it just built the DLL anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-676) proton-c: transport layer SSL failures not propagated back to Messenger in pni_connection_readable
[ https://issues.apache.org/jira/browse/PROTON-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166802#comment-14166802 ] ASF subversion and git services commented on PROTON-676: Commit 1630872 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630872 ] PROTON-676: Removed file added in error > proton-c: transport layer SSL failures not propagated back to Messenger in > pni_connection_readable > -- > > Key: PROTON-676 > URL: https://issues.apache.org/jira/browse/PROTON-676 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 24_ssl_transport_failure_fix_messenger.c.patch > > > When an ssl failure occurs during connection at the transport layer the error > is not propagated back to messenger (it is ignored). > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-676) proton-c: transport layer SSL failures not propagated back to Messenger in pni_connection_readable
[ https://issues.apache.org/jira/browse/PROTON-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166801#comment-14166801 ] ASF subversion and git services commented on PROTON-676: Commit 1630871 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630871 ] PROTON-676: applied patch from dominic > proton-c: transport layer SSL failures not propagated back to Messenger in > pni_connection_readable > -- > > Key: PROTON-676 > URL: https://issues.apache.org/jira/browse/PROTON-676 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 24_ssl_transport_failure_fix_messenger.c.patch > > > When an ssl failure occurs during connection at the transport layer the error > is not propagated back to messenger (it is ignored). > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-704) delivery-count is set incorrectly during outbound transformation
[ https://issues.apache.org/jira/browse/PROTON-704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166805#comment-14166805 ] ASF subversion and git services commented on PROTON-704: Commit 1630876 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630876 ] PROTON-704: subtract 1 when setting delivery-count header based on JMSXDeliveryCount during outbound JMS transformation > delivery-count is set incorrectly during outbound transformation > > > Key: PROTON-704 > URL: https://issues.apache.org/jira/browse/PROTON-704 > Project: Qpid Proton > Issue Type: Bug >Affects Versions: 0.7 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.8 > > > In the proton-jms contrib artifact, delivery-count is set incorrectly (based > on JMSXDeliveryCount) during outbound JMS message transformation. > The value set is the same as the JMSXDeliveryCount value encountered, which > is incorrect as the two have different semantics. The delivery-count field in > the AMQP 1.0 message header tracks prior unsuccessful delivery attempts and > so should go 0,1,2 etc if set. JMSXDeliveryCount property in JMS tracks the > total number of delivery attempts, and should go 1,2,3. As such, > delivery-count should be 1 less than JMSXDeliveryCount, not equal to it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url
[ https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166803#comment-14166803 ] ASF subversion and git services commented on PROTON-693: Commit 1630873 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630873 ] PROTON-693: If the system doesn't have port definitions for amqp/amqps use the default values of 5672/5671. - Not all systems have /etc/service (or similar) files that define these ports, but our tests use them and the defaults are these strings. > Python Url class to wrap C function pni_parse_url > - > > Key: PROTON-693 > URL: https://issues.apache.org/jira/browse/PROTON-693 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: 0.8 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.8 > > > Add a Url class to the python binding that wraps the C function pni_url_parse. > Also added unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-656) pn_transport_close_{head, tail} no longer return an error code on framing error.
[
https://issues.apache.org/jira/browse/PROTON-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166757#comment-14166757
]
ASF subversion and git services commented on PROTON-656:
Commit 1630822 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630822 ]
Added events: PN_CONNECTION_BOUND/UNBOUND, PN_TRANSPORT_HEAD_CLOSED,
PN_TRANSPORT_TAIL_CLOSED, PN_TRANSPORT_CLOSED, and PN_TRANSPORT_ERROR. This
should address PROTON-656
> pn_transport_close_{head, tail} no longer return an error code on framing
> error.
>
>
> Key: PROTON-656
> URL: https://issues.apache.org/jira/browse/PROTON-656
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.8
>Reporter: Ken Giusti
>Priority: Blocker
> Fix For: 0.8
>
>
> In the 0.7 release, the transport interfaces pn_transport_close_head() and
> pn_transport_close_tail() used to return an error should the close occur at
> an 'unexpected' point on the protocol (framing error, for example).
> The behavior no longer occurs on trunk. This results in an API change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-700) small performance improvement from inling one fn.
[ https://issues.apache.org/jira/browse/PROTON-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166800#comment-14166800 ] ASF subversion and git services commented on PROTON-700: Commit 1630869 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630869 ] PROTON-700 By not saying 'static' on previous checkin, I broke debug builds. > small performance improvement from inling one fn. > - > > Key: PROTON-700 > URL: https://issues.apache.org/jira/browse/PROTON-700 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: michael goulish >Assignee: michael goulish >Priority: Minor > > inlining the internal function pn_data_node() improves speed somewhere > between 2.6% and 6%, depending on architecture. > This is based on testing I did with two C-based clients written at the engine > interface level. > The higher 6% figure was seen on a more modern machine with recent Intel > processors, the lower figure was seen on an older box with AMD processors. > But the effect is real: after 5- repetition before the change & 50 after, > T-test indicates odds of this happening by chance is 2.0e-18 . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-701) Windows ctest fixes for proton-c
[ https://issues.apache.org/jira/browse/PROTON-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166797#comment-14166797 ] ASF subversion and git services commented on PROTON-701: Commit 1630865 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630865 ] PROTON-701: drop error message and allow faster detection of network failure for large number of forced failures during ctest > Windows ctest fixes for proton-c > > > Key: PROTON-701 > URL: https://issues.apache.org/jira/browse/PROTON-701 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c, python-binding >Affects Versions: 0.8 > Environment: Windows >Reporter: Cliff Jansen >Priority: Minor > Fix For: 0.8 > > > Provide fixes related to ctest interaction with Windows proton-c for 0.8 as > time allows. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-701) Windows ctest fixes for proton-c
[ https://issues.apache.org/jira/browse/PROTON-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166795#comment-14166795 ] ASF subversion and git services commented on PROTON-701: Commit 1630863 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630863 ] PROTON-701: skip tests with python selector competing with IOCP selector > Windows ctest fixes for proton-c > > > Key: PROTON-701 > URL: https://issues.apache.org/jira/browse/PROTON-701 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c, python-binding >Affects Versions: 0.8 > Environment: Windows >Reporter: Cliff Jansen >Priority: Minor > Fix For: 0.8 > > > Provide fixes related to ctest interaction with Windows proton-c for 0.8 as > time allows. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-581) SSL/TLS support for Proton-c on Windows
[ https://issues.apache.org/jira/browse/PROTON-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166793#comment-14166793 ] ASF subversion and git services commented on PROTON-581: Commit 1630861 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630861 ] PROTON-581: part2, pick up minor changes since review board version > SSL/TLS support for Proton-c on Windows > --- > > Key: PROTON-581 > URL: https://issues.apache.org/jira/browse/PROTON-581 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-c >Affects Versions: 0.6, 0.7 > Environment: Windows >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: 0.8 > > Attachments: schannel_0.patch > > > Provide a Microsoft SChannel based SSL/TLS layer for Proton-c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-465) FindPerlLibs.cmake module in Proton behaves differently to Qpid's Perl detection
[ https://issues.apache.org/jira/browse/PROTON-465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166798#comment-14166798 ] ASF subversion and git services commented on PROTON-465: Commit 1630866 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630866 ] PROTON-465: FindPerlLibs fails on Ubuntu 12 If the search for libperl.so fails using the standard search in CMake, then this alternative tool kicks in and searchs other known locations for the file. > FindPerlLibs.cmake module in Proton behaves differently to Qpid's Perl > detection > > > Key: PROTON-465 > URL: https://issues.apache.org/jira/browse/PROTON-465 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.5 > Environment: Ubuntu 11.10 (at least) >Reporter: Fraser Adams >Assignee: Darryl L. Pierce >Priority: Minor > Fix For: 0.8 > > > With Proton when I do cmake .. it barfs with > -- Trying alternative search for Perl > -- PerlLibs Not Found > Though I can get it to play nicely by doing > cmake .. -DPERL_LIBRARY=`locate -n 1 libperl.so` > This might not be so unreasonable as I'm using a fairly old version of Ubuntu > that needs upgrading, however the Perl detection on Qpid works perfectly well > for me (and I'd assume for others too) which suggests that it's possibly more > thorough. > At the very least it would seem sensible to maintain consistency with the > cmake modules across various Qpid components. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-700) small performance improvement from inling one fn.
[ https://issues.apache.org/jira/browse/PROTON-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166791#comment-14166791 ] ASF subversion and git services commented on PROTON-700: Commit 1630859 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630859 ] PROTON-700 : small performance improvement from inlining pn_data_node(). This is a very popular function. improvement on newer box was 6% , on older box 2.6% t-test after 50 reps before & after says odd of the 2.6% figure happening by chance is 2.0e-18 . > small performance improvement from inling one fn. > - > > Key: PROTON-700 > URL: https://issues.apache.org/jira/browse/PROTON-700 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: michael goulish >Assignee: michael goulish >Priority: Minor > > inlining the internal function pn_data_node() improves speed somewhere > between 2.6% and 6%, depending on architecture. > This is based on testing I did with two C-based clients written at the engine > interface level. > The higher 6% figure was seen on a more modern machine with recent Intel > processors, the lower figure was seen on an older box with AMD processors. > But the effect is real: after 5- repetition before the change & 50 after, > T-test indicates odds of this happening by chance is 2.0e-18 . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-702) Windows proton-c selector can forget timer events
[ https://issues.apache.org/jira/browse/PROTON-702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166799#comment-14166799 ] ASF subversion and git services commented on PROTON-702: Commit 1630867 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630867 ] PROTON-702: mark interest in timer based on existence of deadline, not change in deadline > Windows proton-c selector can forget timer events > - > > Key: PROTON-702 > URL: https://issues.apache.org/jira/browse/PROTON-702 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 > Environment: Windows >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: 0.8 > > > A pn_selector_update to the identical deadline value will turn off the timer > notification. > This causes several ctest failures. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-701) Windows ctest fixes for proton-c
[ https://issues.apache.org/jira/browse/PROTON-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166796#comment-14166796 ] ASF subversion and git services commented on PROTON-701: Commit 1630864 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630864 ] PROTON-701: alter test for isSSLPresent to check on server capability instead of client capability > Windows ctest fixes for proton-c > > > Key: PROTON-701 > URL: https://issues.apache.org/jira/browse/PROTON-701 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c, python-binding >Affects Versions: 0.8 > Environment: Windows >Reporter: Cliff Jansen >Priority: Minor > Fix For: 0.8 > > > Provide fixes related to ctest interaction with Windows proton-c for 0.8 as > time allows. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-668) Document Proton-c IO restrictions for 0.8 release
[ https://issues.apache.org/jira/browse/PROTON-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166794#comment-14166794 ] ASF subversion and git services commented on PROTON-668: Commit 1630862 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630862 ] PROTON-668: Document Proton-c IO restrictions for 0.8 release > Document Proton-c IO restrictions for 0.8 release > - > > Key: PROTON-668 > URL: https://issues.apache.org/jira/browse/PROTON-668 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.8 >Reporter: Cliff Jansen >Assignee: Cliff Jansen >Priority: Blocker > Fix For: 0.8 > > > Proton is designed to provide an efficient IO layer that functions without > imposing a threading model on the application. Applications may (1) roll > their own IO and just use the Proton engine, (2) use all Proton primitives, > (3) use some Proton primitives augmented by an external event loop. > Case (1) is unrelated to this JIRA. The others may be restated: > Scenario 2: Proton event loop: a proton selector manages socket events for > all sockets placed in the selector, all associated sockets use pn_io_xxx() > calls. Sockets outside the selector are "unmanaged" and passed through to > the OS socket function unchanged. > Scenario 3: Third party event loop (no proton selector involved), all sockets > are treated as for "unmanaged" in scenario 2. > Scenario 4, 5...: Others to support? > The problem: > The Proton Posix pattern for efficient IO is: > "tell me when your (OS) buffer is ready for io transfer (in or out)" > Whereas the normal Windows pattern is somewhat reversed (IO completion ports): > "tell me when you are done transferring data (to or from) my (user space) > buffer" > The current Windows IOCP implementation (PROTON-640) tries to make the latter > look like the former with some constraints. There should be documentation > specifying reasonable limits on Proton usage that may be falsely implied by > the API but do not translate efficiently to Windows. Assuming that future > Windows implementations may adopt more aggressive performance strategies > (especially on the read side), I would propose something along the lines of: > a socket may only ever be used with a single pn_io_t in its lifetime > exception: a socket from pn_accept() is not yet associated with any > pn_io_t and its first use can be with any pn_io_t (or never with a pn_io_t at > all) > send/recv/close may not be intermixed with similar non-Proton OS calls > (otherwise: out of order or lost data) > a socket can move once from an external loop to a proton loop, but never > the other way > pn_pipe() values can only be used with pn_read and pn_write and > pn_selector_select, they cannot participate in an external event loop. > Furthermore, there is no thread safety except: > threads may do concurrent pn_io_xxx() calls as long as no two are > simultaneous on the same socket (where xxx is send/recv/read/write) > pn_selector_select() is thread safe against > pn_read/pn_write/pn_send/pn_recv, but the outcome of the select is > indeterminate. pn_selector_select() must be interrupted and restarted at any > time when other simultaneous IO may affect the outcome. > calls on different pn_io_t objects do not interact and are thread safe. > If it is desirable for a socket to be used in an external loop after being > used in a Proton loop, we would need some sort of blocking calls along the > lines of: > pn_io_flush() > pn_io_drain() > which would be no-ops on Posix but would unwind outstanding completions on > Windows. > Early criticism of any of the above assumptions would be greatly appreciated. > I will try to reword the above, or its evolution into the existing > documentation for 0.8. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-581) SSL/TLS support for Proton-c on Windows
[ https://issues.apache.org/jira/browse/PROTON-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166792#comment-14166792 ] ASF subversion and git services commented on PROTON-581: Commit 1630860 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630860 ] PROTON-581: SChannel client side TLS/SSL for Windows > SSL/TLS support for Proton-c on Windows > --- > > Key: PROTON-581 > URL: https://issues.apache.org/jira/browse/PROTON-581 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-c >Affects Versions: 0.6, 0.7 > Environment: Windows >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: 0.8 > > Attachments: schannel_0.patch > > > Provide a Microsoft SChannel based SSL/TLS layer for Proton-c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-576) proton-j: codec support for UTF-8 encoding and decoding appears broken?
[
https://issues.apache.org/jira/browse/PROTON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166784#comment-14166784
]
ASF subversion and git services commented on PROTON-576:
Commit 1630851 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630851 ]
PROTON-576: update test to make it compile on Java 6
> proton-j: codec support for UTF-8 encoding and decoding appears broken?
> ---
>
> Key: PROTON-576
> URL: https://issues.apache.org/jira/browse/PROTON-576
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
>Affects Versions: 0.7
>Reporter: Dominic Evans
> Fix For: 0.8
>
> Attachments: 02_fix_stringtype_encode_decode.patch, PROTON-576.patch
>
>
> It seems like Proton-J has its own custom UTF-8 encoder, but relies on Java
> String's built-in UTF-8 decoder. However, the code doesn't seem quite right
> and complex double byte UTF-8 like emoji ('📔🚢🍛🍴🍹🏊🏄') can quite easily fail to
> parse:
> | | Cause:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | Message:1 :- Cannot parse String
> | | StackTrace:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:48)
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:36)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readRaw(DecoderImpl.java:945)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:172)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:124)
> | | at
> org.apache.qpid.proton.codec.DynamicTypeConstructor.readValue(DynamicTypeConstructor.java:39)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readObject(DecoderImpl.java:885)
> | | at
> org.apache.qpid.proton.message.impl.MessageImpl.decode(MessageImpl.java:629)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url
[ https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166782#comment-14166782 ] ASF subversion and git services commented on PROTON-693: Commit 1630850 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630850 ] PROTON-693: Export pn_url... symbols as C not C++ > Python Url class to wrap C function pni_parse_url > - > > Key: PROTON-693 > URL: https://issues.apache.org/jira/browse/PROTON-693 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: 0.8 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.8 > > > Add a Url class to the python binding that wraps the C function pni_url_parse. > Also added unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-661) pn_message_save_* do not return correct message size when PN_OVERFLOW
[ https://issues.apache.org/jira/browse/PROTON-661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166786#comment-14166786 ] ASF subversion and git services commented on PROTON-661: Commit 1630853 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630853 ] PROTON-661: applied patch from miguel > pn_message_save_* do not return correct message size when PN_OVERFLOW > - > > Key: PROTON-661 > URL: https://issues.apache.org/jira/browse/PROTON-661 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.4, 0.5, 0.7 > Environment: All plataforms >Reporter: Miguel da Rocha Correia Lima >Assignee: Rafael H. Schloming >Priority: Critical > Fix For: 0.8 > > Attachments: landix-ret-size-message-save.patch > > > Expected behavior: > When you use pn_message_save* functions API, you pass char *data and size_t > *size. If the size IS NOT enough to save mesage body text, this functions > return in size_t *size variable, the necessary buffer size and return > PN_OVERFLOW status. > Behavior observed: > The pn_message_save* functions API return PN_OVERFLOW status and DO NOT > return a correct value of necessary buffer. > Patch to fix expected behavior is attached: -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-699) Messenger installed examples send,recv do not compile
[ https://issues.apache.org/jira/browse/PROTON-699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166789#comment-14166789 ] ASF subversion and git services commented on PROTON-699: Commit 1630857 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630857 ] PROTON-699: Messenger installed examples send,recv do not compile. Keep pncompat internal folder structure. > Messenger installed examples send,recv do not compile > - > > Key: PROTON-699 > URL: https://issues.apache.org/jira/browse/PROTON-699 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 > Environment: Windows and Linux >Reporter: Chuck Rolke > Fix For: 0.8 > > > The cmake packaging of the install directory > /proton/examples/messenger collapses the files from > /pncompat/internal into /pncompat. Folder /pncompat/internal is absent. > Compiles fails since the sources use '#include "internal/getopt.h"' and the > file is not found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-698) ClassCastException occurs when testing equality of Binary instance against a different type of Object
[ https://issues.apache.org/jira/browse/PROTON-698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166788#comment-14166788 ] ASF subversion and git services commented on PROTON-698: Commit 1630855 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630855 ] PROTON-698: return false if given object class differs, and shortcut equality of the object with itself > ClassCastException occurs when testing equality of Binary instance against a > different type of Object > - > > Key: PROTON-698 > URL: https://issues.apache.org/jira/browse/PROTON-698 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.7 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.8 > > > If you call equals on a Binary instance with another type of Object, a > ClassCastException results because Binary#equals(..) does an unchecked cast. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-689) Python binding does not expose transport error details
[ https://issues.apache.org/jira/browse/PROTON-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166787#comment-14166787 ] ASF subversion and git services commented on PROTON-689: Commit 1630854 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630854 ] PROTON-689: added a condition to the transport along with bindings to expose it > Python binding does not expose transport error details > -- > > Key: PROTON-689 > URL: https://issues.apache.org/jira/browse/PROTON-689 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: 0.8 >Reporter: Ken Giusti >Assignee: Rafael H. Schloming > Fix For: 0.8 > > > The proton event model defines a TRANSPORT_ERROR event, but when the event > occurs there is no way to extract the error code nor the error text from the > transport when using the python binding. > The connection class exports the error code via the 'error' property. I'd > like to see an 'error' property added to the Transport class, and an > 'error_text' property to both the Transport and the Connection for > completeness. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-576) proton-j: codec support for UTF-8 encoding and decoding appears broken?
[
https://issues.apache.org/jira/browse/PROTON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166785#comment-14166785
]
ASF subversion and git services commented on PROTON-576:
Commit 1630852 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630852 ]
PROTON-576: updates to bring things into line with the patch on the JIRA,
rather than a stale older version I actually applied (not having a good day :P)
> proton-j: codec support for UTF-8 encoding and decoding appears broken?
> ---
>
> Key: PROTON-576
> URL: https://issues.apache.org/jira/browse/PROTON-576
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
>Affects Versions: 0.7
>Reporter: Dominic Evans
> Fix For: 0.8
>
> Attachments: 02_fix_stringtype_encode_decode.patch, PROTON-576.patch
>
>
> It seems like Proton-J has its own custom UTF-8 encoder, but relies on Java
> String's built-in UTF-8 decoder. However, the code doesn't seem quite right
> and complex double byte UTF-8 like emoji ('📔🚢🍛🍴🍹🏊🏄') can quite easily fail to
> parse:
> | | Cause:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | Message:1 :- Cannot parse String
> | | StackTrace:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:48)
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:36)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readRaw(DecoderImpl.java:945)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:172)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:124)
> | | at
> org.apache.qpid.proton.codec.DynamicTypeConstructor.readValue(DynamicTypeConstructor.java:39)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readObject(DecoderImpl.java:885)
> | | at
> org.apache.qpid.proton.message.impl.MessageImpl.decode(MessageImpl.java:629)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-676) proton-c: transport layer SSL failures not propagated back to Messenger in pni_connection_readable
[ https://issues.apache.org/jira/browse/PROTON-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166781#comment-14166781 ] ASF subversion and git services commented on PROTON-676: Commit 1630849 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630849 ] PROTON-696: Rearrange the header files: - Reduce transitive header inclusions - Remove proton/util.h and move its contents to src/util.h. All the defined symbols were internal. - Stop including with lines like #include "../blah.h" as this isn't needed anymore. (Fixes windows breakage from PROTON-676) > proton-c: transport layer SSL failures not propagated back to Messenger in > pni_connection_readable > -- > > Key: PROTON-676 > URL: https://issues.apache.org/jira/browse/PROTON-676 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 24_ssl_transport_failure_fix_messenger.c.patch > > > When an ssl failure occurs during connection at the transport layer the error > is not propagated back to messenger (it is ignored). > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-677) proton-c: transport incorrectly detaches all links with closed=true by default
[ https://issues.apache.org/jira/browse/PROTON-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166776#comment-14166776 ] ASF subversion and git services commented on PROTON-677: Commit 1630845 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630845 ] PROTON-677: added support for detach > proton-c: transport incorrectly detaches all links with closed=true by default > -- > > Key: PROTON-677 > URL: https://issues.apache.org/jira/browse/PROTON-677 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 26_stop_link_detach_closed_if_sub_ttl_transport.c.patch > > > qpid-proton detaches all links with closed=true by default. If a subscription > has a time-to-live and is not expected to be destroyed on detach then we > shouldn't be setting closed=true on the detach call. > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url
[ https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166779#comment-14166779 ] ASF subversion and git services commented on PROTON-693: Commit 1630848 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630848 ] PROTON-693: Make pn_url_t a proper pn_class object, hashable & comparable. > Python Url class to wrap C function pni_parse_url > - > > Key: PROTON-693 > URL: https://issues.apache.org/jira/browse/PROTON-693 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: 0.8 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.8 > > > Add a Url class to the python binding that wraps the C function pni_url_parse. > Also added unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-696) The header file usage needs some improvement
[ https://issues.apache.org/jira/browse/PROTON-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166780#comment-14166780 ] ASF subversion and git services commented on PROTON-696: Commit 1630849 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630849 ] PROTON-696: Rearrange the header files: - Reduce transitive header inclusions - Remove proton/util.h and move its contents to src/util.h. All the defined symbols were internal. - Stop including with lines like #include "../blah.h" as this isn't needed anymore. (Fixes windows breakage from PROTON-676) > The header file usage needs some improvement > > > Key: PROTON-696 > URL: https://issues.apache.org/jira/browse/PROTON-696 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > There are a number of small header file problems with proton. > * Some header files include too many other header files and so export too > many symbols - this is especially problematic if they use platform header > files. > * Conversely some header files are not self contained and do not define all > the symbols they use (by using the correct include files themselves) > * There are symbols exported in the installed header files which are internal > only symbols -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-680) proton-c: Messenger doesn't provide a way of obtaining link or delivery information
[ https://issues.apache.org/jira/browse/PROTON-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166778#comment-14166778 ] ASF subversion and git services commented on PROTON-680: Commit 1630847 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630847 ] PROTON-680: link and delivery accessors (patch from dominic) > proton-c: Messenger doesn't provide a way of obtaining link or delivery > information > --- > > Key: PROTON-680 > URL: https://issues.apache.org/jira/browse/PROTON-680 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 29_access_messenger_links_messenger.c.patch, > 29_access_messenger_links_messenger.h.patch, > 30_access_messenger_deliveries_messenger.c.patch, > 31_access_messenger_deliveries_messenger.h.patch > > > This would be useful for determining why a delivery was rejected by the > server (for example). > Patches attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-679) proton-c: add a "manual" link credit mode to Messenger
[ https://issues.apache.org/jira/browse/PROTON-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166777#comment-14166777 ] ASF subversion and git services commented on PROTON-679: Commit 1630846 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630846 ] PROTON-679: patch from dominic for manual credit mode > proton-c: add a "manual" link credit mode to Messenger > -- > > Key: PROTON-679 > URL: https://issues.apache.org/jira/browse/PROTON-679 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 28_manual_link_management_messenger.c.patch > > > Add a manual link credit mode to Messenger. When 'LINK_CREDIT_MANUAL' mode is > used, Messenger does not try to track link credit or flow more link credit. > This is considered the responsibility of the > application code using Messenger. > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url
[
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166774#comment-14166774
]
ASF subversion and git services commented on PROTON-693:
Commit 1630842 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630842 ]
PROTON-693: Implement C-API wrappers in Java for jython, clean up Url
implementation.
- Java implementation of fake C API for Jython SWIG wrappers based on
messenger.impl.Address.
- Minor extensions to Address.java
- Minor change to Address.java to be consistent with C parser on one corner
case:
- is url("/foo") a host called "/foo" or an empty host and a path "foo"
- fixed Java parser to agree with C - path "foo"
- Rename getters from url_* to url_get_*.
- Use pn_string_t formatting functions to build URL string.
> Python Url class to wrap C function pni_parse_url
> -
>
> Key: PROTON-693
> URL: https://issues.apache.org/jira/browse/PROTON-693
> Project: Qpid Proton
> Issue Type: Improvement
> Components: python-binding
>Affects Versions: 0.8
>Reporter: Alan Conway
>Assignee: Alan Conway
> Fix For: 0.8
>
>
> Add a Url class to the python binding that wraps the C function pni_url_parse.
> Also added unit tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-687) Memory corruption in proton-test
[ https://issues.apache.org/jira/browse/PROTON-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166775#comment-14166775 ] ASF subversion and git services commented on PROTON-687: Commit 1630844 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630844 ] PROTON-687: clear reference to C object when delivery is released. > Memory corruption in proton-test > > > Key: PROTON-687 > URL: https://issues.apache.org/jira/browse/PROTON-687 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c, python-binding >Affects Versions: 0.8 >Reporter: Cliff Jansen >Assignee: Ken Giusti >Priority: Blocker > Fix For: 0.8 > > Attachments: segv.patch > > > proton-test will fail with memory violations. Deallocated memory is > accessed, usually with benign results but less often on Windows. > The attached crude patch allows the bug to be "discovered" on Linux as well. > It is not clear to me if the problem is with the swig wrapper, or whether > this just exposes a reference counting bug in proton-c. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-684) Restrict IOCP enlistment to pn_selector_t usage scenarios in Windows
[ https://issues.apache.org/jira/browse/PROTON-684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166771#comment-14166771 ] ASF subversion and git services commented on PROTON-684: Commit 1630839 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630839 ] PROTON-684: Restrict IOCP enlistment to pn_selector_t usage scenarios in Windows > Restrict IOCP enlistment to pn_selector_t usage scenarios in Windows > > > Key: PROTON-684 > URL: https://issues.apache.org/jira/browse/PROTON-684 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 > Environment: Windows >Reporter: Cliff Jansen >Assignee: Cliff Jansen >Priority: Blocker > Fix For: 0.8 > > Attachments: PN-684-0.patch > > > Prevent IOCP enlistemnt interfering with external event loops. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url
[ https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166769#comment-14166769 ] ASF subversion and git services commented on PROTON-693: Commit 1630837 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630837 ] PROTON-693: Fix for windows build > Python Url class to wrap C function pni_parse_url > - > > Key: PROTON-693 > URL: https://issues.apache.org/jira/browse/PROTON-693 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: 0.8 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.8 > > > Add a Url class to the python binding that wraps the C function pni_url_parse. > Also added unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-576) proton-j: codec support for UTF-8 encoding and decoding appears broken?
[
https://issues.apache.org/jira/browse/PROTON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166773#comment-14166773
]
ASF subversion and git services commented on PROTON-576:
Commit 1630841 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630841 ]
PROTON-576: update String UTF-8 encoding to handle high range unicode
characters / surrogate pairs
Applied patch from Dominic Evans with modifications by Rob Godfrey
> proton-j: codec support for UTF-8 encoding and decoding appears broken?
> ---
>
> Key: PROTON-576
> URL: https://issues.apache.org/jira/browse/PROTON-576
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-j
>Affects Versions: 0.7
>Reporter: Dominic Evans
> Fix For: 0.8
>
> Attachments: 02_fix_stringtype_encode_decode.patch, PROTON-576.patch
>
>
> It seems like Proton-J has its own custom UTF-8 encoder, but relies on Java
> String's built-in UTF-8 decoder. However, the code doesn't seem quite right
> and complex double byte UTF-8 like emoji ('📔🚢🍛🍴🍹🏊🏄') can quite easily fail to
> parse:
> | | Cause:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | Message:1 :- Cannot parse String
> | | StackTrace:1 :- java.lang.IllegalArgumentException: Cannot parse
> String
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:48)
> | | at
> org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:36)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readRaw(DecoderImpl.java:945)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:172)
> | | at
> org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:124)
> | | at
> org.apache.qpid.proton.codec.DynamicTypeConstructor.readValue(DynamicTypeConstructor.java:39)
> | | at
> org.apache.qpid.proton.codec.DecoderImpl.readObject(DecoderImpl.java:885)
> | | at
> org.apache.qpid.proton.message.impl.MessageImpl.decode(MessageImpl.java:629)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-674) proton-c: Messenger doesn't provide a way of setting the TTL on a subscription
[ https://issues.apache.org/jira/browse/PROTON-674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166767#comment-14166767 ] ASF subversion and git services commented on PROTON-674: Commit 1630835 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630835 ] PROTON-674: patch from dominic for setting ttl on a subscription > proton-c: Messenger doesn't provide a way of setting the TTL on a subscription > -- > > Key: PROTON-674 > URL: https://issues.apache.org/jira/browse/PROTON-674 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 22_add_messenger_subscribe_ttl_method_messenger.c.patch, > 22_add_messenger_subscribe_ttl_method_messenger.h.patch > > > Messenger doesn't provide a way of setting ttl on a subscription. We want to > be able to specify the timeout of a given subscription link when we open it. > Patches attached to add pn_messenger_subscribe_ttl call. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-688) pn_transport_unbind() doesn't reset all relevant trasnport state
[ https://issues.apache.org/jira/browse/PROTON-688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166765#comment-14166765 ] ASF subversion and git services commented on PROTON-688: Commit 1630833 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630833 ] PROTON-688: reset transport state on unbind > pn_transport_unbind() doesn't reset all relevant trasnport state > > > Key: PROTON-688 > URL: https://issues.apache.org/jira/browse/PROTON-688 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c, python-binding >Affects Versions: 0.8 >Reporter: Gordon Sim > Fix For: 0.8 > > > Unbinding a transport on connection failure, then trying to rebind a new > transport to the original connection option doesn't work as expected as not > all relevant state is reset. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url
[ https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166766#comment-14166766 ] ASF subversion and git services commented on PROTON-693: Commit 1630834 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630834 ] PROTON-693: Python Url class to wrap C function pni_parse_url Also added unit tests. > Python Url class to wrap C function pni_parse_url > - > > Key: PROTON-693 > URL: https://issues.apache.org/jira/browse/PROTON-693 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: 0.8 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.8 > > > Add a Url class to the python binding that wraps the C function pni_url_parse. > Also added unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url
[ https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166768#comment-14166768 ] ASF subversion and git services commented on PROTON-693: Commit 1630836 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630836 ] PROTON-693: Python Url class to wrap C function pni_parse_url It was pointed out that pni_parse_url is an internal function and the interface is not suitable for public API. Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the need for previous swig insanity and is cleaner all round. Internally still uses the pni_parse_url parser, we can clean that up later. > Python Url class to wrap C function pni_parse_url > - > > Key: PROTON-693 > URL: https://issues.apache.org/jira/browse/PROTON-693 > Project: Qpid Proton > Issue Type: Improvement > Components: python-binding >Affects Versions: 0.8 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.8 > > > Add a Url class to the python binding that wraps the C function pni_url_parse. > Also added unit tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-676) proton-c: transport layer SSL failures not propagated back to Messenger in pni_connection_readable
[ https://issues.apache.org/jira/browse/PROTON-676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166772#comment-14166772 ] ASF subversion and git services commented on PROTON-676: Commit 1630840 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630840 ] PROTON-676: patch from dominic for setter for SSL peer authentication mode > proton-c: transport layer SSL failures not propagated back to Messenger in > pni_connection_readable > -- > > Key: PROTON-676 > URL: https://issues.apache.org/jira/browse/PROTON-676 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 24_ssl_transport_failure_fix_messenger.c.patch > > > When an ssl failure occurs during connection at the transport layer the error > is not propagated back to messenger (it is ignored). > Patch attached. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-694) splitting contrib/JMSMappingOutboundTransformer's encoding and transformation
[ https://issues.apache.org/jira/browse/PROTON-694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166770#comment-14166770 ] ASF subversion and git services commented on PROTON-694: Commit 1630838 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630838 ] PROTON-694: split conversion and encoding during outbound transformation to allow calling separately Applied patch from Clebert Suconic > splitting contrib/JMSMappingOutboundTransformer's encoding and transformation > - > > Key: PROTON-694 > URL: https://issues.apache.org/jira/browse/PROTON-694 > Project: Qpid Proton > Issue Type: Bug >Reporter: clebert suconic > Fix For: 0.8 > > Attachments: diff.patch > > > I just need the transformation from this method, not the actual encoding. > I need to later encode the ProtonJMessage using NettyBuffer which is pooled > and more efficient than the method done within JMSMappingOutboundTransformer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-671) proton-c: Messenger doesn't provide a way to set the link settlement modes it uses
[ https://issues.apache.org/jira/browse/PROTON-671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166762#comment-14166762 ] ASF subversion and git services commented on PROTON-671: Commit 1630830 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630830 ] PROTON-671: patch for settlement modes from dominic > proton-c: Messenger doesn't provide a way to set the link settlement modes it > uses > --- > > Key: PROTON-671 > URL: https://issues.apache.org/jira/browse/PROTON-671 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 13_add_pn_messenger_set_settle_mode_functions.patch, > 13_add_pn_messenger_set_settle_mode_functions_to_header.patch > > > Messenger doesn't provide a way to set link settlement modes. Messenger > defaults to PN_SND_SETTLED and PN_RCV_FIRST and doesn't provide a way to > override that behaviour. > Patches attached to allow these to be configured. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-669) proton-c: Messenger abstracts away connections, but it would be useful to fail fast for auth errors etc.
[ https://issues.apache.org/jira/browse/PROTON-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166760#comment-14166760 ] ASF subversion and git services commented on PROTON-669: Commit 1630828 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630828 ] PROTON-669: applied patch from dominic for fail fast checking of messenger routes > proton-c: Messenger abstracts away connections, but it would be useful to > fail fast for auth errors etc. > > > Key: PROTON-669 > URL: https://issues.apache.org/jira/browse/PROTON-669 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 07_add_messenger_route_check_on_start.patch, > 07_add_messenger_route_check_on_start_header.patch, > 07_add_messenger_route_check_on_start_transform.c.patch, > 07_add_messenger_route_check_on_start_transform.h.patch > > > As previously discussed on the mailing list under "[Using the messenger API > to connect to a server without sending or > subscribing|http://qpid.2158936.n2.nabble.com/Using-the-messenger-API-to-connect-to-a-server-without-sending-or-subscribing-td7607184.html]"; > Messenger doesn't provide a way of requesting a connection. Messenger has > been designed to abstract away the notion of establishing connections from > the user, but we would like to fail fast in those situations and return > authentication errors (e.g.,) to the user. Rafa suggested that we could add > an option to messenger to enable the checking of routes at startup, which is > what the attached patch intends to do. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-670) proton-c: Messenger doesn't provide accessors for the links it is using
[ https://issues.apache.org/jira/browse/PROTON-670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166761#comment-14166761 ] ASF subversion and git services commented on PROTON-670: Commit 1630829 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630829 ] PROTON-670: applied patch from dominic for link accessors > proton-c: Messenger doesn't provide accessors for the links it is using > --- > > Key: PROTON-670 > URL: https://issues.apache.org/jira/browse/PROTON-670 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 12_get_link_from_tracker_messenger.c.patch, > 12_get_link_from_tracker_messenger.h.patch > > > Messenger doesn't provide accessors for the links it uses. > As a consuming application that is using the Messenger API, it would be > helpful to have access to this information so that you can determine which > subscription address a given message was received upon. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-673) proton-c: Messenger doesn't provide a way to obtain the remote idle timeout
[ https://issues.apache.org/jira/browse/PROTON-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166764#comment-14166764 ] ASF subversion and git services commented on PROTON-673: Commit 1630832 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630832 ] PROTON-673: patch from dominic for messenger accessors for remote idle timeout > proton-c: Messenger doesn't provide a way to obtain the remote idle timeout > --- > > Key: PROTON-673 > URL: https://issues.apache.org/jira/browse/PROTON-673 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 19_add_get_remote_idle_timeout_to_messenger.c.patch, > 19_add_get_remote_idle_timeout_to_messenger.h.patch > > > Messenger doesn't provide a way to obtain the remote idle timeout which is > required to ensure the client application can maintain the keep alive > heartbeat, i.e. by calling pn_messenger_work at a sufficiently regular rate. > Patch attached to implement this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-672) proton-c: Messenger doesn't support setting the transport tracer
[ https://issues.apache.org/jira/browse/PROTON-672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166763#comment-14166763 ] ASF subversion and git services commented on PROTON-672: Commit 1630831 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630831 ] PROTON-672: patch from dominic for setting the tracer from messenger, also includes accessor for getting the connection associated with a transport > proton-c: Messenger doesn't support setting the transport tracer > > > Key: PROTON-672 > URL: https://issues.apache.org/jira/browse/PROTON-672 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: 14_add_tracer_to_messenger.c.patch, > 14_add_tracer_to_messenger.h.patch, 15_get_connection_from_transport.c.patch, > 15_get_connection_from_transport.h.patch > > > Messenger doesn't support setting the transport tracer. Messenger ought to > provide a way to allow the transport tracer function to be overriden so that > tracing can be captured by the consuming application. > Patches attached to implement this. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-686) va_copy is C99 (not C89) and is not supported by the Microsoft Visual Studio C compiler before VS 2013
[ https://issues.apache.org/jira/browse/PROTON-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166756#comment-14166756 ] ASF subversion and git services commented on PROTON-686: Commit 1630819 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630819 ] PROTON-686, PROTON-???: Fix recent changes to compile on windows > va_copy is C99 (not C89) and is not supported by the Microsoft Visual Studio > C compiler before VS 2013 > -- > > Key: PROTON-686 > URL: https://issues.apache.org/jira/browse/PROTON-686 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Blocker > Fix For: 0.8 > > > in r1625123 proton-c/src/engine/string.c was introduced: this uses va_copy() > in pn_string_vaddf(). > However this does not exist in the Microsoft C Compiler before VS 2013 (which > has most of the useful C99 features in it). > It is probable that the macro could be a simple assignment in any case as > vsprintf() can't change the arguments. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-651) Export the proton version numbers via the bindings.
[ https://issues.apache.org/jira/browse/PROTON-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166750#comment-14166750 ] ASF subversion and git services commented on PROTON-651: Commit 1630809 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630809 ] PROTON-651: remove the extraineous 'PN_' if under the proton namespace. > Export the proton version numbers via the bindings. > --- > > Key: PROTON-651 > URL: https://issues.apache.org/jira/browse/PROTON-651 > Project: Qpid Proton > Issue Type: New Feature > Components: perl-binding, python-binding, ruby-binding >Affects Versions: 0.7 >Reporter: Ken Giusti >Assignee: Rafael H. Schloming > Fix For: 0.8 > > > Provide a way to access the proton version number (PN_VERSION_MAJOR and > PN_VERSION_MINOR) via the bindings. > This will allow applications determine which version of the Proton libraries > are available. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-685) calling free() on session with multiple Sender or Receiver links leads to ConcurrentModificationException
[ https://issues.apache.org/jira/browse/PROTON-685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166746#comment-14166746 ] ASF subversion and git services commented on PROTON-685: Commit 1630806 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630806 ] PROTON-685: iterate on a copy of the values to prevent CME after the child free() calls modifies the map > calling free() on session with multiple Sender or Receiver links leads to > ConcurrentModificationException > - > > Key: PROTON-685 > URL: https://issues.apache.org/jira/browse/PROTON-685 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.8 > > Attachments: > 0003-PROTON-685-python-test-which-doesnt-run-against-prot.patch > > > If a session (or in this case, actually its parent connection) has free() > called on it with multiple Sender or Receiver links then a > ConcurrentModificationException is thrown during the process due to modifying > a map whilst iterating its values. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-662) decoder.c pn_decoder_decode_value has a test that won't correctly execute.
[ https://issues.apache.org/jira/browse/PROTON-662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166740#comment-14166740 ] ASF subversion and git services commented on PROTON-662: Commit 1630798 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630798 ] PROTON-662: decoder.c pn_decoder_decode_value has a test that won't correctly execute. > decoder.c pn_decoder_decode_value has a test that won't correctly execute. > -- > > Key: PROTON-662 > URL: https://issues.apache.org/jira/browse/PROTON-662 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: Fraser Adams >Priority: Minor > > In decoder.c pn_decoder_decode_value there is a block of code: > pn_type_t type = pn_code2type(acode); > if (type < 0) return type; > The test will not execute correctly because pn_type_t is an unsigned > enumeration. The reason for the test seems to be to trap the case where > pn_code2type does: > return (pn_type_t) PN_ARG_ERR; > rather than returning the type. > Compiling with Clang rather than gcc flags this warning (which prevents using > warnings as errors with Clang): > warning: > comparison of unsigned enum expression < 0 is always false > [-Wtautological-compare] > if (type < 0) return type; > ^ ~ > Trivial fix is to use correct casting: > if ((int)type < 0) return (int)type; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-664) add pom profile to allow creating souces jar during non-release builds.
[ https://issues.apache.org/jira/browse/PROTON-664?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166742#comment-14166742 ] ASF subversion and git services commented on PROTON-664: Commit 1630800 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630800 ] PROTON-664: add a profile to allow creating sources jars outwith the release build > add pom profile to allow creating souces jar during non-release builds. > --- > > Key: PROTON-664 > URL: https://issues.apache.org/jira/browse/PROTON-664 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.8 > > > Add pom profile to allow creating souces jar during non-release builds. > This would be useful when debugging issues in projects depending on Proton > trunk. We may wish to enable this for the CI-produced snapshots. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-663) codec.c pni_inspect_atom uses the wrong format for case PN_CHAR
[ https://issues.apache.org/jira/browse/PROTON-663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166741#comment-14166741 ] ASF subversion and git services commented on PROTON-663: Commit 1630799 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630799 ] PROTON-663: codec.c pni_inspect_atom uses the wrong format for case PN_CHAR > codec.c pni_inspect_atom uses the wrong format for case PN_CHAR > --- > > Key: PROTON-663 > URL: https://issues.apache.org/jira/browse/PROTON-663 > Project: Qpid Proton > Issue Type: Bug >Reporter: Fraser Adams > > In codec.c pni_inspect_atom > case PN_CHAR > Clang reports the following > warning: > format specifies type 'wint_t' (aka 'int') but the argument has type > 'pn_char_t' (aka 'unsigned int') [-Wformat] > return pn_string_addf(str, "%lc", atom->u.as_char); > ~~~^~~ > %c > The line should read > case PN_CHAR: > return pn_string_addf(str, "%c", atom->u.as_char); -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-666) TransactionalState applied to indicate the txn-id before sending has no effect on the outgoing transfer frames
[ https://issues.apache.org/jira/browse/PROTON-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166743#comment-14166743 ] ASF subversion and git services commented on PROTON-666: Commit 1630801 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630801 ] PROTON-666: if a delivery has local state before being sent then apply it to the transfer frames, allowing them to e.g. carry TransactionalState with a txn-id within. > TransactionalState applied to indicate the txn-id before sending has no > effect on the outgoing transfer frames > -- > > Key: PROTON-666 > URL: https://issues.apache.org/jira/browse/PROTON-666 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.7 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell > Fix For: 0.8 > > > In order to publish messages in a transaction, it is necessary to apply state > to the outgoing transfer frames. Proton-J does allow applying a disposition > change to the delivery with the relevant TransactionalState (which contains > the required txn-id), however this has no impact on the transfer frames which > then get emitted from the transport, resulting in the message transfers being > considered non-transactional. > The transport implementation should be updated to apply existing local > delivery state to the outgoing transfer frames. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-651) Export the proton version numbers via the bindings.
[ https://issues.apache.org/jira/browse/PROTON-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166735#comment-14166735 ] ASF subversion and git services commented on PROTON-651: Commit 1630794 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630794 ] PROTON-651: added version constants for python, php, and ruby bindings > Export the proton version numbers via the bindings. > --- > > Key: PROTON-651 > URL: https://issues.apache.org/jira/browse/PROTON-651 > Project: Qpid Proton > Issue Type: New Feature > Components: perl-binding, python-binding, ruby-binding >Affects Versions: 0.7 >Reporter: Ken Giusti >Assignee: Rafael H. Schloming > Fix For: 0.8 > > > Provide a way to access the proton version number (PN_VERSION_MAJOR and > PN_VERSION_MINOR) via the bindings. > This will allow applications determine which version of the Proton libraries > are available. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-651) Export the proton version numbers via the bindings.
[ https://issues.apache.org/jira/browse/PROTON-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166739#comment-14166739 ] ASF subversion and git services commented on PROTON-651: Commit 1630797 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630797 ] PROTON-651: Export Proton major/minor version number in Perl. > Export the proton version numbers via the bindings. > --- > > Key: PROTON-651 > URL: https://issues.apache.org/jira/browse/PROTON-651 > Project: Qpid Proton > Issue Type: New Feature > Components: perl-binding, python-binding, ruby-binding >Affects Versions: 0.7 >Reporter: Ken Giusti >Assignee: Rafael H. Schloming > Fix For: 0.8 > > > Provide a way to access the proton version number (PN_VERSION_MAJOR and > PN_VERSION_MINOR) via the bindings. > This will allow applications determine which version of the Proton libraries > are available. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-655) URL parser fails to parse ActiveMQ dynamically generated address
[
https://issues.apache.org/jira/browse/PROTON-655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166733#comment-14166733
]
ASF subversion and git services commented on PROTON-655:
Commit 1630791 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630791 ]
PROTON-655: Fix url parsing to cope with ActiveMQ generated URLS
- Also add some more unit test urls
> URL parser fails to parse ActiveMQ dynamically generated address
>
>
> Key: PROTON-655
> URL: https://issues.apache.org/jira/browse/PROTON-655
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.7
>Reporter: Fabien CHEVALIER
>Assignee: Andrew Stitcher
> Labels: patch
> Fix For: 0.8
>
> Attachments: 0001-Url-parser-bugfix.patch
>
>
> This address:
> localhost/temp-queue://ID:ganymede-36663-1408448359876-2:123:0
> Gets parsed as follows:
> {text = 0xa527e68, passive = false, scheme = 0xa5476c0
> "localhost/temp-queue", user = 0x0, pass = 0x0, host = 0xa5476d7 "ID", port
> = 0xa5476da "ganymede-36663-1408448359876-2:123:0", name = 0x0}
> This is obviously wrong.
> The attached patch fixes that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-582) Perl language bindings do not properly identify integers from strings when encoding
[
https://issues.apache.org/jira/browse/PROTON-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166738#comment-14166738
]
ASF subversion and git services commented on PROTON-582:
Commit 1630796 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630796 ]
PROTON-582: Missing utils.pm module
The module was missed when the original code was submitted.
> Perl language bindings do not properly identify integers from strings when
> encoding
> ---
>
> Key: PROTON-582
> URL: https://issues.apache.org/jira/browse/PROTON-582
> Project: Qpid Proton
> Issue Type: Bug
> Components: perl-binding
>Affects Versions: 0.7
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.8
>
>
> Rafi found the code:
> sub isnum ($) {
> return 0 if $_[0] eq '';
> $_[0] ^ $_[0] ? 0 : 1
> }
> which can differentiate strings from integers. An additional piece can check
> for a . in a numeric value to differentiate integers from floating point
> values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton
[ https://issues.apache.org/jira/browse/PROTON-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166732#comment-14166732 ] ASF subversion and git services commented on PROTON-640: Commit 1630790 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630790 ] PROTON-640 Windows IO completion port implementation for pn_io and pn_selectable classes > IO completion port Windows IO for Proton > > > Key: PROTON-640 > URL: https://issues.apache.org/jira/browse/PROTON-640 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.7 > Environment: Windows >Reporter: Cliff Jansen >Assignee: Cliff Jansen > Fix For: 0.8 > > > Provide a native IO completion port layer similar to the C++ QPID version for > Proton. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-610) proton-c: messenger doesn't honour an advertised remote idle timeout
[ https://issues.apache.org/jira/browse/PROTON-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166737#comment-14166737 ] ASF subversion and git services commented on PROTON-610: Commit 1630795 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630795 ] PROTON-610: Messenger code doesn't send heartbeat frames > proton-c: messenger doesn't honour an advertised remote idle timeout > > > Key: PROTON-610 > URL: https://issues.apache.org/jira/browse/PROTON-610 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Andrew Stitcher > Fix For: 0.8 > > Attachments: 0001-ensure-messenger-honours-remote-idle-timeout.patch > > > The changes under PROTON-111 added support to the underlying proton engine > for honouring a remote idle timeout (as per the AMQP 1.0 spec) and sending > empty null frames on a heartbeat interval to prevent the idle timeout > expiring (and hence causing the client to be disconnect), However, the > Messenger API doesn't currently drive the same behaviour and so will be > disconnected from any broker that has implemented such a timeout. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-657) OSX: build proton with homebrew openssl
[ https://issues.apache.org/jira/browse/PROTON-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166734#comment-14166734 ] ASF subversion and git services commented on PROTON-657: Commit 1630792 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630792 ] PROTON-657: Fix build to use detected include directory for OpenSSL > OSX: build proton with homebrew openssl > --- > > Key: PROTON-657 > URL: https://issues.apache.org/jira/browse/PROTON-657 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.7 > Environment: OSX 10.9.4 >Reporter: Bozo Dragojevic >Assignee: Andrew Stitcher > Fix For: 0.8 > > Attachments: > 0001-PROTON-657-OSX-build-proton-with-homebrew-openssl.patch > > > System supplied openssl deprecates practically all methods used by proton. > Compile against openssl from homebrew which requires additional include > and link directory. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-641) pn_connection_t leaked when links not closed
[ https://issues.apache.org/jira/browse/PROTON-641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166731#comment-14166731 ] ASF subversion and git services commented on PROTON-641: Commit 1630787 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630787 ] PROTON-641: fixed link cleanup on connection/session abort; made free not close automatically > pn_connection_t leaked when links not closed > > > Key: PROTON-641 > URL: https://issues.apache.org/jira/browse/PROTON-641 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 >Reporter: Gordon Sim >Assignee: Rafael H. Schloming > Fix For: 0.8 > > Attachments: proton_leak.cpp > > > If the application doesn't call pn_link_close(), but calls > on_session_close(), pn_connection_close(), then pn_transport_free() and > pn_connection_free(), the pn_connection_t object appear to be leaked. > Will attach reproducer. See also QPID-5951. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-650) proton-dump should include a man page
[ https://issues.apache.org/jira/browse/PROTON-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166730#comment-14166730 ] ASF subversion and git services commented on PROTON-650: Commit 1630786 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630786 ] PROTON-650: use pn_compat utilities for cross platform builds > proton-dump should include a man page > - > > Key: PROTON-650 > URL: https://issues.apache.org/jira/browse/PROTON-650 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Darryl L. Pierce > Fix For: 0.8 > > > proton-dump provided without any documentation. > Neither man proton-dump nor proton-dump --help gives an info -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-650) proton-dump should include a man page
[ https://issues.apache.org/jira/browse/PROTON-650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166729#comment-14166729 ] ASF subversion and git services commented on PROTON-650: Commit 1630785 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630785 ] PROTON-650: Added a help option to proton-dump. If no arguments are provided on the command line then the help output is displayed. Also created a manpage from the help output using help2man. > proton-dump should include a man page > - > > Key: PROTON-650 > URL: https://issues.apache.org/jira/browse/PROTON-650 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Darryl L. Pierce > Fix For: 0.8 > > > proton-dump provided without any documentation. > Neither man proton-dump nor proton-dump --help gives an info -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-646) Perl message does not have the correct type when the body is a boolean with a FALSE value
[ https://issues.apache.org/jira/browse/PROTON-646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166728#comment-14166728 ] ASF subversion and git services commented on PROTON-646: Commit 1630784 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630784 ] PROTON-646: Fix when Perl sets a message body to be BOOL:False. Had to work around how checking whether a body value was defined would return false if it were defined but set to false. > Perl message does not have the correct type when the body is a boolean with a > FALSE value > - > > Key: PROTON-646 > URL: https://issues.apache.org/jira/browse/PROTON-646 > Project: Qpid Proton > Issue Type: Bug > Components: perl-binding >Reporter: Darryl L. Pierce >Assignee: Darryl L. Pierce >Priority: Minor > Fix For: 0.8 > > > In using the send.pl and recv.pl examples to test other changes, I found that > whenever a message's body is a boolean value the body type is undefined. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-582) Perl language bindings do not properly identify integers from strings when encoding
[
https://issues.apache.org/jira/browse/PROTON-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166727#comment-14166727
]
ASF subversion and git services commented on PROTON-582:
Commit 1630783 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630783 ]
PROTON-582: Perl Message can infer the type of the content provided.
The qpid::proton::Message->set_body() method can take either a single
argument (the body) or two arguments (the body and an explicit type).
Previous, if the second argument wasn't provided, the code assumed it
was a qpid::message::STRING type.
Now, the code will attempt to determine the type of the argument. It can
successfully infer a hash, array, int and string. It will default to a
string if it cannot otherwise determine the type.
> Perl language bindings do not properly identify integers from strings when
> encoding
> ---
>
> Key: PROTON-582
> URL: https://issues.apache.org/jira/browse/PROTON-582
> Project: Qpid Proton
> Issue Type: Bug
> Components: perl-binding
>Affects Versions: 0.7
>Reporter: Darryl L. Pierce
>Assignee: Darryl L. Pierce
> Fix For: 0.8
>
>
> Rafi found the code:
> sub isnum ($) {
> return 0 if $_[0] eq '';
> $_[0] ^ $_[0] ? 0 : 1
> }
> which can differentiate strings from integers. An additional piece can check
> for a . in a numeric value to differentiate integers from floating point
> values.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-611) [proton-c] transport buffer increased to peer's max frame size if initial output_size is not enough
[ https://issues.apache.org/jira/browse/PROTON-611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166725#comment-14166725 ] ASF subversion and git services commented on PROTON-611: Commit 1630778 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630778 ] PROTON-611: Don't allocate frame_max bytes immediately, grow by factors of 2 until you get to the max - else a large frame size can blow away 4Gb of memory! > [proton-c] transport buffer increased to peer's max frame size if initial > output_size is not enough > --- > > Key: PROTON-611 > URL: https://issues.apache.org/jira/browse/PROTON-611 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 >Reporter: Dominic Evans >Assignee: Andrew Stitcher > Fix For: 0.8 > > Attachments: 20_fix_bad_malloc_in_transport_produce.patch > > > transport_produce attempts to allocate a negatively sized buffer > As soon as remote_max_frame is set, the code in transport_produce attempts to > increase its buffer immediately up to that size when its initial size isn't > enough. This causes a huge malloc to occur if the remote max frame size is > large and also potentially overflows MAX_INT -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-647) Implement an Event.copy or clone method
[ https://issues.apache.org/jira/browse/PROTON-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14166726#comment-14166726 ] ASF subversion and git services commented on PROTON-647: Commit 1630780 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630780 ] PROTON-647: add method to copy an Event before use of the Collector pop() reclaims it to the pool Applied patch from Clebert Suconic > Implement an Event.copy or clone method > --- > > Key: PROTON-647 > URL: https://issues.apache.org/jira/browse/PROTON-647 > Project: Qpid Proton > Issue Type: Improvement >Reporter: clebert suconic >Assignee: Robbie Gemmell > Fix For: 0.8 > > > I'm facing an issue where I'm having to process the event after a pop. > I can't use the Event after pop because the Collector will place it on a pool. > The copy method would allow me to use it beyond pop: > I have achieved this with this commit here: > https://github.com/clebertsuconic/qpid-proton/commit/ed8367c1a699511ac9c5e23eb4f1a01ee4acff2c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
