[jira] [Created] (PROTON-796) support reducing credit [as a means to stop a link without drain]

2015-01-09 Thread Robbie Gemmell (JIRA)
Robbie Gemmell created PROTON-796:
-

 Summary: support reducing credit [as a means to stop a link 
without drain]
 Key: PROTON-796
 URL: https://issues.apache.org/jira/browse/PROTON-796
 Project: Qpid Proton
  Issue Type: Improvement
  Components: proton-c, proton-j
Reporter: Robbie Gemmell


It would be useful if there was full support for reducing crdit on a link, 
perhaps even to 0 as a means of stopping it.

Currently the way to stop a link [and determine that it has actually stopped] 
would be to issue a 'drain' flow request and then handle either a flow response 
or arriving messages resulting in credit reaching 0.

Using drain in this way effectively acts as request for any more messages to be 
sent by the peer using remaining credit if it already could have but had yet to 
do so. In contrast, the peer wishing to stop the link might prefer those 
messages actually not be sent, as it is indicating it doesnt want those 
messages currently. This could be possible by reducing credit on the link to 0, 
and requesting the updated state be echo'd as shown at [1], though this would 
require PROTON-795 be resolved.

It may currently be possible to fiddle with credit and drain handling (e.g 
'adding or 'drain'ing negative credit) to simulate this currently, however it 
isnt clear that the resulting behaviour would be desirable, given the impact of 
any message already in-flight from the peer before it receives the 
credit-reducing flow which might lead to situations like negative-credit.

[1] 
http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#doc-idp429232



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-793) error LNK2019: unresolved external symbol _pn_selector_size referenced in function _pn_reactor_work

2015-01-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271158#comment-14271158
 ] 

ASF subversion and git services commented on PROTON-793:


Commit 93f296fce091d06f97c9f97f677967fb73eb186e in qpid-proton's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=93f296f ]

PROTON-793: Add windows version of commit 7359e3e improvements to 
selectables/selector for new C reactor


 error LNK2019: unresolved external symbol _pn_selector_size referenced in 
 function _pn_reactor_work
 ---

 Key: PROTON-793
 URL: https://issues.apache.org/jira/browse/PROTON-793
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.9
 Environment: Windows, Visual Studio 8 2005
Reporter: daniel
  Labels: build

 function pn_selector_sized is declared in selector.h, used in reactor.c
 Could not find its definition in any file. 
 I guess this is a wrapper around struct pn_selector_t.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-794) [Windows] Visual Studio 2008 compile error

2015-01-09 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271520#comment-14271520
 ] 

ASF subversion and git services commented on PROTON-794:


Commit efa5eab5f4ffb504fca8da36f4d05f9732627f1b in qpid-proton's branch 
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=efa5eab ]

PROTON-794: Visual Studio 2008 fails to convert void* to enum.


 [Windows] Visual Studio 2008 compile error
 --

 Key: PROTON-794
 URL: https://issues.apache.org/jira/browse/PROTON-794
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.9
 Environment: Windows Server 2008 32 bit
 Visual Studio 2008
Reporter: Chuck Rolke

 {noformat}
 13-- Rebuild All started: Project: c-reactor-tests, Configuration: 
 RelWithDebInfo Win32 --
 13Deleting intermediate and output files for project 'c-reactor-tests', 
 configuration 'RelWithDebInfo|Win32'
 13Building Custom Rule 
 C:/Hudson/jobs/rh_qpid_proton-trunk/workspace/rh-qpid-proton/proton-c/src/tests/CMakeLists.txt
 13CMake does not need to re-run because 
 C:\Hudson\jobs\rh_qpid_proton-trunk\workspace\rh-qpid-proton\build\proton-c\src\tests\CMakeFiles\generate.stamp
  is up-to-date.
 13Compiling...
 13reactor.c
 13..\..\..\..\proton-c\src\tests\reactor.c(80) : error C2440: 'type cast' : 
 cannot convert from 'void *' to 'pn_event_type_t'
 13There is no context in which this conversion is possible
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (PROTON-797) Can't complete build in F21

2015-01-09 Thread Irina Boverman (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Irina Boverman updated PROTON-797:
--
Description: 
git clone https://git-wip-us.apache.org/repos/asf/qpid-proton.git proton-master

cmake -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo 
-DCMAKE_INSTALL_PREFIX=/usr -DSYSINSTALL_BINDINGS=ON  -DBUILD_RUBY=OFF ..

make all

make docs
...
/usr/bin/cmake -H/root/proton-master -B/root/proton-master/examples/engine/py 
--check-build-system CMakeFiles/Makefile.cmake 0
make -f CMakeFiles/Makefile2 docs
make[1]: Entering directory '/root/proton-master/examples/engine/py'
/usr/bin/cmake -H/root/proton-master -B/root/proton-master/examples/engine/py 
--check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start 
/root/proton-master/examples/engine/py/CMakeFiles 0
make -f CMakeFiles/Makefile2 proton-c/CMakeFiles/docs.dir/all
make[2]: Entering directory '/root/proton-master/examples/engine/py'
make -f proton-c/bindings/python/CMakeFiles/docs-py.dir/build.make 
proton-c/bindings/python/CMakeFiles/docs-py.dir/depend
make[3]: Entering directory '/root/proton-master/examples/engine/py'
cd /root/proton-master/examples/engine/py  /usr/bin/cmake -E cmake_depends 
Unix Makefiles /root/proton-master 
/root/proton-master/proton-c/bindings/python 
/root/proton-master/examples/engine/py 
/root/proton-master/examples/engine/py/proton-c/bindings/python 
/root/proton-master/examples/engine/py/proton-c/bindings/python/CMakeFiles/docs-py.dir/DependInfo.cmake
 --color=
Scanning dependencies of target docs-py
make[3]: Leaving directory '/root/proton-master/examples/engine/py'
make -f proton-c/bindings/python/CMakeFiles/docs-py.dir/build.make 
proton-c/bindings/python/CMakeFiles/docs-py.dir/build
make[3]: Entering directory '/root/proton-master/examples/engine/py'
cd /root/proton-master/examples/engine/py/proton-c/bindings/python  
/usr/bin/python /root/proton-master/proton-c/bindings/python/../../env.py -- 
PYTHONPATH=/root/proton-master/examples/engine/py/proton-c/bindings/python:/root/proton-master/proton-c/bindings/python
 /usr/bin/epydoc -v --no-private --html -o 
/root/proton-master/examples/engine/py/proton-c/bindings/python/html 
/root/proton-master/proton-c/bindings/python/proton/__init__.py 
proton/handlers.py proton/reactors.py proton/utils.py proton/wrapper.py
  Error: Could not find a file or object named proton/handlers.py
  Error: Could not find a file or object named proton/reactors.py
  Error: Could not find a file or object named proton/utils.py
  Error: Could not find a file or object named proton/wrapper.py
+
| File /root/proton-master/proton-c/bindings/python/proton/__init__.py, line 
3632, in proton.Url
|   Warning: Line 3635: Improper paragraph indentation.
|   
make[3]: Leaving directory '/root/proton-master/examples/engine/py'


  was:
git clone git://git.app.eng.bos.redhat.com/rh-qpid-proton.git proton-master

cmake -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo 
-DCMAKE_INSTALL_PREFIX=/usr -DSYSINSTALL_BINDINGS=ON  -DBUILD_RUBY=OFF ..

make all

make docs
...
/usr/bin/cmake -H/root/proton-master -B/root/proton-master/examples/engine/py 
--check-build-system CMakeFiles/Makefile.cmake 0
make -f CMakeFiles/Makefile2 docs
make[1]: Entering directory '/root/proton-master/examples/engine/py'
/usr/bin/cmake -H/root/proton-master -B/root/proton-master/examples/engine/py 
--check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start 
/root/proton-master/examples/engine/py/CMakeFiles 0
make -f CMakeFiles/Makefile2 proton-c/CMakeFiles/docs.dir/all
make[2]: Entering directory '/root/proton-master/examples/engine/py'
make -f proton-c/bindings/python/CMakeFiles/docs-py.dir/build.make 
proton-c/bindings/python/CMakeFiles/docs-py.dir/depend
make[3]: Entering directory '/root/proton-master/examples/engine/py'
cd /root/proton-master/examples/engine/py  /usr/bin/cmake -E cmake_depends 
Unix Makefiles /root/proton-master 
/root/proton-master/proton-c/bindings/python 
/root/proton-master/examples/engine/py 
/root/proton-master/examples/engine/py/proton-c/bindings/python 
/root/proton-master/examples/engine/py/proton-c/bindings/python/CMakeFiles/docs-py.dir/DependInfo.cmake
 --color=
Scanning dependencies of target docs-py
make[3]: Leaving directory '/root/proton-master/examples/engine/py'
make -f proton-c/bindings/python/CMakeFiles/docs-py.dir/build.make 
proton-c/bindings/python/CMakeFiles/docs-py.dir/build
make[3]: Entering directory '/root/proton-master/examples/engine/py'
cd /root/proton-master/examples/engine/py/proton-c/bindings/python  
/usr/bin/python /root/proton-master/proton-c/bindings/python/../../env.py -- 

[jira] [Created] (PROTON-794) [Windows] Visual Studio 2008 compile error

2015-01-09 Thread Chuck Rolke (JIRA)
Chuck Rolke created PROTON-794:
--

 Summary: [Windows] Visual Studio 2008 compile error
 Key: PROTON-794
 URL: https://issues.apache.org/jira/browse/PROTON-794
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.9
 Environment: Windows Server 2008 32 bit
Visual Studio 2008
Reporter: Chuck Rolke


{noformat}
13-- Rebuild All started: Project: c-reactor-tests, Configuration: 
RelWithDebInfo Win32 --
13Deleting intermediate and output files for project 'c-reactor-tests', 
configuration 'RelWithDebInfo|Win32'
13Building Custom Rule 
C:/Hudson/jobs/rh_qpid_proton-trunk/workspace/rh-qpid-proton/proton-c/src/tests/CMakeLists.txt
13CMake does not need to re-run because 
C:\Hudson\jobs\rh_qpid_proton-trunk\workspace\rh-qpid-proton\build\proton-c\src\tests\CMakeFiles\generate.stamp
 is up-to-date.
13Compiling...
13reactor.c
13..\..\..\..\proton-c\src\tests\reactor.c(80) : error C2440: 'type cast' : 
cannot convert from 'void *' to 'pn_event_type_t'
13There is no context in which this conversion is possible
{noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-794) [Windows] Visual Studio 2008 compile error

2015-01-09 Thread Cliff Jansen (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14271107#comment-14271107
 ] 

Cliff Jansen commented on PROTON-794:
-

This also fails on Linux if using BUILD_WITH_CXX in cmake.

The compiler can be mollified with a double cast, first to a size_t or ssize_t, 
then to the enum, but check with Andrew if that passes the C++ smell test.

Alternatively the enum could be stored and retrieved as a pointer offset.

 [Windows] Visual Studio 2008 compile error
 --

 Key: PROTON-794
 URL: https://issues.apache.org/jira/browse/PROTON-794
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.9
 Environment: Windows Server 2008 32 bit
 Visual Studio 2008
Reporter: Chuck Rolke

 {noformat}
 13-- Rebuild All started: Project: c-reactor-tests, Configuration: 
 RelWithDebInfo Win32 --
 13Deleting intermediate and output files for project 'c-reactor-tests', 
 configuration 'RelWithDebInfo|Win32'
 13Building Custom Rule 
 C:/Hudson/jobs/rh_qpid_proton-trunk/workspace/rh-qpid-proton/proton-c/src/tests/CMakeLists.txt
 13CMake does not need to re-run because 
 C:\Hudson\jobs\rh_qpid_proton-trunk\workspace\rh-qpid-proton\build\proton-c\src\tests\CMakeFiles\generate.stamp
  is up-to-date.
 13Compiling...
 13reactor.c
 13..\..\..\..\proton-c\src\tests\reactor.c(80) : error C2440: 'type cast' : 
 cannot convert from 'void *' to 'pn_event_type_t'
 13There is no context in which this conversion is possible
 {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)