[jira] [Commented] (PROTON-964) Proton-J extensible event types

2015-08-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659979#comment-14659979
 ] 

ASF GitHub Bot commented on PROTON-964:
---

Github user boo commented on the pull request:

https://github.com/apache/qpid-proton/pull/48#issuecomment-128358421
  
@gemmellr I think I have managed to eliminate almost all casts by 
delegating half of the dispatch to the handler -- the handler already knows 
it's type, no need for generics even.


 Proton-J extensible event types
 ---

 Key: PROTON-964
 URL: https://issues.apache.org/jira/browse/PROTON-964
 Project: Qpid Proton
  Issue Type: Improvement
  Components: proton-j
Affects Versions: 0.10
Reporter: Bozo Dragojevic
Assignee: Bozo Dragojevic
 Fix For: 0.11


 Event.Type is an enum which makes it impossible to extend.
 Introduce a separate interface EventType and make Event.Type implement it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] qpid-proton pull request: PROTON-964: Proton-J extensible event ty...

2015-08-06 Thread bozzzzo
Github user boo commented on the pull request:

https://github.com/apache/qpid-proton/pull/48#issuecomment-128358421
  
@gemmellr I think I have managed to eliminate almost all casts by 
delegating half of the dispatch to the handler -- the handler already knows 
it's type, no need for generics even.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (PROTON-975) crash occurs if buffer containing outcome and first encrypted frame is received

2015-08-06 Thread Ken Giusti (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14659925#comment-14659925
 ] 

Ken Giusti commented on PROTON-975:
---

Ah, thanks robbie I missed that.


 crash occurs if buffer containing outcome and first encrypted frame is 
 received
 ---

 Key: PROTON-975
 URL: https://issues.apache.org/jira/browse/PROTON-975
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.10
Reporter: Ken Giusti
Assignee: Andrew Stitcher
Priority: Blocker
 Fix For: 0.10

 Attachments: send.py


 I'm hitting an occasional client crash when using an DIGEST-MD5 SASL mech to 
 talk to the qpidd broker.
 I've built the broker using the 0.10rc1 as the proton library.
 I'm using a pyngus based client.  I will upload this reproducer.
 Best I can tell, the client pushes a single buffer to the transport that 
 contains both the SASL outcome frame from qpidd and the first encrypted 
 frame.  SASL does not handle this case correctly and attempts to parse the 
 encrypted frame as cleartext.
 I will open another bug against the frame decode to prevent parsing invalid 
 frames.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (PROTON-977) handler appears to get ignored

2015-08-06 Thread Gordon Sim (JIRA)
Gordon Sim created PROTON-977:
-

 Summary: handler appears to get ignored
 Key: PROTON-977
 URL: https://issues.apache.org/jira/browse/PROTON-977
 Project: Qpid Proton
  Issue Type: Bug
  Components: python-binding
Affects Versions: 0.10
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.11


If a handler defines methods such that it is evaluated to false in a boolean 
context, then tests inside the Container and/or MessagingHandler whose aim is 
to test whether a handler is set, will fail even though there is a handler.

E.g. if the handler has a __len__() method that returns 0 when 
Container.create_receiver is called, the handler will not be set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (PROTON-977) handler appears to get ignored

2015-08-06 Thread Gordon Sim (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gordon Sim resolved PROTON-977.
---
Resolution: Fixed

 handler appears to get ignored
 --

 Key: PROTON-977
 URL: https://issues.apache.org/jira/browse/PROTON-977
 Project: Qpid Proton
  Issue Type: Bug
  Components: python-binding
Affects Versions: 0.10
Reporter: Gordon Sim
Assignee: Gordon Sim
 Fix For: 0.11


 If a handler defines methods such that it is evaluated to false in a boolean 
 context, then tests inside the Container and/or MessagingHandler whose aim is 
 to test whether a handler is set, will fail even though there is a handler.
 E.g. if the handler has a __len__() method that returns 0 when 
 Container.create_receiver is called, the handler will not be set.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)