[jira] [Commented] (PROTON-1077) receiver link and transport view of credit can become disjoint when sending link sends flow frames
[ https://issues.apache.org/jira/browse/PROTON-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15057682#comment-15057682 ] Keith Wall commented on PROTON-1077: Robbie, I repeated the test described by QPID-6863 against the Java Broker with the above Proton change applied. I was no longer able to reproduce the issue. I ran for fifteen minutes with no recurrence. We'll be looking at the Java Broker issue (QPID-6947) separately. > receiver link and transport view of credit can become disjoint when sending > link sends flow frames > -- > > Key: PROTON-1077 > URL: https://issues.apache.org/jira/browse/PROTON-1077 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.11 >Reporter: Robbie Gemmell > > If a recieving link receives flow frames from the sending peer updating > advancing the delivery count [and setting credit to 0], then recieves flow > frames from the sender updating credit but not advancing the delivery count, > then receives messages, the Link and TransportLink views of the credit can > become disjoint, leading applications to think they have a different amount > of credit than they actually do, and leading to a different amount of new > credit being flowed to the sender than expected, even none. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-211) Non-maven users should have ability to run all system tests
[ https://issues.apache.org/jira/browse/PROTON-211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-211: -- Assignee: (was: Keith Wall) Non-maven users should have ability to run all system tests --- Key: PROTON-211 URL: https://issues.apache.org/jira/browse/PROTON-211 Project: Qpid Proton Issue Type: New Feature Components: proton-c, proton-j Reporter: Keith Wall Non-maven users (those building proton-c, the bindings etc using cmake, make etc) should have a simple method to run all the system tests including those written in Java. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (PROTON-265) Change Message#decode to signal inability to decode entire buffer via exception rather than return value
[ https://issues.apache.org/jira/browse/PROTON-265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-265: -- Assignee: (was: Keith Wall) Change Message#decode to signal inability to decode entire buffer via exception rather than return value Key: PROTON-265 URL: https://issues.apache.org/jira/browse/PROTON-265 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Keith Wall Change Message#decode signature to throw an exception in the case where the decoder fails to decode all the bytes in the input buffer, rather than returning the number of bytes actually decoded. This will make the Java implementation more closely follow the Proton-C. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PROTON-561) Using the java broker, messenger apparently doesn't propagate error back from broker to messenger
[
https://issues.apache.org/jira/browse/PROTON-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066894#comment-14066894
]
Keith Wall commented on PROTON-561:
---
Should be fixed in Java Broker 0.30.
Using the java broker, messenger apparently doesn't propagate error back from
broker to messenger
-
Key: PROTON-561
URL: https://issues.apache.org/jira/browse/PROTON-561
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.6, 0.7
Reporter: Justin Ross
(The java broker logging for AMQP 1.0 is minimal; I'll mention that in
another jira.)
The test program below simply hangs. It didn't seem to want to time out,
either.
{noformat}
from proton import Message, Messenger
msgr = Messenger()
msgr.start()
try:
msg = Message()
msg.address = amqp://0.0.0.0:5672/test
msg.body = test
msgr.put(msg)
msgr.send()
finally:
msgr.stop()
{noformat}
By contrast, the same operation rendered in the qpid_messaging API produces
the expected error:
{noformat}
import sys
# You will need to build the swig python binding and point at it
sys.path.append(/home/jross/code/qpid/cpp/build/bindings/qpid/python)
from qpid_messaging import Connection
conn = Connection(0.0.0.0:5672, protocol=amqp1.0)
conn.open()
try:
session = conn.session()
sender = session.sender(test)
message = Message(test)
sender.send(message)
finally:
conn.close()
{noformat}
Error:
{noformat}
Traceback (most recent call last):
File /home/jross/test2.py, line 13, in module
sender = session.sender(test)
File
/home/jross/code/qpid/cpp/build/bindings/qpid/python/qpid_messaging.py,
line 560, in sender
s = self._sender(target)
File
/home/jross/code/qpid/cpp/build/bindings/qpid/python/qpid_messaging.py,
line 532, in _sender
def _sender(self, *args): return _qpid_messaging.Session__sender(self,
*args)
_qpid_messaging.NotFound: No such target : test
{noformat}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Reopened] (PROTON-200) [Proton-c] Credit distribution by messenger is not balanced across all links
[ https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reopened PROTON-200: --- Hi Ken, That commit (rev 1547534) uses JDK 7 specific features (specifically java.net.StandardSocketOptions) so the build is now breaking. Please see https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/495/console Can we enable tcp no delay on the socket instead? regards, Keith. [Proton-c] Credit distribution by messenger is not balanced across all links Key: PROTON-200 URL: https://issues.apache.org/jira/browse/PROTON-200 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.3 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 0.6 Attachments: proton-200.patch, upstream-credit.patch The method used to distribute credit to receiving links may lead to starvation when the number of receiving links is the available credit. The distribution algorithm always starts with the same link - see messenger.c::pn_messenger_flow() -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Comment Edited] (PROTON-200) [Proton-c] Credit distribution by messenger is not balanced across all links
[ https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13838760#comment-13838760 ] Keith Wall edited comment on PROTON-200 at 12/4/13 9:23 AM: Hi Ken, That commit (rev 1547534) uses JDK 7 specific features (specifically java.net.StandardSocketOptions) so the build is now breaking. Please see https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/495/console Can we enable tcp no delay on the socket instead? regards, Keith. btw. to which components does this Jira apply? The Jira title starts [proton-c]..., but the assigned component is proton-j. was (Author: k-wall): Hi Ken, That commit (rev 1547534) uses JDK 7 specific features (specifically java.net.StandardSocketOptions) so the build is now breaking. Please see https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/495/console Can we enable tcp no delay on the socket instead? regards, Keith. [Proton-c] Credit distribution by messenger is not balanced across all links Key: PROTON-200 URL: https://issues.apache.org/jira/browse/PROTON-200 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.3 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 0.6 Attachments: proton-200.patch, upstream-credit.patch The method used to distribute credit to receiving links may lead to starvation when the number of receiving links is the available credit. The distribution algorithm always starts with the same link - see messenger.c::pn_messenger_flow() -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (PROTON-200) [Proton-c] Credit distribution by messenger is not balanced across all links
[ https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13796547#comment-13796547 ] Keith Wall commented on PROTON-200: --- Yesterday's commit (https://svn.apache.org/r1532452) broke an internal Jenkins build as the change makes use of a Python 2.5 language feature (try/except/finally in the same block - support for which was introduced by Python 2.5). We'd understood that we wanted to remain Python 2.4 compatible. We are using python distribution python-2.4.3-24.el5.x86_64 and the box is running Red Hat Enterprise Linux Server release 5.3 (Tikanga). Traceback (most recent call last): File ./tests/python/proton-test, line 596, in ? m = __import__(name, None, None, [dummy]) File /home/.jenkins/jobs/Trunk-Proton-C/workspace/proton/tests/python/proton_tests/__init__.py, line 23, in ? import proton_tests.messenger File /home/.jenkins/jobs/Trunk-Proton-C/workspace/proton/tests/python/proton_tests/messenger.py, line 106 finally: [Proton-c] Credit distribution by messenger is not balanced across all links Key: PROTON-200 URL: https://issues.apache.org/jira/browse/PROTON-200 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.3 Reporter: Ken Giusti Assignee: Ken Giusti Attachments: proton-200.patch, upstream-credit.patch The method used to distribute credit to receiving links may lead to starvation when the number of receiving links is the available credit. The distribution algorithm always starts with the same link - see messenger.c::pn_messenger_flow() -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Updated] (PROTON-307) Remove redundant input and output methods from Sasl interface
[ https://issues.apache.org/jira/browse/PROTON-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-307: -- Fix Version/s: 0.5 Remove redundant input and output methods from Sasl interface - Key: PROTON-307 URL: https://issues.apache.org/jira/browse/PROTON-307 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Philip Harvey Assignee: Philip Harvey Fix For: 0.5 The Sasl interface exposes input and output methods which duplicate those offered by Transport. Furthermore, use of these methods may be harmful because, for example, if a Transport has been set up to use both SSL and SASL, directly calling Sasl.input undermines the layering of SSL/SASL/AMQP transports that Transport is meant to oversee. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (PROTON-307) Remove redundant input and output methods from Sasl interface
[ https://issues.apache.org/jira/browse/PROTON-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall closed PROTON-307. - Remove redundant input and output methods from Sasl interface - Key: PROTON-307 URL: https://issues.apache.org/jira/browse/PROTON-307 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Philip Harvey Assignee: Philip Harvey The Sasl interface exposes input and output methods which duplicate those offered by Transport. Furthermore, use of these methods may be harmful because, for example, if a Transport has been set up to use both SSL and SASL, directly calling Sasl.input undermines the layering of SSL/SASL/AMQP transports that Transport is meant to oversee. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (PROTON-307) Remove redundant input and output methods from Sasl interface
[ https://issues.apache.org/jira/browse/PROTON-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall closed PROTON-307. - Remove redundant input and output methods from Sasl interface - Key: PROTON-307 URL: https://issues.apache.org/jira/browse/PROTON-307 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Philip Harvey Assignee: Philip Harvey Fix For: 0.5 The Sasl interface exposes input and output methods which duplicate those offered by Transport. Furthermore, use of these methods may be harmful because, for example, if a Transport has been set up to use both SSL and SASL, directly calling Sasl.input undermines the layering of SSL/SASL/AMQP transports that Transport is meant to oversee. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-307) Remove redundant input and output methods from Sasl interface
[ https://issues.apache.org/jira/browse/PROTON-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved PROTON-307. --- Resolution: Fixed Remove redundant input and output methods from Sasl interface - Key: PROTON-307 URL: https://issues.apache.org/jira/browse/PROTON-307 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Philip Harvey Assignee: Philip Harvey Fix For: 0.5 The Sasl interface exposes input and output methods which duplicate those offered by Transport. Furthermore, use of these methods may be harmful because, for example, if a Transport has been set up to use both SSL and SASL, directly calling Sasl.input undermines the layering of SSL/SASL/AMQP transports that Transport is meant to oversee. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (PROTON-307) Remove redundant input and output methods from Sasl interface
[ https://issues.apache.org/jira/browse/PROTON-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reopened PROTON-307: --- Remove redundant input and output methods from Sasl interface - Key: PROTON-307 URL: https://issues.apache.org/jira/browse/PROTON-307 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Philip Harvey Assignee: Philip Harvey The Sasl interface exposes input and output methods which duplicate those offered by Transport. Furthermore, use of these methods may be harmful because, for example, if a Transport has been set up to use both SSL and SASL, directly calling Sasl.input undermines the layering of SSL/SASL/AMQP transports that Transport is meant to oversee. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-299) proton_tests.ssl.SslTest.test_server_hostname_authentication occasionally fails against proton-c
[
https://issues.apache.org/jira/browse/PROTON-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13640305#comment-13640305
]
Keith Wall commented on PROTON-299:
---
Thanks Ken, I repeated my test (described above) and confirm that the issue I
observed has gone.
proton_tests.ssl.SslTest.test_server_hostname_authentication occasionally
fails against proton-c
Key: PROTON-299
URL: https://issues.apache.org/jira/browse/PROTON-299
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.5
Environment: Red Hat Enterprise Linux Server release 5.3 (Tikanga)
2.6.18-128.7.1.el5
openssl-0.9.8e-22.el5_8.4.x86_64
openssl-0.9.8e-22.el5_8.4.i686
Python 2.7.3
Intel(R) Xeon(R) CPU E5620 @ 2.40GHz
Reporter: Keith Wall
Assignee: Ken Giusti
I've noticed that SslTest.test_server_hostname_authentication occasionally
fails. Running the test in isolation in a loop I see the test fail about 1
time in 15 with command:
{noformat}
while proton-test
proton_tests.ssl.SslTest.test_server_hostname_authentication ; do echo; done
{noformat}
fails in the following manner:
{noformat}
proton_tests.ssl.SslTest.test_server_hostname_authentication
Error during test: Traceback (most recent call last):
File tests/python/proton-test, line 340, in run
phase()
File /home/keith/src/proton/tests/python/proton_tests/ssl.py, line 636,
in test_server_hostname_authentication
self._do_handshake( client, server )
File /home/keith/src/proton/tests/python/proton_tests/ssl.py, line 99,
in _do_handshake
self._pump(client, server)
File /home/keith/src/proton/tests/python/proton_tests/ssl.py, line 77,
in _pump
number_client_consumed = ssl_client.transport.input(out_server)
File /home/keith/src/proton/proton-c/bindings/python/proton.py, line
2338, in input
return self._check(n)
File /home/keith/src/proton/proton-c/bindings/python/proton.py, line
2312, in _check
raise exc([%s]: %s % (err,
pn_error_text(pn_transport_error(self._trans
TransportException: [-2]: SSL Failure: error:14090086:SSL
routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
Totals: 1 tests, 0 passed, 0 skipped, 0 ignored, 1 failed
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-299) proton_tests.ssl.SslTest.test_server_hostname_authentication occasionally fails against proton-c
Keith Wall created PROTON-299:
-
Summary:
proton_tests.ssl.SslTest.test_server_hostname_authentication occasionally fails
against proton-c
Key: PROTON-299
URL: https://issues.apache.org/jira/browse/PROTON-299
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.5
Environment: Red Hat Enterprise Linux Server release 5.3 (Tikanga)
2.6.18-128.7.1.el5
openssl-0.9.8e-22.el5_8.4.x86_64
openssl-0.9.8e-22.el5_8.4.i686
Python 2.7.3
Intel(R) Xeon(R) CPU E5620 @ 2.40GHz
Reporter: Keith Wall
I've noticed that SslTest.test_server_hostname_authentication occasionally
fails. Running the test in isolation in a loop I see the test fail about 1
time in 15 with command:
{noformat}
while proton-test proton_tests.ssl.SslTest.test_server_hostname_authentication
; do echo; done
{noformat}
fails in the following manner:
{noformat}
proton_tests.ssl.SslTest.test_server_hostname_authentication
Error during test: Traceback (most recent call last):
File tests/python/proton-test, line 340, in run
phase()
File /home/keith/src/proton/tests/python/proton_tests/ssl.py, line 636,
in test_server_hostname_authentication
self._do_handshake( client, server )
File /home/keith/src/proton/tests/python/proton_tests/ssl.py, line 99, in
_do_handshake
self._pump(client, server)
File /home/keith/src/proton/tests/python/proton_tests/ssl.py, line 77, in
_pump
number_client_consumed = ssl_client.transport.input(out_server)
File /home/keith/src/proton/proton-c/bindings/python/proton.py, line
2338, in input
return self._check(n)
File /home/keith/src/proton/proton-c/bindings/python/proton.py, line
2312, in _check
raise exc([%s]: %s % (err,
pn_error_text(pn_transport_error(self._trans
TransportException: [-2]: SSL Failure: error:14090086:SSL
routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
Totals: 1 tests, 0 passed, 0 skipped, 0 ignored, 1 failed
{noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-285) MessengerTest#testSendBogus fails against proton-c
Keith Wall created PROTON-285: - Summary: MessengerTest#testSendBogus fails against proton-c Key: PROTON-285 URL: https://issues.apache.org/jira/browse/PROTON-285 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Keith Wall Assignee: Rafael H. Schloming As highlighted in the following mailing list post: http://qpid.2158936.n2.nabble.com/Continually-failing-MessengerTests-WAS-NPE-from-MessengerTests-since-rev-1460174-tt7590662.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-285) MessengerTest#testSendBogus fails against proton-c
[ https://issues.apache.org/jira/browse/PROTON-285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622044#comment-13622044 ] Keith Wall commented on PROTON-285: --- Temporarily removed failing test (rev. 1464442) to stop the noise. MessengerTest#testSendBogus fails against proton-c -- Key: PROTON-285 URL: https://issues.apache.org/jira/browse/PROTON-285 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Keith Wall Assignee: Rafael H. Schloming As highlighted in the following mailing list post: http://qpid.2158936.n2.nabble.com/Continually-failing-MessengerTests-WAS-NPE-from-MessengerTests-since-rev-1460174-tt7590662.html -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-276) All ssl tests fail against proton-j on Windows
[ https://issues.apache.org/jira/browse/PROTON-276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned PROTON-276: - Assignee: Philip Harvey (was: Keith Wall) Hi Phil, Patch applied... Tests now proton-j tests now passing on windows too. Would you mind reviewing rev 1460177? All ssl tests fail against proton-j on Windows -- Key: PROTON-276 URL: https://issues.apache.org/jira/browse/PROTON-276 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Reporter: Keith Wall Assignee: Philip Harvey Running mvn test on Windows I see all the (Python) ssl tests fail. The error message is: java.lang.RuntimeException: Unable to read PEM object from file __pyclasspath__/proton_tests\ssl_db/ca-certificate.pem -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-276) All ssl tests fail against proton-j on Windows
Keith Wall created PROTON-276: - Summary: All ssl tests fail against proton-j on Windows Key: PROTON-276 URL: https://issues.apache.org/jira/browse/PROTON-276 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Reporter: Keith Wall Assignee: Keith Wall Running mvn test on Windows I see all the (Python) ssl tests fail. The error message is: java.lang.RuntimeException: Unable to read PEM object from file __pyclasspath__/proton_tests\ssl_db/ca-certificate.pem -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (PROTON-276) All ssl tests fail against proton-j on Windows
[ https://issues.apache.org/jira/browse/PROTON-276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13610983#comment-13610983 ] Keith Wall edited comment on PROTON-276 at 3/22/13 5:48 PM: I think the problem is with our test wrapper, JythonTest, and the arrangement of resources on the classpath (governed by the test/pom.xml). Together they are having the affect of making the python scripts and test resources (e.g. the test certs etc) available to python tests by two different routes. * once by way of the Java classpath (tests/target/classes/ is on the classpath), * and once again by way of the Python sys.path established in JythonTest#test() It seems when the tests are run on Linux, the ssl.py finds the resources by way of the Python sys.path and this allows SslTest#_testpath to determine an absolute path to the certificate. However, when the tests are run on Windows the test finds the resources by way of the Java classpath. This means SslTest_testpath returns a filename beginning with the string __pyclasspath__ which then goes on to fail in BouncyCastle's PEMReader. was (Author: k-wall): I think the problem is with our test wrapper, JythonTest, and the arrangement of resources on the classpath (governed by the test/pom.xml). Together they are having the affect of making the python scripts and test resources (e.g. the test certs etc) available to python tests by two different routes. * once by way of the Java classpath (tests/target/classes/ is on the classpath), * and once again by way of the Python sys.path established in JythonTest#test() It seems when the tests are run on Linux, the ssl.py is finds the resources by way of the Python sys.path and this allows SslTest#_testpath to determine an absolute path to the certificate. However, when the tests are run on Windows the test finds the resources by way of the Java classpath. This means SslTest_testpath returns a filename beginning with the string __pyclasspath__ which then goes on to fail in BouncyCastle's PEMReader. All ssl tests fail against proton-j on Windows -- Key: PROTON-276 URL: https://issues.apache.org/jira/browse/PROTON-276 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Reporter: Keith Wall Assignee: Keith Wall Running mvn test on Windows I see all the (Python) ssl tests fail. The error message is: java.lang.RuntimeException: Unable to read PEM object from file __pyclasspath__/proton_tests\ssl_db/ca-certificate.pem -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-254) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010
[ https://issues.apache.org/jira/browse/PROTON-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-254: -- Attachment: (was: 0001-PROTON-254-Resolve-compliation-issues-of-Swig-genera.patch) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010 -- Key: PROTON-254 URL: https://issues.apache.org/jira/browse/PROTON-254 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Environment: Windows 7 Visual Studio 2010 Reporter: Keith Wall Assignee: Cliff Jansen Attachments: make-proton-jni-cxx-errors.txt Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(java.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithmetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-254) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010
[ https://issues.apache.org/jira/browse/PROTON-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13607027#comment-13607027 ] Keith Wall commented on PROTON-254: --- 1) Committed patch to resolve the compilation problems that occur when compiling the the swig generated java binding code with a C++ compiler. Tested with g++ on: Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3, and i686-apple-darwin11-llvm-g++-4.2 (GCC) 4.2.1 (Based on Apple Inc. build 5658) (LLVM build 2336.11.00) 2) Also attaching a further patch to this JIRA for comment. This candidate resolves the Swig 'Nested union not currently supported' issue discussed above simply by moving the union type to top level. This allows Swig to process the type when running in C++ mode and generate the corresponding java class pn_atom_t_u. With this patch applies the mvn clean test -Pproton-jni passes clean on both ubuntu and mac os x. Not tested on Windows yet. Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010 -- Key: PROTON-254 URL: https://issues.apache.org/jira/browse/PROTON-254 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Environment: Windows 7 Visual Studio 2010 Reporter: Keith Wall Assignee: Cliff Jansen Attachments: make-proton-jni-cxx-errors.txt Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(java.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithmetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-254) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010
[ https://issues.apache.org/jira/browse/PROTON-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-254: -- Attachment: 0001-PROTON-254-Resolve-compliation-issues-of-Swig-genera.patch Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010 -- Key: PROTON-254 URL: https://issues.apache.org/jira/browse/PROTON-254 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Environment: Windows 7 Visual Studio 2010 Reporter: Keith Wall Assignee: Cliff Jansen Attachments: 0001-PROTON-254-Resolve-compliation-issues-of-Swig-genera.patch, make-proton-jni-cxx-errors.txt Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(java.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithmetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-254) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010
[ https://issues.apache.org/jira/browse/PROTON-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604803#comment-13604803 ] Keith Wall commented on PROTON-254: --- Attached patch to resolve issues preventing compilation of generated c++ code. Issue regarding nested union described above remains. Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010 -- Key: PROTON-254 URL: https://issues.apache.org/jira/browse/PROTON-254 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Environment: Windows 7 Visual Studio 2010 Reporter: Keith Wall Assignee: Cliff Jansen Attachments: 0001-PROTON-254-Resolve-compliation-issues-of-Swig-genera.patch, make-proton-jni-cxx-errors.txt Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(java.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithmetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-261) pn_delivery_local_state and pn_delivery_remote_state can return a zero value (outside that defined by the pn_disposition_t enum)
[
https://issues.apache.org/jira/browse/PROTON-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated PROTON-261:
--
Description:
In proton-c, pn_delivery_local_state and pn_delivery_remote_state are defined
as returning an pn_disposition_t:
PN_EXTERN pn_disposition_t pn_delivery_local_state(pn_delivery_t *delivery);
PN_EXTERN pn_disposition_t pn_delivery_remote_state(pn_delivery_t *delivery);
with pn_disposition_t defined as:
typedef enum pn_disposition_t {
PN_RECEIVED=1,
PN_ACCEPTED=2,
PN_REJECTED=3,
PN_RELEASED=4,
PN_MODIFIED=5
} pn_disposition_t;
However, there are circumstances when the proton-c implementation returns a
value outside this enumeration - value 0 - coming for the struct initialisation
in pn_delivery(). What does this value mean and how is an application supposed
to react to this value? Are there an implicit restrictions regarding when an
application may call pn_delivery_local_state/pn_delivery_remote_state?
btw. This question arises from work on PROTON-257. Proton-jni (Swig generated
code - so called Proper enums - see
http://www.swig.org/Doc2.0/Java.html#Java_proper_enums_classes) is failing to
decode the enum when testing the state of a newly created Delivery.
test(org.apache.qpid.proton.systemtests.ProtonEngineExampleTest) Time elapsed:
0.109 sec ERROR!
java.lang.IllegalArgumentException: No enum class
org.apache.qpid.proton.jni.pn_disposition_t with value 0
at
org.apache.qpid.proton.jni.pn_disposition_t.swigToEnum(pn_disposition_t.java:32)
at
org.apache.qpid.proton.jni.Proton.pn_delivery_local_state(Proton.java:624)
at
org.apache.qpid.proton.engine.jni.JNIDelivery.getLocalState(JNIDelivery.java:100)
at
org.apache.qpid.proton.systemtests.ProtonEngineExampleTest.test(ProtonEngineExampleTest.java:190)
was:
In proton-c, pn_delivery_local_state and pn_delivery_remote_state are defined
as returning an pn_disposition_t:
PN_EXTERN pn_disposition_t pn_delivery_local_state(pn_delivery_t *delivery);
PN_EXTERN pn_disposition_t pn_delivery_remote_state(pn_delivery_t *delivery);
with pn_disposition_t defined as:
typedef enum pn_disposition_t {
PN_RECEIVED=1,
PN_ACCEPTED=2,
PN_REJECTED=3,
PN_RELEASED=4,
PN_MODIFIED=5
} pn_disposition_t;
However, there are circumstances when the proton-c implementation returns a
value outside this enumeration - value 0 - coming for the struct initialisation
in pn_delivery(). What does this value mean and how is an application supposed
to react to this value? Are there an implicit restrictions regarding when an
application may call pn_delivery_local_state/pn_delivery_remote_state?
btw. This question arises from work on PROTON-257. Proton-jni (Swig generated
code) is failing to decode the enum when testing the state of a newly created
Delivery.
test(org.apache.qpid.proton.systemtests.ProtonEngineExampleTest) Time elapsed:
0.109 sec ERROR!
java.lang.IllegalArgumentException: No enum class
org.apache.qpid.proton.jni.pn_disposition_t with value 0
at
org.apache.qpid.proton.jni.pn_disposition_t.swigToEnum(pn_disposition_t.java:32)
at
org.apache.qpid.proton.jni.Proton.pn_delivery_local_state(Proton.java:624)
at
org.apache.qpid.proton.engine.jni.JNIDelivery.getLocalState(JNIDelivery.java:100)
at
org.apache.qpid.proton.systemtests.ProtonEngineExampleTest.test(ProtonEngineExampleTest.java:190)
pn_delivery_local_state and pn_delivery_remote_state can return a zero value
(outside that defined by the pn_disposition_t enum)
Key: PROTON-261
URL: https://issues.apache.org/jira/browse/PROTON-261
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.5
Reporter: Keith Wall
In proton-c, pn_delivery_local_state and pn_delivery_remote_state are defined
as returning an pn_disposition_t:
PN_EXTERN pn_disposition_t pn_delivery_local_state(pn_delivery_t *delivery);
PN_EXTERN pn_disposition_t pn_delivery_remote_state(pn_delivery_t *delivery);
with pn_disposition_t defined as:
typedef enum pn_disposition_t {
PN_RECEIVED=1,
PN_ACCEPTED=2,
PN_REJECTED=3,
PN_RELEASED=4,
PN_MODIFIED=5
} pn_disposition_t;
However, there are circumstances when the proton-c implementation returns a
value outside this enumeration - value 0 - coming for the struct
initialisation in pn_delivery(). What does this value mean and how is an
application supposed to react to this value? Are there an implicit
restrictions regarding when an application may call
pn_delivery_local_state/pn_delivery_remote_state?
btw. This question arises from work on PROTON-257. Proton-jni (Swig
generated code - so called Proper enums - see
[jira] [Commented] (PROTON-261) pn_delivery_local_state and pn_delivery_remote_state can return a zero value (outside that defined by the pn_disposition_t enum)
[
https://issues.apache.org/jira/browse/PROTON-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595724#comment-13595724
]
Keith Wall commented on PROTON-261:
---
I like the idea to extend the pn_disposition_t enum to include a constant to
explicitly indicate the pending state.Like you say, if the constant had a zero
value, then the application would be free to use a if
(pn_delivery_remote_state(...)) idiom. The pn_delivery_update would need to
be changed to disallow the use of the new pending state.
pn_delivery_local_state and pn_delivery_remote_state can return a zero value
(outside that defined by the pn_disposition_t enum)
Key: PROTON-261
URL: https://issues.apache.org/jira/browse/PROTON-261
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.5
Reporter: Keith Wall
In proton-c, pn_delivery_local_state and pn_delivery_remote_state are defined
as returning an pn_disposition_t:
PN_EXTERN pn_disposition_t pn_delivery_local_state(pn_delivery_t *delivery);
PN_EXTERN pn_disposition_t pn_delivery_remote_state(pn_delivery_t *delivery);
with pn_disposition_t defined as:
typedef enum pn_disposition_t {
PN_RECEIVED=1,
PN_ACCEPTED=2,
PN_REJECTED=3,
PN_RELEASED=4,
PN_MODIFIED=5
} pn_disposition_t;
However, there are circumstances when the proton-c implementation returns a
value outside this enumeration - value 0 - coming for the struct
initialisation in pn_delivery(). What does this value mean and how is an
application supposed to react to this value? Are there an implicit
restrictions regarding when an application may call
pn_delivery_local_state/pn_delivery_remote_state?
btw. This question arises from work on PROTON-257. Proton-jni (Swig
generated code - so called Proper enums - see
http://www.swig.org/Doc2.0/Java.html#Java_proper_enums_classes) is failing to
decode the enum when testing the state of a newly created Delivery.
test(org.apache.qpid.proton.systemtests.ProtonEngineExampleTest) Time
elapsed: 0.109 sec ERROR!
java.lang.IllegalArgumentException: No enum class
org.apache.qpid.proton.jni.pn_disposition_t with value 0
at
org.apache.qpid.proton.jni.pn_disposition_t.swigToEnum(pn_disposition_t.java:32)
at
org.apache.qpid.proton.jni.Proton.pn_delivery_local_state(Proton.java:624)
at
org.apache.qpid.proton.engine.jni.JNIDelivery.getLocalState(JNIDelivery.java:100)
at
org.apache.qpid.proton.systemtests.ProtonEngineExampleTest.test(ProtonEngineExampleTest.java:190)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-264) Proton-J and Proton-C transports make inconsistent use of return values within methods input and output
[ https://issues.apache.org/jira/browse/PROTON-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved PROTON-264. --- Resolution: Fixed Change committed at rev. 1453849 Proton-J and Proton-C transports make inconsistent use of return values within methods input and output --- Key: PROTON-264 URL: https://issues.apache.org/jira/browse/PROTON-264 Project: Qpid Proton Issue Type: Bug Components: proton-c, proton-j Affects Versions: 0.4 Reporter: Keith Wall Assignee: Keith Wall Priority: Minor Fix For: 0.5 This defect refers to the transport interface already in the process of being deprecated by PROTON-225. The scope of PROTON-225 has been increased (=noted in Jira) to ensure that this defect is not carried forward to the new interface and we end up with consistent behaviour. Currently, in Proton-C pn_transport_output() returns PN_EOS (=-1) to signal that the Transport will produce no further output, and pn_transport_input() returns PN_EOS to signal that the Transport will accept no further input. However, Proton-J, output always returns the number bytes output (even if zero), and input returns the number of bytes accepted (again even if zero). This difference presents a problem to tests utilising the Proton-JNI binding. As a temporary workaround, JNITransport class will changed to hide this difference from the caller. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-263) JNIDelivery.isPartial should delegate to pn_delivery_partial
[ https://issues.apache.org/jira/browse/PROTON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved PROTON-263. --- Resolution: Fixed Change committed by rev. 1453848 JNIDelivery.isPartial should delegate to pn_delivery_partial Key: PROTON-263 URL: https://issues.apache.org/jira/browse/PROTON-263 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Reporter: Keith Wall Assignee: Keith Wall Fix For: 0.5 The JNI Delivery interface currently throws a ProtonUnsupportedOperation, but should simple delegate to Proton-C pn_delivery_partial method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-110) java.lang.NullPointerException: the handle field is mandatory
[ https://issues.apache.org/jira/browse/PROTON-110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13595930#comment-13595930 ] Keith Wall commented on PROTON-110: --- Hiram Can you describe the method you used to cause this defect to manifest itself? Are you still able to reproduce against 0.4? Please advise and I investigate. regards, Keith. java.lang.NullPointerException: the handle field is mandatory - Key: PROTON-110 URL: https://issues.apache.org/jira/browse/PROTON-110 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Hiram Chirino Assignee: Keith Wall I saw the following NPE while using proton: java.lang.NullPointerException: the handle field is mandatory at org.apache.qpid.proton.type.transport.Transfer.setHandle(Transfer.java:67) at org.apache.qpid.proton.engine.impl.TransportImpl.processMessageData(TransportImpl.java:403) at org.apache.qpid.proton.engine.impl.TransportImpl.transportOutput(TransportImpl.java:212) at org.apache.qpid.proton.engine.impl.TransportImpl.access$000(TransportImpl.java:54) at org.apache.qpid.proton.engine.impl.TransportImpl$1.output(TransportImpl.java:118) at org.apache.qpid.proton.engine.impl.TransportImpl.output(TransportImpl.java:177) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-266) JNIMessage does not encode message body
Keith Wall created PROTON-266: - Summary: JNIMessage does not encode message body Key: PROTON-266 URL: https://issues.apache.org/jira/browse/PROTON-266 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Reporter: Keith Wall Fix For: 0.5 When using the Java bindings for Proton, currently calling #setBody() has no effect.It should be changed to update the _body thus allowing the message body to be encoded correctly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-266) JNIMessage does not encode message body
[ https://issues.apache.org/jira/browse/PROTON-266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned PROTON-266: - Assignee: Keith Wall JNIMessage does not encode message body --- Key: PROTON-266 URL: https://issues.apache.org/jira/browse/PROTON-266 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Reporter: Keith Wall Assignee: Keith Wall Fix For: 0.5 When using the Java bindings for Proton, currently calling #setBody() has no effect.It should be changed to update the _body thus allowing the message body to be encoded correctly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-258) Delivery interface should expose receiver settlement mode
Keith Wall created PROTON-258: - Summary: Delivery interface should expose receiver settlement mode Key: PROTON-258 URL: https://issues.apache.org/jira/browse/PROTON-258 Project: Qpid Proton Issue Type: Improvement Components: proton-c, proton-j Reporter: Keith Wall AMQP 1.0 permits the receiver settlement mode to be overridden for an individual transfer. This overrides the receiver settlement mode that was agreed at link establishment time for the scope of a single delivery only. See: http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-transfer The Proton (Engine) API does not currently expose this ability to the user. The Delivery interface should be augmented so that: * as a user of Sender, I can override the receiver settlement mode for an outgoing Delivery. * as a user of Receiver, I can determine the settlement mode in force an incoming Delivery. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-261) pn_delivery_local_state and pn_delivery_remote_state can return a zero value (outside that defined by the pn_disposition_t enum)
Keith Wall created PROTON-261:
-
Summary: pn_delivery_local_state and pn_delivery_remote_state can
return a zero value (outside that defined by the pn_disposition_t enum)
Key: PROTON-261
URL: https://issues.apache.org/jira/browse/PROTON-261
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.5
Reporter: Keith Wall
In proton-c, pn_delivery_local_state and pn_delivery_remote_state are defined
as returning an pn_disposition_t:
PN_EXTERN pn_disposition_t pn_delivery_local_state(pn_delivery_t *delivery);
PN_EXTERN pn_disposition_t pn_delivery_remote_state(pn_delivery_t *delivery);
with pn_disposition_t defined as:
typedef enum pn_disposition_t {
PN_RECEIVED=1,
PN_ACCEPTED=2,
PN_REJECTED=3,
PN_RELEASED=4,
PN_MODIFIED=5
} pn_disposition_t;
However, there are circumstances when the proton-c implementation returns a
value outside this enumeration - value 0 - coming for the struct initialisation
in pn_delivery(). What does this value mean and how is an application supposed
to react to this value? Are there an implicit restrictions regarding when an
application may call pn_delivery_local_state/pn_delivery_remote_state?
btw. This question arises from work on PROTON-257. Proton-jni (Swig generated
code) is failing to decode the enum when testing the state of a newly created
Delivery.
test(org.apache.qpid.proton.systemtests.ProtonEngineExampleTest) Time elapsed:
0.109 sec ERROR!
java.lang.IllegalArgumentException: No enum class
org.apache.qpid.proton.jni.pn_disposition_t with value 0
at
org.apache.qpid.proton.jni.pn_disposition_t.swigToEnum(pn_disposition_t.java:32)
at
org.apache.qpid.proton.jni.Proton.pn_delivery_local_state(Proton.java:624)
at
org.apache.qpid.proton.engine.jni.JNIDelivery.getLocalState(JNIDelivery.java:100)
at
org.apache.qpid.proton.systemtests.ProtonEngineExampleTest.test(ProtonEngineExampleTest.java:190)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-261) pn_delivery_local_state and pn_delivery_remote_state can return a zero value (outside that defined by the pn_disposition_t enum)
[
https://issues.apache.org/jira/browse/PROTON-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated PROTON-261:
--
Description:
In proton-c, pn_delivery_local_state and pn_delivery_remote_state are defined
as returning an pn_disposition_t:
PN_EXTERN pn_disposition_t pn_delivery_local_state(pn_delivery_t *delivery);
PN_EXTERN pn_disposition_t pn_delivery_remote_state(pn_delivery_t *delivery);
with pn_disposition_t defined as:
typedef enum pn_disposition_t {
PN_RECEIVED=1,
PN_ACCEPTED=2,
PN_REJECTED=3,
PN_RELEASED=4,
PN_MODIFIED=5
} pn_disposition_t;
However, there are circumstances when the proton-c implementation returns a
value outside this enumeration - value 0 - coming for the struct initialisation
in pn_delivery(). What does this value mean and how is an application supposed
to react to this value? Are there an implicit restrictions regarding when an
application may call pn_delivery_local_state/pn_delivery_remote_state?
btw. This question arises from work on PROTON-257. Proton-jni (Swig generated
code) is failing to decode the enum when testing the state of a newly created
Delivery.
test(org.apache.qpid.proton.systemtests.ProtonEngineExampleTest) Time elapsed:
0.109 sec ERROR!
java.lang.IllegalArgumentException: No enum class
org.apache.qpid.proton.jni.pn_disposition_t with value 0
at
org.apache.qpid.proton.jni.pn_disposition_t.swigToEnum(pn_disposition_t.java:32)
at
org.apache.qpid.proton.jni.Proton.pn_delivery_local_state(Proton.java:624)
at
org.apache.qpid.proton.engine.jni.JNIDelivery.getLocalState(JNIDelivery.java:100)
at
org.apache.qpid.proton.systemtests.ProtonEngineExampleTest.test(ProtonEngineExampleTest.java:190)
was:
In proton-c, pn_delivery_local_state and pn_delivery_remote_state are defined
as returning an pn_disposition_t:
PN_EXTERN pn_disposition_t pn_delivery_local_state(pn_delivery_t *delivery);
PN_EXTERN pn_disposition_t pn_delivery_remote_state(pn_delivery_t *delivery);
with pn_disposition_t defined as:
typedef enum pn_disposition_t {
PN_RECEIVED=1,
PN_ACCEPTED=2,
PN_REJECTED=3,
PN_RELEASED=4,
PN_MODIFIED=5
} pn_disposition_t;
However, there are circumstances when the proton-c implementation returns a
value outside this enumeration - value 0 - coming for the struct initialisation
in pn_delivery(). What does this value mean and how is an application supposed
to react to this value? Are there an implicit restrictions regarding when an
application may call pn_delivery_local_state/pn_delivery_remote_state?
btw. This question arises from work on PROTON-257. Proton-jni (Swig generated
code) is failing to decode the enum when testing the state of a newly created
Delivery.
test(org.apache.qpid.proton.systemtests.ProtonEngineExampleTest) Time elapsed:
0.109 sec ERROR!
java.lang.IllegalArgumentException: No enum class
org.apache.qpid.proton.jni.pn_disposition_t with value 0
at
org.apache.qpid.proton.jni.pn_disposition_t.swigToEnum(pn_disposition_t.java:32)
at
org.apache.qpid.proton.jni.Proton.pn_delivery_local_state(Proton.java:624)
at
org.apache.qpid.proton.engine.jni.JNIDelivery.getLocalState(JNIDelivery.java:100)
at
org.apache.qpid.proton.systemtests.ProtonEngineExampleTest.test(ProtonEngineExampleTest.java:190)
pn_delivery_local_state and pn_delivery_remote_state can return a zero value
(outside that defined by the pn_disposition_t enum)
Key: PROTON-261
URL: https://issues.apache.org/jira/browse/PROTON-261
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.5
Reporter: Keith Wall
In proton-c, pn_delivery_local_state and pn_delivery_remote_state are defined
as returning an pn_disposition_t:
PN_EXTERN pn_disposition_t pn_delivery_local_state(pn_delivery_t *delivery);
PN_EXTERN pn_disposition_t pn_delivery_remote_state(pn_delivery_t *delivery);
with pn_disposition_t defined as:
typedef enum pn_disposition_t {
PN_RECEIVED=1,
PN_ACCEPTED=2,
PN_REJECTED=3,
PN_RELEASED=4,
PN_MODIFIED=5
} pn_disposition_t;
However, there are circumstances when the proton-c implementation returns a
value outside this enumeration - value 0 - coming for the struct
initialisation in pn_delivery(). What does this value mean and how is an
application supposed to react to this value? Are there an implicit
restrictions regarding when an application may call
pn_delivery_local_state/pn_delivery_remote_state?
btw. This question arises from work on PROTON-257. Proton-jni (Swig
generated code) is failing to decode the enum when testing the state of a
newly created Delivery.
[jira] [Updated] (PROTON-225) Redesign Transport interface such that Transport owns the in/out buffers rather than its client
[ https://issues.apache.org/jira/browse/PROTON-225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-225: -- Description: This issue is intended to cover the Transport API redesign proposed on the mailing list (http://qpid.2158936.n2.nabble.com/transport-interface-changes-td7588099.html) as part of discussions around PROTON-222. The redesign is being tracked under this new because we probably want to implement it on a different timescale to the PROTON-222 bug fix. When refactoring the Java implementation, we should consider if the point when the sent/received protocol logging is done should be changed. It should also address the difference around the use of PN_EOS (-1) that proton-c uses to signal that a) the engine will accept no further input and b) produce no further output. was: This issue is intended to cover the Transport API redesign proposed on the mailing list (http://qpid.2158936.n2.nabble.com/transport-interface-changes-td7588099.html) as part of discussions around PROTON-222. The redesign is being tracked under this new because we probably want to implement it on a different timescale to the PROTON-222 bug fix. When refactoring the Java implementation, we should consider if the point when the sent/received protocol logging is done should be changed. Redesign Transport interface such that Transport owns the in/out buffers rather than its client --- Key: PROTON-225 URL: https://issues.apache.org/jira/browse/PROTON-225 Project: Qpid Proton Issue Type: Improvement Affects Versions: 0.3 Reporter: Philip Harvey Assignee: Ken Giusti Fix For: 0.5 This issue is intended to cover the Transport API redesign proposed on the mailing list (http://qpid.2158936.n2.nabble.com/transport-interface-changes-td7588099.html) as part of discussions around PROTON-222. The redesign is being tracked under this new because we probably want to implement it on a different timescale to the PROTON-222 bug fix. When refactoring the Java implementation, we should consider if the point when the sent/received protocol logging is done should be changed. It should also address the difference around the use of PN_EOS (-1) that proton-c uses to signal that a) the engine will accept no further input and b) produce no further output. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-263) JNIDelivery.isPartial should delegate to pn_delivery_partial
Keith Wall created PROTON-263: - Summary: JNIDelivery.isPartial should delegate to pn_delivery_partial Key: PROTON-263 URL: https://issues.apache.org/jira/browse/PROTON-263 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Reporter: Keith Wall Fix For: 0.5 The JNI Delivery interface currently throws a ProtonUnsupportedOperation, but should simple delegate to Proton-C pn_delivery_partial method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-263) JNIDelivery.isPartial should delegate to pn_delivery_partial
[ https://issues.apache.org/jira/browse/PROTON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned PROTON-263: - Assignee: Keith Wall JNIDelivery.isPartial should delegate to pn_delivery_partial Key: PROTON-263 URL: https://issues.apache.org/jira/browse/PROTON-263 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Reporter: Keith Wall Assignee: Keith Wall Fix For: 0.5 The JNI Delivery interface currently throws a ProtonUnsupportedOperation, but should simple delegate to Proton-C pn_delivery_partial method. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-264) Proton-J and Proton-C transports make inconsistent use of return values from methods input and output
Keith Wall created PROTON-264: - Summary: Proton-J and Proton-C transports make inconsistent use of return values from methods input and output Key: PROTON-264 URL: https://issues.apache.org/jira/browse/PROTON-264 Project: Qpid Proton Issue Type: Bug Components: proton-c, proton-j Affects Versions: 0.4 Reporter: Keith Wall Assignee: Keith Wall Priority: Minor Fix For: 0.5 This defect refers to the transport interface already in the process of being deprecated by PROTON-225. The scope of PROTON-225 has been increased (=noted in Jira) to ensure that this defect is not carried forward to the new interface and we end up with consistent behaviour. Currently, in Proton-C pn_transport_output() returns PN_EOS (=-1) to signal that the Transport will produce no further output, and pn_transport_input() returns PN_EOS to signal that the Transport will accept no further input. However, Proton-J, output always returns the number bytes output (even if zero), and input returns the number of bytes accepted (again even if zero). This difference presents a problem to tests utilising the Proton-JNI binding. As a temporary workaround, JNITransport class will changed to hide this difference from the caller. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-264) Proton-J and Proton-C transports make inconsistent use of return values within methods input and output
[ https://issues.apache.org/jira/browse/PROTON-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-264: -- Summary: Proton-J and Proton-C transports make inconsistent use of return values within methods input and output (was: Proton-J and Proton-C transports make inconsistent use of return values from methods input and output) Proton-J and Proton-C transports make inconsistent use of return values within methods input and output --- Key: PROTON-264 URL: https://issues.apache.org/jira/browse/PROTON-264 Project: Qpid Proton Issue Type: Bug Components: proton-c, proton-j Affects Versions: 0.4 Reporter: Keith Wall Assignee: Keith Wall Priority: Minor Fix For: 0.5 This defect refers to the transport interface already in the process of being deprecated by PROTON-225. The scope of PROTON-225 has been increased (=noted in Jira) to ensure that this defect is not carried forward to the new interface and we end up with consistent behaviour. Currently, in Proton-C pn_transport_output() returns PN_EOS (=-1) to signal that the Transport will produce no further output, and pn_transport_input() returns PN_EOS to signal that the Transport will accept no further input. However, Proton-J, output always returns the number bytes output (even if zero), and input returns the number of bytes accepted (again even if zero). This difference presents a problem to tests utilising the Proton-JNI binding. As a temporary workaround, JNITransport class will changed to hide this difference from the caller. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-265) Change Message#decode to signal inability to decode entire buffer via exception rather than return value
Keith Wall created PROTON-265: - Summary: Change Message#decode to signal inability to decode entire buffer via exception rather than return value Key: PROTON-265 URL: https://issues.apache.org/jira/browse/PROTON-265 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Keith Wall Assignee: Keith Wall Fix For: 0.5 Change Message#decode signature to throw an exception in the case where the decoder fails to decode all the bytes in the input buffer, rather than returning the number of bytes actually decoded. This will make the Java implementation more closely follow the Proton-C. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-254) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010
[ https://issues.apache.org/jira/browse/PROTON-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-254: -- Description: Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E was: Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directirve to CMake in the case where BUILD_WITH_CXX has been enabled eariler in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java, and subsequently, JNIMessage.java fails to compile. errors to be inserted [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010 -- Key: PROTON-254 URL: https://issues.apache.org/jira/browse/PROTON-254 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Environment: Windows 7 Visual Studio 2010 Reporter: Keith Wall Attachments: make-proton-jni-cxx-errors.txt Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-254) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010
[ https://issues.apache.org/jira/browse/PROTON-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-254: -- Description: Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E was: Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010 -- Key: PROTON-254 URL: https://issues.apache.org/jira/browse/PROTON-254 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Environment: Windows 7 Visual Studio 2010 Reporter: Keith Wall Attachments: make-proton-jni-cxx-errors.txt Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-254) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010
[ https://issues.apache.org/jira/browse/PROTON-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-254: -- Attachment: make-proton-jni-cxx-errors.txt Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010 -- Key: PROTON-254 URL: https://issues.apache.org/jira/browse/PROTON-254 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Environment: Windows 7 Visual Studio 2010 Reporter: Keith Wall Attachments: make-proton-jni-cxx-errors.txt Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-254) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010
[ https://issues.apache.org/jira/browse/PROTON-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-254: -- Description: Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E was: Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010 -- Key: PROTON-254 URL: https://issues.apache.org/jira/browse/PROTON-254 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Environment: Windows 7 Visual Studio 2010 Reporter: Keith Wall Attachments: make-proton-jni-cxx-errors.txt Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-254) Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010
[ https://issues.apache.org/jira/browse/PROTON-254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-254: -- Description: Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(java.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E was: Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(python.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E Swig generated c code for java bindings fails to compile on Windows Visual Studio 2010 -- Key: PROTON-254 URL: https://issues.apache.org/jira/browse/PROTON-254 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Environment: Windows 7 Visual Studio 2010 Reporter: Keith Wall Attachments: make-proton-jni-cxx-errors.txt Swig generated C code for the Java bindings fails to compile on Visual Studio 2010 with error message: C1083: Cannot open include file: 'stdbool.h': No such file or directory After discussion on list [1], we tried changing bindings/java/CMakeLists.txt to use CPLUSPLUS ON directive to CMake in the case where BUILD_WITH_CXX has been enabled earlier in the build. if (BUILD_WITH_CXX) SET_SOURCE_FILES_PROPERTIES(java.i PROPERTIES CPLUSPLUS ON) endif (BUILD_WITH_CXX) Switching to CPP in this way exposed a number of errors when compiling the CPP code resulting from the java.i (casting issues, pointer arithemetic etc - see attached make-proton-jni-cxx-errors.txt). However, even after resolving the CPP compilation issues, we then encounter a problem with Swig's handling of nested unions when when CPP. The seeming inability of SWIG (when used with CPP) to represent the union means that SWIG does not produce pn_atom_t_u.java. JNIMessage.java, which references pn_atom_t_u, consequently fails to compile. The warning from swig is: /home/keith/src/proton/proton-c/include/proton/codec.h:91: Warning 312: Nested union not currently supported (ignored). [1] http://mail-archives.apache.org/mod_mbox/qpid-proton/201302.mbox/%3ccamyv19mgbdvd2wextvpwywtysskadokb7wtj+u-3jkncwdx...@mail.gmail.com%3E -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-249) Build fails on Win8 / VS 2012 with path error
[ https://issues.apache.org/jira/browse/PROTON-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-249: -- Fix Version/s: 0.5 Priority: Major (was: Blocker) Patch applied. Note in the process of this work, we discovered a second issue affecting the ability to compile the Java bindings under Windows. This is being addressed separated under PROTON-254. Build fails on Win8 / VS 2012 with path error - Key: PROTON-249 URL: https://issues.apache.org/jira/browse/PROTON-249 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Environment: Windows 8 64 bit w/ cmake v. 2.8.10.12 and Visual Studio 2012 Reporter: Paul O'Fallon Assignee: Keith Wall Fix For: 0.5 The build in Visual Studio generates one error, which is the following (from the build output): 3 Building Java objects for proton-api.jar 3 javac: file not found: C:\qpid-proton-0.4\proton-j\proton-api\src\main\java\org\apache\qpi\proton\driver\Connector.java 3 Usage: javac options source files Note that the path is qpi, not qpid -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-249) Build fails on Win8 / VS 2012 with path error
[ https://issues.apache.org/jira/browse/PROTON-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved PROTON-249. --- Resolution: Fixed Build fails on Win8 / VS 2012 with path error - Key: PROTON-249 URL: https://issues.apache.org/jira/browse/PROTON-249 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Environment: Windows 8 64 bit w/ cmake v. 2.8.10.12 and Visual Studio 2012 Reporter: Paul O'Fallon Assignee: Keith Wall Fix For: 0.5 The build in Visual Studio generates one error, which is the following (from the build output): 3 Building Java objects for proton-api.jar 3 javac: file not found: C:\qpid-proton-0.4\proton-j\proton-api\src\main\java\org\apache\qpi\proton\driver\Connector.java 3 Usage: javac options source files Note that the path is qpi, not qpid -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-249) Build fails on Win8 / VS 2012 with path error
[ https://issues.apache.org/jira/browse/PROTON-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned PROTON-249: - Assignee: Keith Wall Build fails on Win8 / VS 2012 with path error - Key: PROTON-249 URL: https://issues.apache.org/jira/browse/PROTON-249 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Environment: Windows 8 64 bit w/ cmake v. 2.8.10.12 and Visual Studio 2012 Reporter: Paul O'Fallon Assignee: Keith Wall The build in Visual Studio generates one error, which is the following (from the build output): 3 Building Java objects for proton-api.jar 3 javac: file not found: C:\qpid-proton-0.4\proton-j\proton-api\src\main\java\org\apache\qpi\proton\driver\Connector.java 3 Usage: javac options source files Note that the path is qpi, not qpid -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (PROTON-249) Build fails on Win8 / VS 2012 with path error
[ https://issues.apache.org/jira/browse/PROTON-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585836#comment-13585836 ] Keith Wall edited comment on PROTON-249 at 2/25/13 12:56 PM: - I've successfully reproduced Paul's problem. The problem is the handling of long command lines under the Windows OS. It seems Windows looses a byte at every 8192 boundary within the command line -- effectively limiting command lines to less than 8192 bytes.Our command line is ~11,000 characters long. We are currently testing a workaround which will use javac's @ flag to specify a file containing a list of source files, thus avoiding the requirement for long command lines. (A defect http://public.kitware.com/Bug/view.php?id=13028 was raised against Cmake's UseJava module but unfortunately this never got assigned and has been subsequently closed without action). was (Author: k-wall): I've successfully reproduced Paul's problem. The problem is the handling of long command lines under the Windows OS. It seems Windows looses a byte at every 8192 boundary within the command line -- effectively limiting command lines to less than 8192 bytes.Our command line is ~11,000 characters long. We are currently testing a workaround which will use javac's @ flag to specify a file containing a list of source files, thus avoiding the requirement for long command lines. (A defect http://public.kitware.com/Bug/view.php?id=13028 was raised against Cmake's UseJava module but unfortunately this never got assigned). Build fails on Win8 / VS 2012 with path error - Key: PROTON-249 URL: https://issues.apache.org/jira/browse/PROTON-249 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Environment: Windows 8 64 bit w/ cmake v. 2.8.10.12 and Visual Studio 2012 Reporter: Paul O'Fallon Assignee: Keith Wall The build in Visual Studio generates one error, which is the following (from the build output): 3 Building Java objects for proton-api.jar 3 javac: file not found: C:\qpid-proton-0.4\proton-j\proton-api\src\main\java\org\apache\qpi\proton\driver\Connector.java 3 Usage: javac options source files Note that the path is qpi, not qpid -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-249) Build fails on Win8 / VS 2012 with path error
[ https://issues.apache.org/jira/browse/PROTON-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-249: -- Priority: Blocker (was: Major) Build fails on Win8 / VS 2012 with path error - Key: PROTON-249 URL: https://issues.apache.org/jira/browse/PROTON-249 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Environment: Windows 8 64 bit w/ cmake v. 2.8.10.12 and Visual Studio 2012 Reporter: Paul O'Fallon Assignee: Keith Wall Priority: Blocker The build in Visual Studio generates one error, which is the following (from the build output): 3 Building Java objects for proton-api.jar 3 javac: file not found: C:\qpid-proton-0.4\proton-j\proton-api\src\main\java\org\apache\qpi\proton\driver\Connector.java 3 Usage: javac options source files Note that the path is qpi, not qpid -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-249) Build fails on Win8 / VS 2012 with path error
[ https://issues.apache.org/jira/browse/PROTON-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13585838#comment-13585838 ] Keith Wall commented on PROTON-249: --- Marked as Blocker as this currently prevents users from successfully running the build on Windows, and I'm not aware of any reasonable workaround. Build fails on Win8 / VS 2012 with path error - Key: PROTON-249 URL: https://issues.apache.org/jira/browse/PROTON-249 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Environment: Windows 8 64 bit w/ cmake v. 2.8.10.12 and Visual Studio 2012 Reporter: Paul O'Fallon Assignee: Keith Wall Priority: Blocker The build in Visual Studio generates one error, which is the following (from the build output): 3 Building Java objects for proton-api.jar 3 javac: file not found: C:\qpid-proton-0.4\proton-j\proton-api\src\main\java\org\apache\qpi\proton\driver\Connector.java 3 Usage: javac options source files Note that the path is qpi, not qpid -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-242) Shared library used JNI code has poor name libproton-swig.so
[ https://issues.apache.org/jira/browse/PROTON-242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-242: -- Fix Version/s: (was: 0.5) 0.4 Shared library used JNI code has poor name libproton-swig.so -- Key: PROTON-242 URL: https://issues.apache.org/jira/browse/PROTON-242 Project: Qpid Proton Issue Type: Improvement Components: proton-c Reporter: Philip Harvey Assignee: Keith Wall Fix For: 0.4 The shared library used JNI code has name libproton-swig.so, which is poor because the (a) it doesn't hint that it's used by the proton-jni.jar, and (b) Swig should be an implementation detail that is hidden from the user of the library. A better name would be libproton-jni.so. Note that I've used the lib prefix as required by JNI on Linux. On Windows, this prefix should be blank. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-217) cmake build system should include install target for Java binaries
[ https://issues.apache.org/jira/browse/PROTON-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580591#comment-13580591 ] Keith Wall commented on PROTON-217: --- CMakeLists.txts have been enhanced to install the JARs and shared-objects resulting from the build. All install locations are override-able at build time using -D arguments (or via the edit_cache). The following variables are used: JAVA_INSTALL_DIR Installation directory for all JARs except those using JNI JNI_INSTALL_DIR Installation directory for all JARs utilising JNI JNI_SHARED_LIB_INSTALL_DIR Installation directory for shared objects used by JNI JARs cmake build system should include install target for Java binaries Key: PROTON-217 URL: https://issues.apache.org/jira/browse/PROTON-217 Project: Qpid Proton Issue Type: Improvement Affects Versions: 0.3 Reporter: Philip Harvey Assignee: Philip Harvey Priority: Minor Fix For: 0.4 The cmake build system was recently modified in PROTON-194 to include compilation of the Java artefacts. However, we don't yet have a target to install them. Further discussion is required to decide where they should be installed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (PROTON-217) cmake build system should include install target for Java binaries
[
https://issues.apache.org/jira/browse/PROTON-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580591#comment-13580591
]
Keith Wall edited comment on PROTON-217 at 2/18/13 1:13 PM:
Build system changed so that 'make install' installs all JARs (and shared
objects) into the install tree.
The install locations are controlled by the following CMake variables:
JAVA_INSTALL_DIR Installation directory for all JARs except those using JNI
(defaults to ${SHARE_INSTALL_DIR}/java)
JNI_INSTALL_DIR Installation directory for all JARs utilising JNI (defaults
to ${LIB_INSTALL_DIR}/java)
JNI_SHARED_LIB_INSTALL_DIR Installation directory for shared objects used by
JNI JARs (defaults to ${LIB_INSTALL_DIR})
Variables default values are based on the fundamental install variables
SHARE_INSTALL_DIR and LIB_INSTALL_DIR, so any change to the install prefix will
be incorporated automatically.
was (Author: k-wall):
CMakeLists.txts have been enhanced to install the JARs and shared-objects
resulting from the build. All install locations are override-able at build
time using -D arguments (or via the edit_cache).
The following variables are used:
JAVA_INSTALL_DIR Installation directory for all JARs except those using JNI
JNI_INSTALL_DIR Installation directory for all JARs utilising JNI
JNI_SHARED_LIB_INSTALL_DIR Installation directory for shared objects used by
JNI JARs
cmake build system should include install target for Java binaries
Key: PROTON-217
URL: https://issues.apache.org/jira/browse/PROTON-217
Project: Qpid Proton
Issue Type: Improvement
Affects Versions: 0.3
Reporter: Philip Harvey
Assignee: Philip Harvey
Priority: Minor
Fix For: 0.4
The cmake build system was recently modified in PROTON-194 to include
compilation of the Java artefacts. However, we don't yet have a target to
install them.
Further discussion is required to decide where they should be installed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-217) cmake build system should include install target for Java binaries
[ https://issues.apache.org/jira/browse/PROTON-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved PROTON-217. --- Resolution: Fixed cmake build system should include install target for Java binaries Key: PROTON-217 URL: https://issues.apache.org/jira/browse/PROTON-217 Project: Qpid Proton Issue Type: Improvement Affects Versions: 0.3 Reporter: Philip Harvey Assignee: Philip Harvey Priority: Minor Fix For: 0.4 The cmake build system was recently modified in PROTON-194 to include compilation of the Java artefacts. However, we don't yet have a target to install them. Further discussion is required to decide where they should be installed. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-224) Python test framework: treat ProtonUnsupportedOperationException automatically as a skipped test
Keith Wall created PROTON-224: - Summary: Python test framework: treat ProtonUnsupportedOperationException automatically as a skipped test Key: PROTON-224 URL: https://issues.apache.org/jira/browse/PROTON-224 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Keith Wall Priority: Minor Fix For: 0.4 Refactor test framework to arrange from proton_test (the python test runner) to treat ProtonUnsupportedOperationException (the exception used by the Java stacks to signal an unimplemented Proton feature) automatically as a skipped test. direct dependency between -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-224) Python test framework: treat ProtonUnsupportedOperationException automatically as a skipped test
[ https://issues.apache.org/jira/browse/PROTON-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-224: -- Issue Type: Improvement (was: Bug) Python test framework: treat ProtonUnsupportedOperationException automatically as a skipped test Key: PROTON-224 URL: https://issues.apache.org/jira/browse/PROTON-224 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Keith Wall Assignee: Keith Wall Priority: Minor Fix For: 0.4 Refactor test framework to arrange from proton_test (the python test runner) to treat ProtonUnsupportedOperationException (the exception used by the Java stacks to signal an unimplemented Proton feature) automatically as a skipped test. direct dependency between -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-224) Python test framework: treat ProtonUnsupportedOperationException automatically as a skipped test
[ https://issues.apache.org/jira/browse/PROTON-224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned PROTON-224: - Assignee: Keith Wall Python test framework: treat ProtonUnsupportedOperationException automatically as a skipped test Key: PROTON-224 URL: https://issues.apache.org/jira/browse/PROTON-224 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Keith Wall Assignee: Keith Wall Priority: Minor Fix For: 0.4 Refactor test framework to arrange from proton_test (the python test runner) to treat ProtonUnsupportedOperationException (the exception used by the Java stacks to signal an unimplemented Proton feature) automatically as a skipped test. direct dependency between -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-196) Automate the running of system tests on Apache CI
[ https://issues.apache.org/jira/browse/PROTON-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13574482#comment-13574482 ] Keith Wall commented on PROTON-196: --- We now have the following Proton jobs set up on Apache Jenkins CI: ttps://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-c/ # Build proton-c and test with Python system tests. https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/# Build proton-j and test with Python/Java system tests https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-jni/ # Build proton-c and JNI bindings and test with Python/Java system tests https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j-Deploy/ # Deploy proton-j snapshot artefacts Automate the running of system tests on Apache CI - Key: PROTON-196 URL: https://issues.apache.org/jira/browse/PROTON-196 Project: Qpid Proton Issue Type: Task Reporter: Keith Wall Assignee: Keith Wall Setup the build and execution of proton system tests on Apache CI. Tests profiles will exercise proton-c/proton-c, proton-j/proton-j, and proton-j/proton-c combinations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-196) Automate the running of system tests on Apache CI
[ https://issues.apache.org/jira/browse/PROTON-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved PROTON-196. --- Resolution: Fixed Fix Version/s: 0.4 Automate the running of system tests on Apache CI - Key: PROTON-196 URL: https://issues.apache.org/jira/browse/PROTON-196 Project: Qpid Proton Issue Type: Task Reporter: Keith Wall Assignee: Keith Wall Fix For: 0.4 Setup the build and execution of proton system tests on Apache CI. Tests profiles will exercise proton-c/proton-c, proton-j/proton-j, and proton-j/proton-c combinations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (PROTON-196) Automate the running of system tests on Apache CI
[ https://issues.apache.org/jira/browse/PROTON-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13574482#comment-13574482 ] Keith Wall edited comment on PROTON-196 at 2/8/13 1:38 PM: --- We now have the following Proton jobs set up on Apache Jenkins CI: https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-c/ # Build proton-c and test with Python system tests. https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/# Build proton-j and test with Python/Java system tests https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-jni/ # Build proton-c and JNI bindings and test with Python/Java system tests https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j-Deploy/ # Deploy proton-j snapshot artefacts was (Author: k-wall): We now have the following Proton jobs set up on Apache Jenkins CI: ttps://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-c/ # Build proton-c and test with Python system tests. https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j/# Build proton-j and test with Python/Java system tests https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-jni/ # Build proton-c and JNI bindings and test with Python/Java system tests https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-j-Deploy/ # Deploy proton-j snapshot artefacts Automate the running of system tests on Apache CI - Key: PROTON-196 URL: https://issues.apache.org/jira/browse/PROTON-196 Project: Qpid Proton Issue Type: Task Reporter: Keith Wall Assignee: Keith Wall Setup the build and execution of proton system tests on Apache CI. Tests profiles will exercise proton-c/proton-c, proton-j/proton-j, and proton-j/proton-c combinations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-194) Change proton's build systems to allow for the creation of a Java binding for proton-c.
[ https://issues.apache.org/jira/browse/PROTON-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566594#comment-13566594 ] Keith Wall commented on PROTON-194: --- The changes on the jni-branch are nearing completion. The changes with respect to current trunk are summarised below. - README/LICENSE files- README/LICENCE files have been moved to the proton level. The README has been updated to reflect the new practice. -Building Proton-C- Build is now performed from the parent (proton) directory rather than proton-c. If Cmake can find the JDK, proton-api and proton-jni will be built, otherwise they are skipped If Cmake can find** Bouncycastle JARs, proton-j-impl will be built, otherwise it is skipped. cd proton mkdir build cd build cmake .. ... ** JAR search path is defined by Cmake's find_jar() function as /usr/share/java/ and /usr/local/share/java/. This can be supplemented on the command line via: cmake -DPROTON_JAR_DEPEND_DIR=... .. -Testing Proton-C (Python tests)- proton-test script and the Python tests have moved to accommodate tests written in other languages. cd proton . ./config.sh ./tests/python/proton-test -Building Proton-J- Build is now performed from the parent (proton) directory rather than proton-j. Typical maven commands: mvn compile -DskipTests # compile everything, skipping the tests mvn package # package everything -Testing Proton-J/Proton-C via JNI bindings- mvn test -Pproton-j# Run all system tests against proton-j mvn test -Pproton-jnj # Run all system tests against proton-c using jni wrappers *** mvn test -Pproton-j -Dproton.pythontest.pattern='proton_tests.transport.TransportTest.*' # Run Python tests matching patterm *** you need to have previously built proton-c with the JNI bindings. Change proton's build systems to allow for the creation of a Java binding for proton-c. --- Key: PROTON-194 URL: https://issues.apache.org/jira/browse/PROTON-194 Project: Qpid Proton Issue Type: Improvement Components: proton-c, proton-j Reporter: Keith Wall The catalyst for this work was the need to conveniently build and test the JNI bindings created in PROTON-192. However, there are a number of other requirements for our build system that are worth reiterating. To avoid making excessive edits to this JIRA I've created a wiki page listing the provisional requirements of or build system: https://cwiki.apache.org/confluence/display/qpid/Proton+build+system+proposals -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-210) Proton release.sh should create a single release tarball for proton-c/proton-j
Keith Wall created PROTON-210: - Summary: Proton release.sh should create a single release tarball for proton-c/proton-j Key: PROTON-210 URL: https://issues.apache.org/jira/browse/PROTON-210 Project: Qpid Proton Issue Type: Task Components: proton-c, proton-j Reporter: Keith Wall Assignee: Keith Wall Following changes made by PROTON-194, the release script must change to create a single tarball containing proton-c, proton-j and test trees. The tarball should exclude proton-c/examples/mailbox and proton-j/contrib. It should contain to perform a maven the maven version set/commit. The ruby gem will be unaffected by this change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-210) Proton release.sh should create a single release tarball for proton-c/proton-j
[ https://issues.apache.org/jira/browse/PROTON-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-210: -- Issue Type: New Feature (was: Task) Proton release.sh should create a single release tarball for proton-c/proton-j -- Key: PROTON-210 URL: https://issues.apache.org/jira/browse/PROTON-210 Project: Qpid Proton Issue Type: New Feature Components: proton-c, proton-j Reporter: Keith Wall Assignee: Keith Wall Following changes made by PROTON-194, the release script must change to create a single tarball containing proton-c, proton-j and test trees. The tarball should exclude proton-c/examples/mailbox and proton-j/contrib. It should contain to perform a maven the maven version set/commit. The ruby gem will be unaffected by this change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-210) Proton release.sh should create a single release tarball for proton-c/proton-j
[ https://issues.apache.org/jira/browse/PROTON-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-210: -- Component/s: proton-j Proton release.sh should create a single release tarball for proton-c/proton-j -- Key: PROTON-210 URL: https://issues.apache.org/jira/browse/PROTON-210 Project: Qpid Proton Issue Type: New Feature Components: proton-c, proton-j Reporter: Keith Wall Assignee: Keith Wall Following changes made by PROTON-194, the release script must change to create a single tarball containing proton-c, proton-j and test trees. The tarball should exclude proton-c/examples/mailbox and proton-j/contrib. It should contain to perform a maven the maven version set/commit. The ruby gem will be unaffected by this change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-210) Proton release.sh should create a single release tarball for proton-c/proton-j
[ https://issues.apache.org/jira/browse/PROTON-210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-210: -- Component/s: (was: proton-j) Proton release.sh should create a single release tarball for proton-c/proton-j -- Key: PROTON-210 URL: https://issues.apache.org/jira/browse/PROTON-210 Project: Qpid Proton Issue Type: New Feature Components: proton-c Reporter: Keith Wall Assignee: Keith Wall Following changes made by PROTON-194, the release script must change to create a single tarball containing proton-c, proton-j and test trees. The tarball should exclude proton-c/examples/mailbox and proton-j/contrib. It should contain to perform a maven the maven version set/commit. The ruby gem will be unaffected by this change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-211) Non-maven users should have ability to run all system tests
Keith Wall created PROTON-211: - Summary: Non-maven users should have ability to run all system tests Key: PROTON-211 URL: https://issues.apache.org/jira/browse/PROTON-211 Project: Qpid Proton Issue Type: New Feature Components: proton-c, proton-j Reporter: Keith Wall Assignee: Keith Wall Non-maven users (those building proton-c, the bindings etc using cmake, make etc) should have a simple method to run all the system tests including those written in Java. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-192) Implement Proton-JNI binding for proton-c
Keith Wall created PROTON-192: - Summary: Implement Proton-JNI binding for proton-c Key: PROTON-192 URL: https://issues.apache.org/jira/browse/PROTON-192 Project: Qpid Proton Issue Type: Bug Reporter: Keith Wall Assignee: Keith Wall Expose proton-c via the Java proton API using swig/JNI. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-192) Implement Proton-JNI binding for proton-c
[ https://issues.apache.org/jira/browse/PROTON-192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-192: -- Issue Type: New Feature (was: Bug) Implement Proton-JNI binding for proton-c - Key: PROTON-192 URL: https://issues.apache.org/jira/browse/PROTON-192 Project: Qpid Proton Issue Type: New Feature Reporter: Keith Wall Assignee: Keith Wall Expose proton-c via the Java proton API using swig/JNI. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-193) Proton-j API omits some functionality
Keith Wall created PROTON-193: - Summary: Proton-j API omits some functionality Key: PROTON-193 URL: https://issues.apache.org/jira/browse/PROTON-193 Project: Qpid Proton Issue Type: Improvement Components: proton-j Reporter: Keith Wall A reconciliation of the proton-j API has revealed a number of areas where the projon-j api is deficient when compared with the proton-c api. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-194) Change proton's build systems to support allow for the creation of a Java binding for proton-c.
Keith Wall created PROTON-194: - Summary: Change proton's build systems to support allow for the creation of a Java binding for proton-c. Key: PROTON-194 URL: https://issues.apache.org/jira/browse/PROTON-194 Project: Qpid Proton Issue Type: Improvement Components: proton-c, proton-j Reporter: Keith Wall -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-194) Change proton's build systems to support allow for the creation of a Java binding for proton-c.
[ https://issues.apache.org/jira/browse/PROTON-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-194: -- Description: Change Change proton's build systems to support allow for the creation of a Java binding for proton-c. --- Key: PROTON-194 URL: https://issues.apache.org/jira/browse/PROTON-194 Project: Qpid Proton Issue Type: Improvement Components: proton-c, proton-j Reporter: Keith Wall Change -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-195) Move JythonTests and proton_tests/*.py into system-test module
Keith Wall created PROTON-195: - Summary: Move JythonTests and proton_tests/*.py into system-test module Key: PROTON-195 URL: https://issues.apache.org/jira/browse/PROTON-195 Project: Qpid Proton Issue Type: Improvement Reporter: Keith Wall Priority: Minor Move JythonTests (currently in the proton-j) and all python system tests (currently beneath proton_tests) into the system_tests module. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-196) Automate the running of system tests within CI
Keith Wall created PROTON-196: - Summary: Automate the running of system tests within CI Key: PROTON-196 URL: https://issues.apache.org/jira/browse/PROTON-196 Project: Qpid Proton Issue Type: Task Reporter: Keith Wall Setup the build and execution of proton system tests on Apache CI. Tests profiles will exercise proton-c/proton-c, proton-j/proton-j, and proton-j/proton-c combinations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-196) Automate the running of system tests on Apache CI
[ https://issues.apache.org/jira/browse/PROTON-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-196: -- Summary: Automate the running of system tests on Apache CI (was: Automate the running of system tests within CI) Automate the running of system tests on Apache CI - Key: PROTON-196 URL: https://issues.apache.org/jira/browse/PROTON-196 Project: Qpid Proton Issue Type: Task Reporter: Keith Wall Setup the build and execution of proton system tests on Apache CI. Tests profiles will exercise proton-c/proton-c, proton-j/proton-j, and proton-j/proton-c combinations. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-191) Proton-API reconciliation reporting tool
Keith Wall created PROTON-191: - Summary: Proton-API reconciliation reporting tool Key: PROTON-191 URL: https://issues.apache.org/jira/browse/PROTON-191 Project: Qpid Proton Issue Type: Improvement Components: proton-c, proton-j Reporter: Keith Wall Assignee: Keith Wall Add standalone tool that reconciles the public functions of the Proton-C API against the public API of the Proton-J API.Used so we can easily spot gaps in one implementation or the other. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-172) Implement SSL within proton-j
[ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated PROTON-172: -- Fix Version/s: 0.3 Implement SSL within proton-j - Key: PROTON-172 URL: https://issues.apache.org/jira/browse/PROTON-172 Project: Qpid Proton Issue Type: New Feature Components: proton-j Reporter: Philip Harvey Assignee: Keith Wall Fix For: 0.3 Attachments: 0001-PROTON-172-improved-unit-test-to-check-return-value-.patch, 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch, 0002-PROTON-172-Moved-SSL-classes-into-package-org.engine.patch Implement SSL within proton-j -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (PROTON-172) Implement SSL within proton-j
[ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall closed PROTON-172. - Implement SSL within proton-j - Key: PROTON-172 URL: https://issues.apache.org/jira/browse/PROTON-172 Project: Qpid Proton Issue Type: New Feature Components: proton-j Reporter: Philip Harvey Assignee: Keith Wall Fix For: 0.3 Attachments: 0001-PROTON-172-improved-unit-test-to-check-return-value-.patch, 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch, 0002-PROTON-172-Moved-SSL-classes-into-package-org.engine.patch Implement SSL within proton-j -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-172) Implement SSL within proton-j
[ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved PROTON-172. --- Resolution: Fixed Implement SSL within proton-j - Key: PROTON-172 URL: https://issues.apache.org/jira/browse/PROTON-172 Project: Qpid Proton Issue Type: New Feature Components: proton-j Reporter: Philip Harvey Assignee: Keith Wall Fix For: 0.3 Attachments: 0001-PROTON-172-improved-unit-test-to-check-return-value-.patch, 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0001-PROTON-172-refactored-Java-SSL-implementation-to-mak.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch, 0002-PROTON-172-Moved-SSL-classes-into-package-org.engine.patch Implement SSL within proton-j -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-140) [Proton-j] Add contib, examples directories
[ https://issues.apache.org/jira/browse/PROTON-140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned PROTON-140: - Assignee: Rob Godfrey (was: Keith Wall) Hi Rob, I think this one is ready to be closed? [Proton-j] Add contib, examples directories --- Key: PROTON-140 URL: https://issues.apache.org/jira/browse/PROTON-140 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Rob Godfrey Assignee: Rob Godfrey Attachments: PROTON-140.patch Per IRC chat (and prior agreement at the F2F), we should create a contrib directory under proton-j and move the current structure under a proton directory (15:42:44) chirino: I think what needs to get done is: mkdir proton-j/proton; mv proton-j/* proton-j/proton; mkdir proton-j/contrib (15:45:18) robjgodfrey: rschloming: any issues with the above? (15:46:32) rschloming: robjgodfrey: not at all, makes sense to me (15:46:57) rschloming: robjgodfrey: I should be able to update the release script to accomodate that. (15:47:09) chirino: rschloming: you probably won't need to. (15:47:20) chirino: I'll be putting a pom.xml in the proton-j dir again. (15:47:36) rschloming: chirino: even better (15:48:17) rschloming: robjgodfrey: chirino: would you expect a java examples directory to be parallel to those? (15:48:33) rschloming: robjgodfrey: chirino: e.g. proton-j/examples? (15:48:35) chirino: yeah that would make sense. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-187) Proton-j SSL implement should accept client certificate from a private key of a keypair
[
https://issues.apache.org/jira/browse/PROTON-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532211#comment-13532211
]
Keith Wall commented on PROTON-187:
---
Patch applied - Phil, can you review please?
Proton-j SSL implement should accept client certificate from a private key of
a keypair
Key: PROTON-187
URL: https://issues.apache.org/jira/browse/PROTON-187
Project: Qpid Proton
Issue Type: Bug
Components: proton-j
Reporter: Keith Wall
Assignee: Keith Wall
Work on PROTON-182 exposed the following defect in proton-j.
{noformat}
proton_tests.ssl.SslTest.test_allow_unsecured_client
java.lang.ClassCastException: java.security.KeyPair
cannot be cast to java.security.Key
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createKeyStoreFrom(SslEngineFacadeFactory.java:188)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslContext(SslEngineFacadeFactory.java:126)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslEngine(SslEngineFacadeFactory.java:94)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslEngineFacade(SslEngineFacadeFactory.java:86)
at
org.apache.qpid.proton.engine.impl.ssl.SimpleSslTransportWrapper.init(SimpleSslTransportWrapper.java:95)
at
org.apache.qpid.proton.engine.impl.ssl.SimpleSslTransportWrapper.init(SimpleSslTransportWrapper.java:84)
at
org.apache.qpid.proton.engine.impl.ssl.SslImpl$UnsecureClientAwareTransportWrapper.initTransportWrapperOnFirstIO(SslImpl.java:209)
at
org.apache.qpid.proton.engine.impl.ssl.SslImpl$UnsecureClientAwareTransportWrapper.output(SslImpl.java:175)
at
org.apache.qpid.proton.engine.impl.TransportImpl.output(TransportImpl.java:174)
at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at
org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:186)
at
org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:204)
at org.python.core.PyObject.__call__(PyObject.java:441)
{noformat}
The implementation (SslEngineFacadeFactory) currently requires that the
private key file provide a Key. It ignores that possibility that the PEM may
legitimately contain a key-pair, containing the private-key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-187) Proton-j SSL implement should accept client certificate from a private key of a keypair
[
https://issues.apache.org/jira/browse/PROTON-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall reassigned PROTON-187:
-
Assignee: Philip Harvey (was: Keith Wall)
Proton-j SSL implement should accept client certificate from a private key of
a keypair
Key: PROTON-187
URL: https://issues.apache.org/jira/browse/PROTON-187
Project: Qpid Proton
Issue Type: Bug
Components: proton-j
Reporter: Keith Wall
Assignee: Philip Harvey
Work on PROTON-182 exposed the following defect in proton-j.
{noformat}
proton_tests.ssl.SslTest.test_allow_unsecured_client
java.lang.ClassCastException: java.security.KeyPair
cannot be cast to java.security.Key
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createKeyStoreFrom(SslEngineFacadeFactory.java:188)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslContext(SslEngineFacadeFactory.java:126)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslEngine(SslEngineFacadeFactory.java:94)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslEngineFacade(SslEngineFacadeFactory.java:86)
at
org.apache.qpid.proton.engine.impl.ssl.SimpleSslTransportWrapper.init(SimpleSslTransportWrapper.java:95)
at
org.apache.qpid.proton.engine.impl.ssl.SimpleSslTransportWrapper.init(SimpleSslTransportWrapper.java:84)
at
org.apache.qpid.proton.engine.impl.ssl.SslImpl$UnsecureClientAwareTransportWrapper.initTransportWrapperOnFirstIO(SslImpl.java:209)
at
org.apache.qpid.proton.engine.impl.ssl.SslImpl$UnsecureClientAwareTransportWrapper.output(SslImpl.java:175)
at
org.apache.qpid.proton.engine.impl.TransportImpl.output(TransportImpl.java:174)
at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at
org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:186)
at
org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:204)
at org.python.core.PyObject.__call__(PyObject.java:441)
{noformat}
The implementation (SslEngineFacadeFactory) currently requires that the
private key file provide a Key. It ignores that possibility that the PEM may
legitimately contain a key-pair, containing the private-key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-187) Proton-j SSL implement should accept client certificate from a private key of a keypair
[
https://issues.apache.org/jira/browse/PROTON-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall updated PROTON-187:
--
Affects Version/s: (was: 0.2)
Proton-j SSL implement should accept client certificate from a private key of
a keypair
Key: PROTON-187
URL: https://issues.apache.org/jira/browse/PROTON-187
Project: Qpid Proton
Issue Type: Bug
Components: proton-j
Reporter: Keith Wall
Assignee: Philip Harvey
Fix For: 0.3
Work on PROTON-182 exposed the following defect in proton-j.
{noformat}
proton_tests.ssl.SslTest.test_allow_unsecured_client
java.lang.ClassCastException: java.security.KeyPair
cannot be cast to java.security.Key
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createKeyStoreFrom(SslEngineFacadeFactory.java:188)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslContext(SslEngineFacadeFactory.java:126)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslEngine(SslEngineFacadeFactory.java:94)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslEngineFacade(SslEngineFacadeFactory.java:86)
at
org.apache.qpid.proton.engine.impl.ssl.SimpleSslTransportWrapper.init(SimpleSslTransportWrapper.java:95)
at
org.apache.qpid.proton.engine.impl.ssl.SimpleSslTransportWrapper.init(SimpleSslTransportWrapper.java:84)
at
org.apache.qpid.proton.engine.impl.ssl.SslImpl$UnsecureClientAwareTransportWrapper.initTransportWrapperOnFirstIO(SslImpl.java:209)
at
org.apache.qpid.proton.engine.impl.ssl.SslImpl$UnsecureClientAwareTransportWrapper.output(SslImpl.java:175)
at
org.apache.qpid.proton.engine.impl.TransportImpl.output(TransportImpl.java:174)
at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at
org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:186)
at
org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:204)
at org.python.core.PyObject.__call__(PyObject.java:441)
{noformat}
The implementation (SslEngineFacadeFactory) currently requires that the
private key file provide a Key. It ignores that possibility that the PEM may
legitimately contain a key-pair, containing the private-key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-182) [proton-j] SSL tests fail with org.bouncycastle.openssl.PEMException: problem parsing ENCRYPTED PRIVATE KEY: java.security.InvalidKeyException: Illegal key size
[ https://issues.apache.org/jira/browse/PROTON-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532215#comment-13532215 ] Keith Wall commented on PROTON-182: --- Patch applied - Phil can you review please? [proton-j] SSL tests fail with org.bouncycastle.openssl.PEMException: problem parsing ENCRYPTED PRIVATE KEY: java.security.InvalidKeyException: Illegal key size Key: PROTON-182 URL: https://issues.apache.org/jira/browse/PROTON-182 Project: Qpid Proton Issue Type: Bug Components: proton-c, proton-j Reporter: Hiram Chirino Assignee: Philip Harvey Fix For: 0.3 Attachments: PROTON-182-II.patch, PROTON-182.patch Seems ssl keys used in the tests are too strong for the default Java impl. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532216#comment-13532216 ] Keith Wall commented on PROTON-185: --- Great, I have confirmed that this resolved my problem. cheers, Keith Can't build proton-c - undefined symbols ERR_get_error etc -- Key: PROTON-185 URL: https://issues.apache.org/jira/browse/PROTON-185 Project: Qpid Proton Issue Type: Bug Components: proton-c Environment: Red Hat Enterprise Linux Server release 5.3 (Tikanga) Reporter: Keith Wall Assignee: Andrew Stitcher Fix For: 0.3 Attachments: GITDIFF.txt As initially discussed on mail thread.. We are having problems building proton-c on our dev boxes (Red Hat Enterprise Linux Server release 5.3 (Tikanga)). I've done a git bisect and discovered that it was Andrew's commit last Wednesday (rev 1417553) that has introduced/exposed the issue. Before that point, we could build without this issue. It appears to be a link issue with openssl. The following version of openssl is installed: $rpm -q openssl openssl-0.9.8e-7.el5.x86_64 openssl-0.9.8e-7.el5.i686 Make is failing with the following (complete cmake/make output attached below) Linking C shared library libqpid-proton.so CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `_log_ssl_error': openssl.c:(.text+0x2de): undefined reference to `ERR_get_error' openssl.c:(.text+0x2ff): undefined reference to `ERR_error_string_n' openssl.c:(.text+0x31c): undefined reference to `ERR_get_error' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `ssl_failed': openssl.c:(.text+0x43f): undefined reference to `ERR_get_error' openssl.c:(.text+0x45f): undefined reference to `ERR_error_string_n' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `get_dh2048': openssl.c:(.text+0x4ac): undefined reference to `DH_new' openssl.c:(.text+0x4d7): undefined reference to `BN_bin2bn' openssl.c:(.text+0x4f8): undefined reference to `BN_bin2bn' openssl.c:(.text+0x526): undefined reference to `DH_free' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `pn_ssl_domain': openssl.c:(.text+0x71e): undefined reference to `OPENSSL_add_all_algorithms_noconf' openssl.c:(.text+0x8fd): undefined reference to `DH_free' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `pn_ssl': openssl.c:(.text+0x1979): undefined reference to `OPENSSL_add_all_algorithms_noconf' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `process_input_ssl': openssl.c:(.text+0x1cd2): undefined reference to `BIO_write' openssl.c:(.text+0x1d62): undefined reference to `BIO_ctrl' openssl.c:(.text+0x1dcf): undefined reference to `BIO_read' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `process_output_ssl': openssl.c:(.text+0x2268): undefined reference to `BIO_write' openssl.c:(.text+0x240e): undefined reference to `BIO_read' openssl.c:(.text+0x24b7): undefined reference to `BIO_ctrl' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `init_ssl_socket': openssl.c:(.text+0x26a3): undefined reference to `BIO_new' openssl.c:(.text+0x26fa): undefined reference to `BIO_ctrl' openssl.c:(.text+0x2719): undefined reference to `BIO_new_bio_pair' openssl.c:(.text+0x278f): undefined reference to `BIO_ctrl' openssl.c:(.text+0x27cf): undefined reference to `BIO_ctrl' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `release_ssl_socket': openssl.c:(.text+0x2816): undefined reference to `BIO_free' openssl.c:(.text+0x284c): undefined reference to `BIO_free' openssl.c:(.text+0x2866): undefined reference to `BIO_free' I am not able to determine the underlying cause (my C skills are ten years rusty), would someone be able to take a look and advise? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-182) [proton-j] SSL tests fail with org.bouncycastle.openssl.PEMException: problem parsing ENCRYPTED PRIVATE KEY: java.security.InvalidKeyException: Illegal key size
[ https://issues.apache.org/jira/browse/PROTON-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall resolved PROTON-182. --- Resolution: Fixed [proton-j] SSL tests fail with org.bouncycastle.openssl.PEMException: problem parsing ENCRYPTED PRIVATE KEY: java.security.InvalidKeyException: Illegal key size Key: PROTON-182 URL: https://issues.apache.org/jira/browse/PROTON-182 Project: Qpid Proton Issue Type: Bug Components: proton-c, proton-j Reporter: Hiram Chirino Assignee: Keith Wall Fix For: 0.3 Attachments: PROTON-182-II.patch, PROTON-182.patch Seems ssl keys used in the tests are too strong for the default Java impl. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-187) Proton-j SSL implement should accept client certificate from a private key of a keypair
[
https://issues.apache.org/jira/browse/PROTON-187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keith Wall resolved PROTON-187.
---
Resolution: Fixed
Proton-j SSL implement should accept client certificate from a private key of
a keypair
Key: PROTON-187
URL: https://issues.apache.org/jira/browse/PROTON-187
Project: Qpid Proton
Issue Type: Bug
Components: proton-j
Reporter: Keith Wall
Assignee: Philip Harvey
Fix For: 0.3
Work on PROTON-182 exposed the following defect in proton-j.
{noformat}
proton_tests.ssl.SslTest.test_allow_unsecured_client
java.lang.ClassCastException: java.security.KeyPair
cannot be cast to java.security.Key
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createKeyStoreFrom(SslEngineFacadeFactory.java:188)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslContext(SslEngineFacadeFactory.java:126)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslEngine(SslEngineFacadeFactory.java:94)
at
org.apache.qpid.proton.engine.impl.ssl.SslEngineFacadeFactory.createSslEngineFacade(SslEngineFacadeFactory.java:86)
at
org.apache.qpid.proton.engine.impl.ssl.SimpleSslTransportWrapper.init(SimpleSslTransportWrapper.java:95)
at
org.apache.qpid.proton.engine.impl.ssl.SimpleSslTransportWrapper.init(SimpleSslTransportWrapper.java:84)
at
org.apache.qpid.proton.engine.impl.ssl.SslImpl$UnsecureClientAwareTransportWrapper.initTransportWrapperOnFirstIO(SslImpl.java:209)
at
org.apache.qpid.proton.engine.impl.ssl.SslImpl$UnsecureClientAwareTransportWrapper.output(SslImpl.java:175)
at
org.apache.qpid.proton.engine.impl.TransportImpl.output(TransportImpl.java:174)
at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:601)
at
org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:186)
at
org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:204)
at org.python.core.PyObject.__call__(PyObject.java:441)
{noformat}
The implementation (SslEngineFacadeFactory) currently requires that the
private key file provide a Key. It ignores that possibility that the PEM may
legitimately contain a key-pair, containing the private-key.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc
Keith Wall created PROTON-185: - Summary: Can't build proton-c - undefined symbols ERR_get_error etc Key: PROTON-185 URL: https://issues.apache.org/jira/browse/PROTON-185 Project: Qpid Proton Issue Type: Bug Components: proton-c Environment: Red Hat Enterprise Linux Server release 5.3 (Tikanga) Reporter: Keith Wall Assignee: Andrew Stitcher As initially discussed on mail thread.. We are having problems building proton-c on our dev boxes (Red Hat Enterprise Linux Server release 5.3 (Tikanga)). I've done a git bisect and discovered that it was Andrew's commit last Wednesday (rev 1417553) that has introduced/exposed the issue. Before that point, we could build without this issue. It appears to be a link issue with openssl. The following version of openssl is installed: $rpm -q openssl openssl-0.9.8e-7.el5.x86_64 openssl-0.9.8e-7.el5.i686 Make is failing with the following (complete cmake/make output attached below) Linking C shared library libqpid-proton.so CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `_log_ssl_error': openssl.c:(.text+0x2de): undefined reference to `ERR_get_error' openssl.c:(.text+0x2ff): undefined reference to `ERR_error_string_n' openssl.c:(.text+0x31c): undefined reference to `ERR_get_error' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `ssl_failed': openssl.c:(.text+0x43f): undefined reference to `ERR_get_error' openssl.c:(.text+0x45f): undefined reference to `ERR_error_string_n' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `get_dh2048': openssl.c:(.text+0x4ac): undefined reference to `DH_new' openssl.c:(.text+0x4d7): undefined reference to `BN_bin2bn' openssl.c:(.text+0x4f8): undefined reference to `BN_bin2bn' openssl.c:(.text+0x526): undefined reference to `DH_free' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `pn_ssl_domain': openssl.c:(.text+0x71e): undefined reference to `OPENSSL_add_all_algorithms_noconf' openssl.c:(.text+0x8fd): undefined reference to `DH_free' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `pn_ssl': openssl.c:(.text+0x1979): undefined reference to `OPENSSL_add_all_algorithms_noconf' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `process_input_ssl': openssl.c:(.text+0x1cd2): undefined reference to `BIO_write' openssl.c:(.text+0x1d62): undefined reference to `BIO_ctrl' openssl.c:(.text+0x1dcf): undefined reference to `BIO_read' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `process_output_ssl': openssl.c:(.text+0x2268): undefined reference to `BIO_write' openssl.c:(.text+0x240e): undefined reference to `BIO_read' openssl.c:(.text+0x24b7): undefined reference to `BIO_ctrl' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `init_ssl_socket': openssl.c:(.text+0x26a3): undefined reference to `BIO_new' openssl.c:(.text+0x26fa): undefined reference to `BIO_ctrl' openssl.c:(.text+0x2719): undefined reference to `BIO_new_bio_pair' openssl.c:(.text+0x278f): undefined reference to `BIO_ctrl' openssl.c:(.text+0x27cf): undefined reference to `BIO_ctrl' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `release_ssl_socket': openssl.c:(.text+0x2816): undefined reference to `BIO_free' openssl.c:(.text+0x284c): undefined reference to `BIO_free' openssl.c:(.text+0x2866): undefined reference to `BIO_free' I am not able to determine the underlying cause (my C skills are ten years rusty), would someone be able to take a look and advise? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-185) Can't build proton-c - undefined symbols ERR_get_error etc
[ https://issues.apache.org/jira/browse/PROTON-185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530146#comment-13530146 ] Keith Wall commented on PROTON-185: --- The further requested details: Could you run make VERBOSE=1 and post the final link line (only). /usr/bin/cmake -E cmake_link_script CMakeFiles/qpid-proton.dir/link.txt --verbose=1 /usr/bin/gcc -fPIC -Wl,--no-undefined -shared -Wl,-soname,libqpid-proton.so.1 -o libqpid-proton.so.1.0.0 CMakeFiles/qpid-proton.dir/src/util.c.o CMakeFiles/qpid-proton.dir/src/error.c.o CMakeFiles/qpid-proton.dir/src/buffer.c.o CMakeFiles/qpid-proton.dir/src/parser.c.o CMakeFiles/qpid-proton.dir/src/scanner.c.o CMakeFiles/qpid-proton.dir/src/types.c.o CMakeFiles/qpid-proton.dir/src/framing/framing.c.o CMakeFiles/qpid-proton.dir/src/codec/codec.c.o CMakeFiles/qpid-proton.dir/src/dispatcher/dispatcher.c.o CMakeFiles/qpid-proton.dir/src/engine/engine.c.o CMakeFiles/qpid-proton.dir/src/message/message.c.o CMakeFiles/qpid-proton.dir/src/sasl/sasl.c.o CMakeFiles/qpid-proton.dir/src/messenger.c.o CMakeFiles/qpid-proton.dir/src/driver.c.o CMakeFiles/qpid-proton.dir/src/platform.c.o CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o -luuid -lssl -lrt CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `_log_ssl_error': openssl.c:(.text+0x2de): undefined reference to `ERR_get_error' openssl.c:(.text+0x2ff): undefined reference to `ERR_error_string_n' Another useful datapoint would be to build with the above flag and then post the results of ldd libqpid-proton.so. ldd libqpid-proton.so libuuid.so.1 = /lib64/libuuid.so.1 (0x2b00ebce6000) libssl.so.6 = /lib64/libssl.so.6 (0x2b00ebeea000) librt.so.1 = /lib64/librt.so.1 (0x2b00ec134000) libc.so.6 = /lib64/libc.so.6 (0x2b00ec33e000) /lib64/ld-linux-x86-64.so.2 (0x003f8600) libgssapi_krb5.so.2 = /usr/lib64/libgssapi_krb5.so.2 (0x2b00ec694000) libkrb5.so.3 = /usr/lib64/libkrb5.so.3 (0x2b00ec8c2000) libcom_err.so.2 = /lib64/libcom_err.so.2 (0x2b00ecb58000) libk5crypto.so.3 = /usr/lib64/libk5crypto.so.3 (0x2b00ecd5a000) libcrypto.so.6 = /lib64/libcrypto.so.6 (0x2b00ecf7f000) libdl.so.2 = /lib64/libdl.so.2 (0x2b00ed2d1000) libz.so.1 = /usr/lib64/libz.so.1 (0x2b00ed4d5000) libpthread.so.0 = /lib64/libpthread.so.0 (0x2b00ed6e9000) libkrb5support.so.0 = /usr/lib64/libkrb5support.so.0 (0x2b00ed905000) libkeyutils.so.1 = /lib64/libkeyutils.so.1 (0x2b00edb0d000) libresolv.so.2 = /lib64/libresolv.so.2 (0x2b00edd0f000) libselinux.so.1 = /lib64/libselinux.so.1 (0x2b00edf25000) libsepol.so.1 = /lib64/libsepol.so.1 (0x2b00ee13d000) Can't build proton-c - undefined symbols ERR_get_error etc -- Key: PROTON-185 URL: https://issues.apache.org/jira/browse/PROTON-185 Project: Qpid Proton Issue Type: Bug Components: proton-c Environment: Red Hat Enterprise Linux Server release 5.3 (Tikanga) Reporter: Keith Wall Assignee: Andrew Stitcher As initially discussed on mail thread.. We are having problems building proton-c on our dev boxes (Red Hat Enterprise Linux Server release 5.3 (Tikanga)). I've done a git bisect and discovered that it was Andrew's commit last Wednesday (rev 1417553) that has introduced/exposed the issue. Before that point, we could build without this issue. It appears to be a link issue with openssl. The following version of openssl is installed: $rpm -q openssl openssl-0.9.8e-7.el5.x86_64 openssl-0.9.8e-7.el5.i686 Make is failing with the following (complete cmake/make output attached below) Linking C shared library libqpid-proton.so CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `_log_ssl_error': openssl.c:(.text+0x2de): undefined reference to `ERR_get_error' openssl.c:(.text+0x2ff): undefined reference to `ERR_error_string_n' openssl.c:(.text+0x31c): undefined reference to `ERR_get_error' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `ssl_failed': openssl.c:(.text+0x43f): undefined reference to `ERR_get_error' openssl.c:(.text+0x45f): undefined reference to `ERR_error_string_n' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `get_dh2048': openssl.c:(.text+0x4ac): undefined reference to `DH_new' openssl.c:(.text+0x4d7): undefined reference to `BN_bin2bn' openssl.c:(.text+0x4f8): undefined reference to `BN_bin2bn' openssl.c:(.text+0x526): undefined reference to `DH_free' CMakeFiles/qpid-proton.dir/src/ssl/openssl.c.o: In function `pn_ssl_domain': openssl.c:(.text+0x71e): undefined reference to `OPENSSL_add_all_algorithms_noconf' openssl.c:(.text+0x8fd): undefined reference to
[jira] [Commented] (PROTON-136) Add support for SSL session resumption
[ https://issues.apache.org/jira/browse/PROTON-136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13530150#comment-13530150 ] Keith Wall commented on PROTON-136: --- Phil, patch applied. Add support for SSL session resumption -- Key: PROTON-136 URL: https://issues.apache.org/jira/browse/PROTON-136 Project: Qpid Proton Issue Type: New Feature Components: proton-c Affects Versions: 0.3 Reporter: Affan Dar Assignee: Ken Giusti Labels: ssl, sslContext, sslresume Attachments: PROTON-136-initial-Java-and-Python.tgz, ssl-patches-20121212.tar.gz Open SSL supports resumption of SSL sessions which by-pass the heavy SSL handshake process. This is critical for scenarios involving low powered devices especially on cellular data networks where bandwidth is precious. It would be great if Proton exposes this ssl resume feature to users. . From: rhs [mailto:rschlom...@gmail.com] Sent: Tuesday, November 13, 2012 11:34 AM To: Affan Dar Cc: David Ingham Subject: Re: SSL session resumption On Tue, Nov 13, 2012 at 8:05 PM, Affan Dar affan...@microsoft.com wrote: Serializing/restoring the whole session state for the messenger will work for the scenario I think. Ok, let's start with this step then. I'm open to providing something finer grained if there is a need, but my preference is to keep it simple for the moment. One more thing, RFC 5077 has another flavor of session resumption which openssl supports (original implemented as RFC 4057 back in 2007 I think). This allows us to resume sessions without carrying state on the server side which as you can imagine is a big deal for service vendors. Probably there is no API level impact if messenger handles the session state itself but just wanted to put this on your radar. Ok, good to know. Could one of you file a JIRA for this upstream? I'm trying to get things a little more organized on the process front and keep everything centralized in JIRA. ;-) --Rafael -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-172) Implement SSL within proton-j
[ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall reassigned PROTON-172: - Assignee: Keith Wall (was: Philip Harvey) Implement SSL within proton-j - Key: PROTON-172 URL: https://issues.apache.org/jira/browse/PROTON-172 Project: Qpid Proton Issue Type: New Feature Components: proton-j Reporter: Philip Harvey Assignee: Keith Wall Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch Implement SSL within proton-j -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-172) Implement SSL within proton-j
[ https://issues.apache.org/jira/browse/PROTON-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13506436#comment-13506436 ] Keith Wall commented on PROTON-172: --- First patch applied (0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch) Implement SSL within proton-j - Key: PROTON-172 URL: https://issues.apache.org/jira/browse/PROTON-172 Project: Qpid Proton Issue Type: New Feature Components: proton-j Reporter: Philip Harvey Assignee: Keith Wall Attachments: 0001-PROTON-172-Java-SSL-implementation-enable-system-tes.patch, 0002-PROTON-172-Extra-tests-and-enhanced-pump-method.patch Implement SSL within proton-j -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
