[jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-10-10 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166732#comment-14166732 ] ASF subversion and git services commented on PROTON-640: Commit

Re: [jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-11 Thread Cliff Jansen
Hi Bozzo, Please take a look at PROTON-668 and confirm none of the assumptions are counter to your usage, especially whether you fit scenario 3 and do not have problems with the proposed restriction to pn_pipe. If this is OK for you, I think I am close to a fix that will work for you. Cliff On

Re: [jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-10 Thread Bozo Dragojevic
Hi Cliff, I agree that the current extra API call is kludgy if not downright ugly. I noticed today you already added a new API call pn_io_selector(), which has separate windows and posix implementations. For short term 'fix', I'd propose to hide my hack inthere -- make calling pn_io_selector()

Re: [jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-08 Thread Cliff Jansen
Ho Bozo, Thank you for comments and the suggested patch. I would prefer a solution that did not have a special Windows-only-sometimes call pn_io_no_iocp(). It seems to me anyway that there is another class of sockets that are pulled into an IOCP context too early, so that a separate solution is

Re: [jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-05 Thread Bozo Dragojevic
Hi Cliff, On 4. 09. 14 20:03, Cliff Jansen wrote: Hi, I am not sure what you are trying to do with xdispatch. Exactly the same idea as contrib/proton-hawtdispatch, but in C. If you are using and external loop and managing your own IO, you can bypass the low level Proton IO primitives and

Re: [jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-05 Thread Bozo Dragojevic
On 5. 09. 14 11:53, Bozo Dragojevic wrote: The patch is a bit rough - not sure I really like the name pn_io_no_iocp() - missing non-windows stub for pn_io_no_iocp() - it most likely handles the selector access wrong (see XXX comment) I missed this bit (blush) diff --git

Re: [jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-04 Thread Bozo Dragojevic
Hi! Just a headsup. This commit breaks pn_accept() for me, it fails all the time. I'm not using selectors but drive the socket with libdispatch (from xdispatch) with a custom driver. If I revert this commit the trunk is useable. I'll dig deeper what is going on, I was focusing on getting SSL

Re: [jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-04 Thread Cliff Jansen
Hi, I am not sure what you are trying to do with xdispatch. If you are using and external loop and managing your own IO, you can bypass the low level Proton IO primitives and access the proton engine directly. This is how Qpid uses Proton. If you were using the driver.c mechanism, please take a

[jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-04 Thread Cliff Jansen (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14121813#comment-14121813 ] Cliff Jansen commented on PROTON-640: - from https://reviews.apache.org/r/24159 This

Re: [jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-04 Thread Rafael Schloming
Hi Bozo, I closed the JIRA before I noticed your issue. Please feel free to reopen it if your investigations turns up any problems with it. --Rafael On Thu, Sep 4, 2014 at 11:33 AM, Bozo Dragojevic bo...@digiverse.si wrote: Hi! Just a headsup. This commit breaks pn_accept() for me, it

[jira] [Commented] (PROTON-640) IO completion port Windows IO for Proton

2014-09-03 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120849#comment-14120849 ] ASF subversion and git services commented on PROTON-640: Commit