[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-10-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166768#comment-14166768
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1630836 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630836 ]

PROTON-693: Python Url class to wrap C function pni_parse_url

It was pointed out that pni_parse_url is an internal function and the interface
is not suitable for public API.

Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the
need for previous swig insanity and is cleaner all round.

Internally still uses the pni_parse_url parser, we can clean that up later.

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-10-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166766#comment-14166766
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1630834 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630834 ]

PROTON-693: Python Url class to wrap C function pni_parse_url

Also added unit tests.

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-10-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166769#comment-14166769
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1630837 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630837 ]

PROTON-693: Fix for windows build

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-10-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166774#comment-14166774
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1630842 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630842 ]

PROTON-693: Implement C-API wrappers in Java for jython, clean up Url 
implementation.

- Java implementation of fake C API for Jython SWIG wrappers based on 
messenger.impl.Address.
- Minor extensions to Address.java
- Minor change to Address.java to be consistent with C parser on one corner 
case:
  - is url(/foo) a host called /foo or an empty host and a path foo
  - fixed Java parser to agree with C - path foo
- Rename getters from url_* to url_get_*.
- Use pn_string_t formatting functions to build URL string.

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-10-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166779#comment-14166779
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1630848 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630848 ]

PROTON-693: Make pn_url_t a proper pn_class object, hashable  comparable.

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-10-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166782#comment-14166782
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1630850 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630850 ]

PROTON-693: Export pn_url... symbols as C not C++

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-10-10 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166803#comment-14166803
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1630873 from [~gsim] in branch 'proton/branches/examples'
[ https://svn.apache.org/r1630873 ]

PROTON-693: If the system doesn't have port definitions for amqp/amqps
use the default values of 5672/5671.
- Not all systems have /etc/service (or similar) files that define
  these ports, but our tests use them and the defaults are these
  strings.

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-09-29 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14152286#comment-14152286
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1628315 from [~astitcher] in branch 'proton/trunk'
[ https://svn.apache.org/r1628315 ]

PROTON-693: If the system doesn't have port definitions for amqp/amqps
use the default values of 5672/5671.
- Not all systems have /etc/service (or similar) files that define
  these ports, but our tests use them and the defaults are these
  strings.

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-09-23 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145002#comment-14145002
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1627086 from [~aconway] in branch 'proton/trunk'
[ https://svn.apache.org/r1627086 ]

PROTON-693: Implement C-API wrappers in Java for jython, clean up Url 
implementation.

- Java implementation of fake C API for Jython SWIG wrappers based on 
messenger.impl.Address.
- Minor extensions to Address.java
- Minor change to Address.java to be consistent with C parser on one corner 
case:
  - is url(/foo) a host called /foo or an empty host and a path foo
  - fixed Java parser to agree with C - path foo
- Rename getters from url_* to url_get_*.
- Use pn_string_t formatting functions to build URL string.

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-09-23 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145380#comment-14145380
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1627155 from [~aconway] in branch 'proton/trunk'
[ https://svn.apache.org/r1627155 ]

PROTON-693: Make pn_url_t a proper pn_class object, hashable  comparable.

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-09-23 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145932#comment-14145932
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1627222 from [~astitcher] in branch 'proton/trunk'
[ https://svn.apache.org/r1627222 ]

PROTON-693: Export pn_url... symbols as C not C++

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-09-22 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14143542#comment-14143542
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1626861 from [~astitcher] in branch 'proton/trunk'
[ https://svn.apache.org/r1626861 ]

PROTON-693: Fix for windows build

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (PROTON-693) Python Url class to wrap C function pni_parse_url

2014-09-19 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14141290#comment-14141290
 ] 

ASF subversion and git services commented on PROTON-693:


Commit 1626329 from [~aconway] in branch 'proton/trunk'
[ https://svn.apache.org/r1626329 ]

PROTON-693: Python Url class to wrap C function pni_parse_url

It was pointed out that pni_parse_url is an internal function and the interface
is not suitable for public API.

Rewrote the URL parser as a proper swigable C API pn_url_*. This gets rid of the
need for previous swig insanity and is cleaner all round.

Internally still uses the pni_parse_url parser, we can clean that up later.

 Python Url class to wrap C function pni_parse_url
 -

 Key: PROTON-693
 URL: https://issues.apache.org/jira/browse/PROTON-693
 Project: Qpid Proton
  Issue Type: Improvement
  Components: python-binding
Affects Versions: 0.8
Reporter: Alan Conway
Assignee: Alan Conway
 Fix For: 0.8


 Add a Url class to the python binding that wraps the C function pni_url_parse.
 Also added unit tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)