[jira] [Commented] (PROTON-850) inconsistent state when reusing link name
[ https://issues.apache.org/jira/browse/PROTON-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14512670#comment-14512670 ] ASF subversion and git services commented on PROTON-850: Commit 1b1c07d1c23d2471b6b85476d29e777cd25fddab in qpid-proton's branch refs/heads/0.9.x from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1b1c07d ] PROTON-853: add a test that catches the issue from PROTON-154 (and PROTON-850) (cherry picked from commit 252f5f0c1a3cb50edac7813eb233a37697e1f2ab) inconsistent state when reusing link name - Key: PROTON-850 URL: https://issues.apache.org/jira/browse/PROTON-850 Project: Qpid Proton Issue Type: Bug Components: proton-c, python-binding Affects Versions: 0.9 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: 0.10 Attachments: PROTON_850.py If a link is closed, and a new link with the same name is created and opened, the attach received for the second link from the peer is applied to the old link. If the old link is freed after being closed, this is avoided, but I'm not sure that is possible via e.g. the python bindings. The root of the problem I think is that a handle is reused after the link is closed, whether freed or not, but when processing an incoming attach, it is the link name that is used to find the appropriate link, which iterates through all links until it matches one by name, which in this case is the old, closed link. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-850) inconsistent state when reusing link name
[ https://issues.apache.org/jira/browse/PROTON-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511213#comment-14511213 ] ASF subversion and git services commented on PROTON-850: Commit acd1e1c9a582aaf190bb32ebc5bd9e590bd71930 in qpid-proton's branch refs/heads/0.9.x from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=acd1e1c ] PROTON-853: add a test that catches the issue from PROTON-154 (and PROTON-850) (cherry picked from commit 252f5f0c1a3cb50edac7813eb233a37697e1f2ab) inconsistent state when reusing link name - Key: PROTON-850 URL: https://issues.apache.org/jira/browse/PROTON-850 Project: Qpid Proton Issue Type: Bug Components: proton-c, python-binding Affects Versions: 0.9 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: 0.10 Attachments: PROTON_850.py If a link is closed, and a new link with the same name is created and opened, the attach received for the second link from the peer is applied to the old link. If the old link is freed after being closed, this is avoided, but I'm not sure that is possible via e.g. the python bindings. The root of the problem I think is that a handle is reused after the link is closed, whether freed or not, but when processing an incoming attach, it is the link name that is used to find the appropriate link, which iterates through all links until it matches one by name, which in this case is the old, closed link. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-850) inconsistent state when reusing link name
[ https://issues.apache.org/jira/browse/PROTON-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14511215#comment-14511215 ] ASF subversion and git services commented on PROTON-850: Commit 7fa680794b7d78906129216471170dc7d720b156 in qpid-proton's branch refs/heads/0.9.x from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=7fa6807 ] PROTON-853: dont return the cached links if they are already in the closed state, instead create a new object and ensure the old links also get freed. Also fixes similar behaviour as in PROTON-850. This closes #21 (cherry picked from commit f2d7d669155a2ca57606c9381f4f1720739be79b) inconsistent state when reusing link name - Key: PROTON-850 URL: https://issues.apache.org/jira/browse/PROTON-850 Project: Qpid Proton Issue Type: Bug Components: proton-c, python-binding Affects Versions: 0.9 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: 0.10 Attachments: PROTON_850.py If a link is closed, and a new link with the same name is created and opened, the attach received for the second link from the peer is applied to the old link. If the old link is freed after being closed, this is avoided, but I'm not sure that is possible via e.g. the python bindings. The root of the problem I think is that a handle is reused after the link is closed, whether freed or not, but when processing an incoming attach, it is the link name that is used to find the appropriate link, which iterates through all links until it matches one by name, which in this case is the old, closed link. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-850) inconsistent state when reusing link name
[ https://issues.apache.org/jira/browse/PROTON-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507479#comment-14507479 ] ASF subversion and git services commented on PROTON-850: Commit fd26ec66bcd1fda328ceca119efc43bf787e0bcf in qpid-proton's branch refs/heads/master from [~gsim] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=fd26ec6 ] PROTON-850: ensure attach updates correct link object inconsistent state when reusing link name - Key: PROTON-850 URL: https://issues.apache.org/jira/browse/PROTON-850 Project: Qpid Proton Issue Type: Bug Components: proton-c, python-binding Affects Versions: 0.9 Reporter: Gordon Sim Attachments: PROTON_850.py If a link is closed, and a new link with the same name is created and opened, the attach received for the second link from the peer is applied to the old link. If the old link is freed after being closed, this is avoided, but I'm not sure that is possible via e.g. the python bindings. The root of the problem I think is that a handle is reused after the link is closed, whether freed or not, but when processing an incoming attach, it is the link name that is used to find the appropriate link, which iterates through all links until it matches one by name, which in this case is the old, closed link. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-850) inconsistent state when reusing link name
[ https://issues.apache.org/jira/browse/PROTON-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507623#comment-14507623 ] ASF subversion and git services commented on PROTON-850: Commit f2d7d669155a2ca57606c9381f4f1720739be79b in qpid-proton's branch refs/heads/master from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f2d7d66 ] PROTON-853: dont return the cached links if they are already in the closed state, instead create a new object and ensure the old links also get freed. Also fixes similar behaviour as in PROTON-850. This closes #21 inconsistent state when reusing link name - Key: PROTON-850 URL: https://issues.apache.org/jira/browse/PROTON-850 Project: Qpid Proton Issue Type: Bug Components: proton-c, python-binding Affects Versions: 0.9 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: 0.10 Attachments: PROTON_850.py If a link is closed, and a new link with the same name is created and opened, the attach received for the second link from the peer is applied to the old link. If the old link is freed after being closed, this is avoided, but I'm not sure that is possible via e.g. the python bindings. The root of the problem I think is that a handle is reused after the link is closed, whether freed or not, but when processing an incoming attach, it is the link name that is used to find the appropriate link, which iterates through all links until it matches one by name, which in this case is the old, closed link. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-850) inconsistent state when reusing link name
[ https://issues.apache.org/jira/browse/PROTON-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507621#comment-14507621 ] ASF subversion and git services commented on PROTON-850: Commit 252f5f0c1a3cb50edac7813eb233a37697e1f2ab in qpid-proton's branch refs/heads/master from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=252f5f0 ] PROTON-853: add a test that catches the issue from PROTON-154 (and PROTON-850) inconsistent state when reusing link name - Key: PROTON-850 URL: https://issues.apache.org/jira/browse/PROTON-850 Project: Qpid Proton Issue Type: Bug Components: proton-c, python-binding Affects Versions: 0.9 Reporter: Gordon Sim Assignee: Gordon Sim Fix For: 0.10 Attachments: PROTON_850.py If a link is closed, and a new link with the same name is created and opened, the attach received for the second link from the peer is applied to the old link. If the old link is freed after being closed, this is avoided, but I'm not sure that is possible via e.g. the python bindings. The root of the problem I think is that a handle is reused after the link is closed, whether freed or not, but when processing an incoming attach, it is the link name that is used to find the appropriate link, which iterates through all links until it matches one by name, which in this case is the old, closed link. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-850) inconsistent state when reusing link name
[ https://issues.apache.org/jira/browse/PROTON-850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14499658#comment-14499658 ] Gordon Sim commented on PROTON-850: --- Proposed fix: https://reviews.apache.org/r/33300/ inconsistent state when reusing link name - Key: PROTON-850 URL: https://issues.apache.org/jira/browse/PROTON-850 Project: Qpid Proton Issue Type: Bug Components: proton-c, python-binding Affects Versions: 0.9 Reporter: Gordon Sim Attachments: PROTON_850.py If a link is closed, and a new link with the same name is created and opened, the attach received for the second link from the peer is applied to the old link. If the old link is freed after being closed, this is avoided, but I'm not sure that is possible via e.g. the python bindings. The root of the problem I think is that a handle is reused after the link is closed, whether freed or not, but when processing an incoming attach, it is the link name that is used to find the appropriate link, which iterates through all links until it matches one by name, which in this case is the old, closed link. -- This message was sent by Atlassian JIRA (v6.3.4#6332)