Re: Request for inclusion in 0.12.0

[Andrew Stitcher]

I've approved both of these for inclusion (in the JIRAs).

Andrew

On Thu, 2016-01-28 at 11:04 +, Robbie Gemmell wrote:
> Hi Justin,
> 
> I'd like to request the following for inclusion in 0.12.0:
> 
> Stop the proton-j transport from erroneously emitting various frame
> types after a Close was sent.
> https://issues.apache.org/jira/browse/PROTON-1114
> https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=bcd08cc
> 
> Some minor readme/pom changes around describing running the python
> tests.
> https://issues.apache.org/jira/browse/PROTON-1113
> https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f11723c
> 
> Thanks,
> Robbie

Re: Request for inclusion in 0.12.0

[Justin Ross]

Thanks, Robbie and Andrew.  All set.

On Fri, Jan 29, 2016 at 9:21 AM, Andrew Stitcher 
wrote:

> I've approved both of these for inclusion (in the JIRAs).
>
> Andrew
>
> On Thu, 2016-01-28 at 11:04 +, Robbie Gemmell wrote:
> > Hi Justin,
> >
> > I'd like to request the following for inclusion in 0.12.0:
> >
> > Stop the proton-j transport from erroneously emitting various frame
> > types after a Close was sent.
> > https://issues.apache.org/jira/browse/PROTON-1114
> > https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=bcd08cc
> >
> > Some minor readme/pom changes around describing running the python
> > tests.
> > https://issues.apache.org/jira/browse/PROTON-1113
> > https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f11723c
> >
> > Thanks,
> > Robbie
>

Re: Request for inclusion in 0.12.0

[Robbie Gemmell]

Thanks Justin, Andrew.

Changes merged and a new 0.12.0-SNAPSHOT published (once I realised I
forgot to update the version on the branch.. ;p )

Robbie

On 29 January 2016 at 17:24, Justin Ross  wrote:
> Thanks, Robbie and Andrew.  All set.
>
> On Fri, Jan 29, 2016 at 9:21 AM, Andrew Stitcher 
> wrote:
>
>> I've approved both of these for inclusion (in the JIRAs).
>>
>> Andrew
>>
>> On Thu, 2016-01-28 at 11:04 +, Robbie Gemmell wrote:
>> > Hi Justin,
>> >
>> > I'd like to request the following for inclusion in 0.12.0:
>> >
>> > Stop the proton-j transport from erroneously emitting various frame
>> > types after a Close was sent.
>> > https://issues.apache.org/jira/browse/PROTON-1114
>> > https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=bcd08cc
>> >
>> > Some minor readme/pom changes around describing running the python
>> > tests.
>> > https://issues.apache.org/jira/browse/PROTON-1113
>> > https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f11723c
>> >
>> > Thanks,
>> > Robbie
>>

Request for inclusion in 0.12.0: PROTON-1095: c++: connection_engine error handling, get rid of exceptions.

[Alan Conway]

Request to include the following commit in 0.12.0 as part of PROTON-
1095. I thought it already was approved but lets make extra sure:

Commit 9c03b28b0e3865aa892f0fa79650bd6c25759a22 in qpid-proton's branch
refs/heads/master from Alan Conway
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=9c03b28 ]

PROTON-1095: c++: connection_engine error handling, get rid of
exceptions.

Engine no longer throws any exceptions itself, all connections and
transport
errors are reported to the handler which can choose to throw or not.
This is consistent with error handling for the Container.

Added condition::empty()
Removed process_nothrow
Removed disconnect
Return pair from io_read rather than throwing on stream
close.

Request for inclusion in 0.12.0

[Robbie Gemmell]

Hi Justin,

I'd like to request the following for inclusion in 0.12.0:

Stop the proton-j transport from erroneously emitting various frame
types after a Close was sent.
https://issues.apache.org/jira/browse/PROTON-1114
https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=bcd08cc

Some minor readme/pom changes around describing running the python tests.
https://issues.apache.org/jira/browse/PROTON-1113
https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f11723c

Thanks,
Robbie

Request for inclusion in 0.12.0 beta

[Robbie Gemmell]

Hi Justin,

I see you have created the 0.12.x branch, but before you actually spin
the beta, could I request the following...

The latest commit on https://issues.apache.org/jira/browse/PROTON-1100
didnt make the branch.
https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6422e24

Also since its a similarly trivial if check expansion but of more real
world use, can I separately request:
https://issues.apache.org/jira/browse/PROTON-1110

Thanks,
Robbie

Re: Request for inclusion in 0.12.0 beta

[Justin Ross]

Thanks, Robbie.  Both are approved.


On Tue, Jan 26, 2016 at 6:10 AM, Robbie Gemmell 
wrote:

> Hi Justin,
>
> I see you have created the 0.12.x branch, but before you actually spin
> the beta, could I request the following...
>
> The latest commit on https://issues.apache.org/jira/browse/PROTON-1100
> didnt make the branch.
> https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6422e24
>
> Also since its a similarly trivial if check expansion but of more real
> world use, can I separately request:
> https://issues.apache.org/jira/browse/PROTON-1110
>
> Thanks,
> Robbie
>

Re: Request for inclusion in 0.12.0 beta

[Robbie Gemmell]

Great, thanks Justin. Both changes are now picked onto the 0.12.x branch.

Robbie

On 26 January 2016 at 14:16, Justin Ross  wrote:
> Thanks, Robbie.  Both are approved.
>
>
> On Tue, Jan 26, 2016 at 6:10 AM, Robbie Gemmell 
> wrote:
>
>> Hi Justin,
>>
>> I see you have created the 0.12.x branch, but before you actually spin
>> the beta, could I request the following...
>>
>> The latest commit on https://issues.apache.org/jira/browse/PROTON-1100
>> didnt make the branch.
>> https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6422e24
>>
>> Also since its a similarly trivial if check expansion but of more real
>> world use, can I separately request:
>> https://issues.apache.org/jira/browse/PROTON-1110
>>
>> Thanks,
>> Robbie
>>