[ https://issues.apache.org/jira/browse/PROTON-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14056353#comment-14056353 ]
Robbie Gemmell commented on PROTON-576: --------------------------------------- I had a quick look at the patch, my only comment/question would be around the Surrogate Pair checking, which it would do for essentially every character pair it can. If I'm interpreting it correctly it seems like that isn't necessary a lot of the time. Perhaps it could be deferred until it becomes necessary to check? I see the earlier comments had some benchmarking comparisons. Out of interest, was any comparison made with the updated patch? > proton-j: codec support for UTF-8 encoding and decoding appears broken? > ----------------------------------------------------------------------- > > Key: PROTON-576 > URL: https://issues.apache.org/jira/browse/PROTON-576 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j > Affects Versions: 0.7 > Reporter: Dominic Evans > Attachments: 02_fix_stringtype_encode_decode.patch > > > It seems like Proton-J has its own custom UTF-8 encoder, but relies on Java > String's built-in UTF-8 decoder. However, the code doesn't seem quite right > and complex double byte UTF-8 like emoji ('📔🚢🍛🍴🍹🏊🏄') can quite easily fail to > parse: > | | Cause:1 :- java.lang.IllegalArgumentException: Cannot parse > String > | | Message:1 :- Cannot parse String > | | StackTrace:1 :- java.lang.IllegalArgumentException: Cannot parse > String > | | at > org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:48) > | | at > org.apache.qpid.proton.codec.StringType$1.decode(StringType.java:36) > | | at > org.apache.qpid.proton.codec.DecoderImpl.readRaw(DecoderImpl.java:945) > | | at > org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:172) > | | at > org.apache.qpid.proton.codec.StringType$AllStringEncoding.readValue(StringType.java:124) > | | at > org.apache.qpid.proton.codec.DynamicTypeConstructor.readValue(DynamicTypeConstructor.java:39) > | | at > org.apache.qpid.proton.codec.DecoderImpl.readObject(DecoderImpl.java:885) > | | at > org.apache.qpid.proton.message.impl.MessageImpl.decode(MessageImpl.java:629) -- This message was sent by Atlassian JIRA (v6.2#6252)