[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/27#issuecomment-100817820 OK I'm happy. Merged :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/27#issuecomment-100289485 I couldn't agree more. Actually all calls should have their result checked. After all malloc/realloc are not more important than pb_buffer and all the constructors or other APIs. Unfortunately doing all of it in one sweep is not really sustainable, so I thought it would be a good idea to start somewhere. I'd love to send more PRs like this to finish dealing with malloc/realloc and then move higher to ensuring that each unit checks returns of the functions it calls. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/27#issuecomment-99380746 @dcristoloveanu I'd be happy to merge these changes in for you as it is certainly better for the library not to segfault if a malloc fails. However, I do wonder if there are numerous places where these methods are currently called and expected to always be non-NULL. For example, `pn_buffer` allocations are used liberally and rarely checked for validity before being used, so unless I'm mistaken, it seems like we will just push the segfault up the call chain? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/27#issuecomment-99319790 Friendly ping ... Thanks, /Dan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
GitHub user dcristoloveanu opened a pull request: https://github.com/apache/qpid-proton/pull/27 Add some NULL checks and fix some realloc leaks Along the lines of PROTON-727, added NULL checks for some malloc/realloc calls that were either ignoring the result or leaking in the case of realloc. Thanks, /Dan You can merge this pull request into a Git repository by running: $ git pull https://github.com/dcristoloveanu/qpid-proton FixCodeAnalysis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit c31b068656579b3b6e47a44bd97b40001f2a66ca Author: dcristoloveanu Date: 2015-04-30T00:15:51Z Add some NULL checks and fix some realloc leaks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
