[GitHub] qpid-proton pull request: Reactor

2015-06-15 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/38 Reactor You can merge this pull request into a Git repository by running: $ git pull https://github.com/prestona/qpid-proton reactor Alternatively you can review and apply these changes

[GitHub] qpid-proton pull request: Reactor

2015-06-15 Thread prestona
Github user prestona closed the pull request at: https://github.com/apache/qpid-proton/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request: Reactor

2015-06-15 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/38#issuecomment-112227979 Sorry. Finger trouble. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] qpid-proton pull request: Reactor

2015-05-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] qpid-proton pull request: Reactor

2015-05-07 Thread gemmellr
Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/29#discussion_r29843571 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java --- @@ -157,12 +165,51 @@ public void dispatch(Handler handler)

Re: [GitHub] qpid-proton pull request: Reactor

2015-05-07 Thread Rafael Schloming
On Thu, May 7, 2015 at 7:29 AM, gemmellr g...@git.apache.org wrote: Github user gemmellr commented on a diff in the pull request: https://github.com/apache/qpid-proton/pull/29#discussion_r29843571 --- Diff: proton-j/src/main/java/org/apache/qpid/proton/engine/impl/EventImpl.java ---

[GitHub] qpid-proton pull request: Reactor

2015-05-06 Thread rhs
Github user rhs commented on the pull request: https://github.com/apache/qpid-proton/pull/29#issuecomment-99635551 Given my recent rant about new development on master, let's try pulling this in on a branch first. I've create the proton-j-reactor branch. If you can resubmit against

[GitHub] qpid-proton pull request: Reactor

2015-05-06 Thread prestona
Github user prestona closed the pull request at: https://github.com/apache/qpid-proton/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-proton pull request: Reactor

2015-05-06 Thread prestona
Github user prestona commented on the pull request: https://github.com/apache/qpid-proton/pull/29#issuecomment-99640540 Closing. Will submit again against proton-j-reactor --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] qpid-proton pull request: Reactor

2015-05-06 Thread prestona
GitHub user prestona opened a pull request: https://github.com/apache/qpid-proton/pull/30 Reactor This is an initial implementation of a proton-j version of the reactor. It comes with samples, unit tests and interoperation tests. It should be good enough to kick the tyres but