Re: [Proton-J] Improving the engine impl.

2015-05-13 Thread Rajith Muditha Attapattu
Sure, just wanted to pose the question to what your thoughts were. Having said that, this maybe one of the areas to look at after the codec work is done. Another area is the FrameParser and FrameWrite :p ... but one thing at a time. Regards, Rajith On Wed, May 13, 2015 at 2:07 PM, Rafael Schlomi

Re: [Proton-J] Improving the engine impl.

2015-05-13 Thread Rafael Schloming
On Wed, May 13, 2015 at 12:58 PM, Rajith Muditha Attapattu < rajit...@gmail.com> wrote: > If you look at the engine impl, you would see TransportLink and a LinkImpl > (ditto for Session, Delivery etc..) > > 1. Is this separation necessary? Could we not collapse the two into one? > > 2. The extra c

[Proton-J] Improving the engine impl.

2015-05-13 Thread Rajith Muditha Attapattu
If you look at the engine impl, you would see TransportLink and a LinkImpl (ditto for Session, Delivery etc..) 1. Is this separation necessary? Could we not collapse the two into one? 2. The extra copying of data btw the two layers could possibly be a performance issue. Regards, Rajith