[jira] [Commented] (PROTON-1029) Do not fail hard if strerror_r fails.
[ https://issues.apache.org/jira/browse/PROTON-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978571#comment-14978571 ] ASF subversion and git services commented on PROTON-1029: - Commit fe21523f54c735645a4f96f6b547459ed81e4e14 in qpid-proton's branch refs/heads/0.11.x from [~kgiusti] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=fe21523 ] PROTON-1029: do not crash if strerror fails > Do not fail hard if strerror_r fails. > - > > Key: PROTON-1029 > URL: https://issues.apache.org/jira/browse/PROTON-1029 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Critical > Labels: crash > Fix For: 0.11 > > > The return type from strerror_r differs depending on the compiler's feature > set. > if _GNU_SOURCE is defined, strerror_r returns a char * > if _POSIX_C_SOURCE is defined to a certain set of values, strerror_r returns > an int. > proton expects int, and fails hard (aborts) when a string ptr is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1029) Do not fail hard if strerror_r fails.
[ https://issues.apache.org/jira/browse/PROTON-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978518#comment-14978518 ] Justin Ross commented on PROTON-1029: - Reviewed by Alan. Approved for 0.11.0. > Do not fail hard if strerror_r fails. > - > > Key: PROTON-1029 > URL: https://issues.apache.org/jira/browse/PROTON-1029 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ken Giusti >Assignee: Ken Giusti >Priority: Critical > Labels: crash > Fix For: 0.11 > > > The return type from strerror_r differs depending on the compiler's feature > set. > if _GNU_SOURCE is defined, strerror_r returns a char * > if _POSIX_C_SOURCE is defined to a certain set of values, strerror_r returns > an int. > proton expects int, and fails hard (aborts) when a string ptr is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1029) Do not fail hard if strerror_r fails.
[ https://issues.apache.org/jira/browse/PROTON-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978440#comment-14978440 ] Alan Conway commented on PROTON-1029: - Ship It! > Do not fail hard if strerror_r fails. > - > > Key: PROTON-1029 > URL: https://issues.apache.org/jira/browse/PROTON-1029 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ken Giusti >Assignee: Ken Giusti > Fix For: 0.11 > > > The return type from strerror_r differs depending on the compiler's feature > set. > if _GNU_SOURCE is defined, strerror_r returns a char * > if _POSIX_C_SOURCE is defined to a certain set of values, strerror_r returns > an int. > proton expects int, and fails hard (aborts) when a string ptr is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1029) Do not fail hard if strerror_r fails.
[ https://issues.apache.org/jira/browse/PROTON-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978369#comment-14978369 ] ASF subversion and git services commented on PROTON-1029: - Commit 7c132f35392448d2623a01915ea9ce6303453162 in qpid-proton's branch refs/heads/master from [~kgiusti] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=7c132f3 ] PROTON-1029: do not crash if strerror fails > Do not fail hard if strerror_r fails. > - > > Key: PROTON-1029 > URL: https://issues.apache.org/jira/browse/PROTON-1029 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Ken Giusti >Assignee: Ken Giusti > Fix For: 0.11 > > > The return type from strerror_r differs depending on the compiler's feature > set. > if _GNU_SOURCE is defined, strerror_r returns a char * > if _POSIX_C_SOURCE is defined to a certain set of values, strerror_r returns > an int. > proton expects int, and fails hard (aborts) when a string ptr is returned. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
