[jira] [Commented] (PROTON-121) Platform specific code is mixed in with platform independent code
[ https://issues.apache.org/jira/browse/PROTON-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13577691#comment-13577691 ] Andrew Stitcher commented on PROTON-121: The file error.c still uses strerror_r(); we still need to review the engine portions and ensure they are only dependent on ANSI C headers. Platform specific code is mixed in with platform independent code - Key: PROTON-121 URL: https://issues.apache.org/jira/browse/PROTON-121 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Andrew Stitcher Assignee: Andrew Stitcher Fix For: 0.4 the function pn_error_from errno() is platform specific and so should not be in error.c which is (everywhere else) purely platform independent. It should be moved to a platform (POSIX) specific file (perhaps a file with only this single function). [The clue for this is the #define POSIX_C_SOURCE at the top of error.c] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-121) Platform specific code is mixed in with platform independent code
[ https://issues.apache.org/jira/browse/PROTON-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13575852#comment-13575852 ] Rafael H. Schloming commented on PROTON-121: Is there more work needed for this or can we close it off now? Platform specific code is mixed in with platform independent code - Key: PROTON-121 URL: https://issues.apache.org/jira/browse/PROTON-121 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Andrew Stitcher the function pn_error_from errno() is platform specific and so should not be in error.c which is (everywhere else) purely platform independent. It should be moved to a platform (POSIX) specific file (perhaps a file with only this single function). [The clue for this is the #define POSIX_C_SOURCE at the top of error.c] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-121) Platform specific code is mixed in with platform independent code
[ https://issues.apache.org/jira/browse/PROTON-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13532632#comment-13532632 ] Andrew Stitcher commented on PROTON-121: Committed change removing use of strcasecmp() r1422066 Platform specific code is mixed in with platform independent code - Key: PROTON-121 URL: https://issues.apache.org/jira/browse/PROTON-121 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Andrew Stitcher the function pn_error_from errno() is platform specific and so should not be in error.c which is (everywhere else) purely platform independent. It should be moved to a platform (POSIX) specific file (perhaps a file with only this single function). [The clue for this is the #define POSIX_C_SOURCE at the top of error.c] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-121) Platform specific code is mixed in with platform independent code
[ https://issues.apache.org/jira/browse/PROTON-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529345#comment-13529345 ] Andrew Stitcher commented on PROTON-121: Another example is the use of strerror_r() which is also not part of ANSI C Platform specific code is mixed in with platform independent code - Key: PROTON-121 URL: https://issues.apache.org/jira/browse/PROTON-121 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Andrew Stitcher the function pn_error_from errno() is platform specific and so should not be in error.c which is (everywhere else) purely platform independent. It should be moved to a platform (POSIX) specific file (perhaps a file with only this single function). [The clue for this is the #define POSIX_C_SOURCE at the top of error.c] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-121) Platform specific code is mixed in with platform independent code
[ https://issues.apache.org/jira/browse/PROTON-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13510835#comment-13510835 ] Andrew Stitcher commented on PROTON-121: A good (perhaps the only) example of this is the use of ntohl() in the engine code. ntohl() is part of the BSD sockets API and not defined in ANSI C at all. Platform specific code is mixed in with platform independent code - Key: PROTON-121 URL: https://issues.apache.org/jira/browse/PROTON-121 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Andrew Stitcher the function pn_error_from errno() is platform specific and so should not be in error.c which is (everywhere else) purely platform independent. It should be moved to a platform (POSIX) specific file (perhaps a file with only this single function). [The clue for this is the #define POSIX_C_SOURCE at the top of error.c] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-121) Platform specific code is mixed in with platform independent code
[ https://issues.apache.org/jira/browse/PROTON-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13510841#comment-13510841 ] Andrew Stitcher commented on PROTON-121: Another example is the use of strcasecmp() which again is not part of ANSI C. Platform specific code is mixed in with platform independent code - Key: PROTON-121 URL: https://issues.apache.org/jira/browse/PROTON-121 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Andrew Stitcher the function pn_error_from errno() is platform specific and so should not be in error.c which is (everywhere else) purely platform independent. It should be moved to a platform (POSIX) specific file (perhaps a file with only this single function). [The clue for this is the #define POSIX_C_SOURCE at the top of error.c] -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira