[jira] [Commented] (PROTON-214) Test "proton_tests.messenger.MessengerTest.testSendBogus" failed

2013-03-21 Thread Gordon Sim (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608715#comment-13608715
 ] 

Gordon Sim commented on PROTON-214:
---

Looks fine to me!

> Test "proton_tests.messenger.MessengerTest.testSendBogus" failed
> 
>
> Key: PROTON-214
> URL: https://issues.apache.org/jira/browse/PROTON-214
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: 0.3, 0.4
> Environment: Run "mvn test" from a clean checkout - this uses 
> proton-j by default.
>Reporter: Philip Harvey
>Assignee: Gordon Sim
>Priority: Minor
> Attachments: JNIMessenger.patch
>
>
> The system test "proton_tests.messenger.MessengerTest.testSendBogus" is 
> failing against both the proton-jni profile and, on certain computers, when 
> run against proton-j too.  
> The proton-jni problem seems to be caused by the fact the the JNI Messenger 
> implementation ignores proton-c's error return codes.
> I think I've seen this test pass occasionally against proton-j so I suspect 
> there's something unreliable about the test.
> Here is the output.
> proton_tests.messenger.MessengerTest.testSendBogus ..Feb 
> 4, 2013 2:07:19 PM org.apache.qpid.proton.messenger.impl.MessengerImpl 
> processActive
> SEVERE: Error processing connection
> java.io.IOException: Connection reset by peer
>   at sun.nio.ch.FileDispatcher.read0(Native Method)
>   at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:21)
>   at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:233)
>   at sun.nio.ch.IOUtil.read(IOUtil.java:206)
>   at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:236)
>   at 
> org.apache.qpid.proton.driver.impl.ConnectorImpl.read(ConnectorImpl.java:95)
>   at 
> org.apache.qpid.proton.driver.impl.ConnectorImpl.process(ConnectorImpl.java:80)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.processActive(MessengerImpl.java:426)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.waitUntil(MessengerImpl.java:525)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.waitUntil(MessengerImpl.java:506)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.send(MessengerImpl.java:205)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:186)
>   at 
> org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:204)
>   at org.python.core.PyObject.__call__(PyObject.java:387)
>   at org.python.core.PyObject.__call__(PyObject.java:391)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at proton$py.send$201(__pyclasspath__/proton.py:997)
>   at proton$py.call_function(__pyclasspath__/proton.py)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:134)
>   at org.python.core.PyFunction.__call__(PyFunction.java:317)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at 
> proton_tests.messenger$py.teardown$4(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton_tests/messenger.py:52)
>   at 
> proton_tests.messenger$py.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton_tests/messenger.py)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:134)
>   at org.python.core.PyFunction.__call__(PyFunction.java:317)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at 
> org.python.pycode._pyx1.run$36(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test:344)
>   at 
> org.python.pycode._pyx1.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:166)
>   at org.python.core.PyFunction.__call__(PyFunction.java:338)
>   at org.python.core.PyMethod.__call__(PyMethod.java:139)
>   at 
> org.python.pycode._pyx1._run$55(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test:484)
>   at 
> org.python.pycode._pyx1.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test)
>   at org.python.core.PyTableCode.call(PyTableCode

[jira] [Commented] (PROTON-214) Test "proton_tests.messenger.MessengerTest.testSendBogus" failed

2013-02-22 Thread Philip Harvey (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13584122#comment-13584122
 ] 

Philip Harvey commented on PROTON-214:
--

This test was also failing when run under the proton-jni profile, because 
JNIMessenger does not yet handle non-zero (ie non-success) returns codes from 
proton-c functions.  I have modified it to throw 
ProtonUnsupportedOperationException's in revision 1448962 so that this test 
skips rather than fails when using proton-jni.

Leaving this Jira open until the proton-j problem is also resolved.

> Test "proton_tests.messenger.MessengerTest.testSendBogus" failed
> 
>
> Key: PROTON-214
> URL: https://issues.apache.org/jira/browse/PROTON-214
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: 0.3
> Environment: Run "mvn test" from a clean checkout - this uses 
> proton-j by default.
>Reporter: Philip Harvey
>Assignee: Gordon Sim
>Priority: Minor
> Fix For: 0.5
>
>
> The system test "proton_tests.messenger.MessengerTest.testSendBogus" is 
> failing on my computer when run against proton-j.  I think I've seen this 
> test pass occasionally so I suspect there's something unreliable about the 
> test.
> Here is the output.
> proton_tests.messenger.MessengerTest.testSendBogus ..Feb 
> 4, 2013 2:07:19 PM org.apache.qpid.proton.messenger.impl.MessengerImpl 
> processActive
> SEVERE: Error processing connection
> java.io.IOException: Connection reset by peer
>   at sun.nio.ch.FileDispatcher.read0(Native Method)
>   at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:21)
>   at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:233)
>   at sun.nio.ch.IOUtil.read(IOUtil.java:206)
>   at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:236)
>   at 
> org.apache.qpid.proton.driver.impl.ConnectorImpl.read(ConnectorImpl.java:95)
>   at 
> org.apache.qpid.proton.driver.impl.ConnectorImpl.process(ConnectorImpl.java:80)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.processActive(MessengerImpl.java:426)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.waitUntil(MessengerImpl.java:525)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.waitUntil(MessengerImpl.java:506)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.send(MessengerImpl.java:205)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:186)
>   at 
> org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:204)
>   at org.python.core.PyObject.__call__(PyObject.java:387)
>   at org.python.core.PyObject.__call__(PyObject.java:391)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at proton$py.send$201(__pyclasspath__/proton.py:997)
>   at proton$py.call_function(__pyclasspath__/proton.py)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:134)
>   at org.python.core.PyFunction.__call__(PyFunction.java:317)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at 
> proton_tests.messenger$py.teardown$4(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton_tests/messenger.py:52)
>   at 
> proton_tests.messenger$py.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton_tests/messenger.py)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:134)
>   at org.python.core.PyFunction.__call__(PyFunction.java:317)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at 
> org.python.pycode._pyx1.run$36(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test:344)
>   at 
> org.python.pycode._pyx1.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:166)
>   at org.python.core.PyFunction.__call__(PyFunction.java:338)
>   at org.python.core.PyMethod.__call__(PyMethod.java:139)
>   at 
> org.python.pycode._pyx1._run$55(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test:484)
>   at 
> org.python.pycode._py

[jira] [Commented] (PROTON-214) Test "proton_tests.messenger.MessengerTest.testSendBogus" failed

2013-02-04 Thread Gordon Sim (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570301#comment-13570301
 ] 

Gordon Sim commented on PROTON-214:
---

Downgraded the severity as I think this is primarily an issue with the test 
rather than exposing underlying unreliability in the messenger implementation 
itself. Of course failing tests are never a good thing, so it should still be 
fixed.

> Test "proton_tests.messenger.MessengerTest.testSendBogus" failed
> 
>
> Key: PROTON-214
> URL: https://issues.apache.org/jira/browse/PROTON-214
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: 0.3
> Environment: Run "mvn test" from a clean checkout - this uses 
> proton-j by default.
>Reporter: Philip Harvey
>Assignee: Gordon Sim
>Priority: Minor
>
> The system test "proton_tests.messenger.MessengerTest.testSendBogus" is 
> failing on my computer when run against proton-j.  I think I've seen this 
> test pass occasionally so I suspect there's something unreliable about the 
> test.
> Here is the output.
> proton_tests.messenger.MessengerTest.testSendBogus ..Feb 
> 4, 2013 2:07:19 PM org.apache.qpid.proton.messenger.impl.MessengerImpl 
> processActive
> SEVERE: Error processing connection
> java.io.IOException: Connection reset by peer
>   at sun.nio.ch.FileDispatcher.read0(Native Method)
>   at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:21)
>   at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:233)
>   at sun.nio.ch.IOUtil.read(IOUtil.java:206)
>   at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:236)
>   at 
> org.apache.qpid.proton.driver.impl.ConnectorImpl.read(ConnectorImpl.java:95)
>   at 
> org.apache.qpid.proton.driver.impl.ConnectorImpl.process(ConnectorImpl.java:80)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.processActive(MessengerImpl.java:426)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.waitUntil(MessengerImpl.java:525)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.waitUntil(MessengerImpl.java:506)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.send(MessengerImpl.java:205)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:186)
>   at 
> org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:204)
>   at org.python.core.PyObject.__call__(PyObject.java:387)
>   at org.python.core.PyObject.__call__(PyObject.java:391)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at proton$py.send$201(__pyclasspath__/proton.py:997)
>   at proton$py.call_function(__pyclasspath__/proton.py)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:134)
>   at org.python.core.PyFunction.__call__(PyFunction.java:317)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at 
> proton_tests.messenger$py.teardown$4(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton_tests/messenger.py:52)
>   at 
> proton_tests.messenger$py.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton_tests/messenger.py)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:134)
>   at org.python.core.PyFunction.__call__(PyFunction.java:317)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at 
> org.python.pycode._pyx1.run$36(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test:344)
>   at 
> org.python.pycode._pyx1.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:166)
>   at org.python.core.PyFunction.__call__(PyFunction.java:338)
>   at org.python.core.PyMethod.__call__(PyMethod.java:139)
>   at 
> org.python.pycode._pyx1._run$55(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test:484)
>   at 
> org.python.pycode._pyx1.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python

[jira] [Commented] (PROTON-214) Test "proton_tests.messenger.MessengerTest.testSendBogus" failed

2013-02-04 Thread Gordon Sim (JIRA) 

[ 
https://issues.apache.org/jira/browse/PROTON-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570300#comment-13570300
 ] 

Gordon Sim commented on PROTON-214:
---

I actually think there is a race in the test logic, where the server can see 
the running flag has been turned off and stops before the client actually 
manages to establish a connection. In the testSendBogus() test the window for 
this race is somewhat larger than other tests as the test itself does not 
establish the connection to the server (that is done on teardown in response to 
sending the trigger message).

That said, this does also raise the question of how failure to connect should 
be signalled. Should send() throw an exception in this case rather than timing 
out?

> Test "proton_tests.messenger.MessengerTest.testSendBogus" failed
> 
>
> Key: PROTON-214
> URL: https://issues.apache.org/jira/browse/PROTON-214
> Project: Qpid Proton
>  Issue Type: Bug
>Affects Versions: 0.3
> Environment: Run "mvn test" from a clean checkout - this uses 
> proton-j by default.
>Reporter: Philip Harvey
>Assignee: Gordon Sim
>
> The system test "proton_tests.messenger.MessengerTest.testSendBogus" is 
> failing on my computer when run against proton-j.  I think I've seen this 
> test pass occasionally so I suspect there's something unreliable about the 
> test.
> Here is the output.
> proton_tests.messenger.MessengerTest.testSendBogus ..Feb 
> 4, 2013 2:07:19 PM org.apache.qpid.proton.messenger.impl.MessengerImpl 
> processActive
> SEVERE: Error processing connection
> java.io.IOException: Connection reset by peer
>   at sun.nio.ch.FileDispatcher.read0(Native Method)
>   at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:21)
>   at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:233)
>   at sun.nio.ch.IOUtil.read(IOUtil.java:206)
>   at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:236)
>   at 
> org.apache.qpid.proton.driver.impl.ConnectorImpl.read(ConnectorImpl.java:95)
>   at 
> org.apache.qpid.proton.driver.impl.ConnectorImpl.process(ConnectorImpl.java:80)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.processActive(MessengerImpl.java:426)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.waitUntil(MessengerImpl.java:525)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.waitUntil(MessengerImpl.java:506)
>   at 
> org.apache.qpid.proton.messenger.impl.MessengerImpl.send(MessengerImpl.java:205)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>   at java.lang.reflect.Method.invoke(Method.java:597)
>   at 
> org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:186)
>   at 
> org.python.core.PyReflectedFunction.__call__(PyReflectedFunction.java:204)
>   at org.python.core.PyObject.__call__(PyObject.java:387)
>   at org.python.core.PyObject.__call__(PyObject.java:391)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at proton$py.send$201(__pyclasspath__/proton.py:997)
>   at proton$py.call_function(__pyclasspath__/proton.py)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:134)
>   at org.python.core.PyFunction.__call__(PyFunction.java:317)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at 
> proton_tests.messenger$py.teardown$4(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton_tests/messenger.py:52)
>   at 
> proton_tests.messenger$py.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton_tests/messenger.py)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:134)
>   at org.python.core.PyFunction.__call__(PyFunction.java:317)
>   at org.python.core.PyMethod.__call__(PyMethod.java:109)
>   at 
> org.python.pycode._pyx1.run$36(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test:344)
>   at 
> org.python.pycode._pyx1.call_function(/fast/.jenkins/jobs/Trunk-Proton-J/workspace/proton/tests/target/classes/proton-test)
>   at org.python.core.PyTableCode.call(PyTableCode.java:165)
>   at org.python.core.PyBaseCode.call(PyBaseCode.java:166)
>   at org.python.core.PyFunction.__call__(PyFunction.java:338)
>   at org.python.core.PyMethod.__call__(PyMethod.java:139)
>   at 
> org.python.pycode._pyx1._run$55(/fa