[jira] [Commented] (PROTON-26) Engine api naming proposal
[ https://issues.apache.org/jira/browse/PROTON-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532391#comment-13532391 ] Rafael H. Schloming commented on PROTON-26: --- If you think there is more work that should be done as part of this JIRA then please reopen it or perhaps file other more specific JIRAs for the remaining work. > Engine api naming proposal > -- > > Key: PROTON-26 > URL: https://issues.apache.org/jira/browse/PROTON-26 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c, proton-j >Reporter: Justin Ross >Assignee: Rafael H. Schloming > Labels: api > Fix For: 0.2 > > Attachments: engine-naming-01.patch, > proton-engine-naming-proposal-2.pdf, proton-engine-naming-proposal-3.pdf > > > See > https://docs.google.com/spreadsheet/ccc?key=0ArGmVtK1EBOMdEw0bkp4OE5UOWpRRkx3RzVoTjliX0E#gid=0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-26) Engine api naming proposal
[ https://issues.apache.org/jira/browse/PROTON-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531571#comment-13531571 ] Justin Ross commented on PROTON-26: --- That's really not the case. Rejecting it is fine, but it's mostly gone undiscussed. That's partly my fault. A post to the mailing list with highlights suitable for inline comments is incoming. > Engine api naming proposal > -- > > Key: PROTON-26 > URL: https://issues.apache.org/jira/browse/PROTON-26 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c, proton-j >Reporter: Justin Ross >Assignee: Rafael H. Schloming > Labels: api > Fix For: 0.2 > > Attachments: engine-naming-01.patch, > proton-engine-naming-proposal-2.pdf, proton-engine-naming-proposal-3.pdf > > > See > https://docs.google.com/spreadsheet/ccc?key=0ArGmVtK1EBOMdEw0bkp4OE5UOWpRRkx3RzVoTjliX0E#gid=0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-26) Engine api naming proposal
[ https://issues.apache.org/jira/browse/PROTON-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468498#comment-13468498 ] Rafael H. Schloming commented on PROTON-26: --- The reason the transport uses input/output rather than read/write is because read/write would have exactly the opposite of the usual semantics with respect to its arguments. A "read" operation typically populates the passed in array with data, whereas the "input" operation is actually providing input in the passed in array that is consumed by the transport. Likewise a "write" operation usually consumes/copies bytes from the passed in array whereas the "output" operation is actually filling the passed in array with output from the transport. Reversing the names (input -> write, output -> read) to make the semantics similar with respect to the arguments would also be confusing as you'd be calling Transport.read in order to produce output to write to the network. As it is now it's pretty easy to remember that you read from the network to provide input to the transport and when the transport supplies output, you write to the network. > Engine api naming proposal > -- > > Key: PROTON-26 > URL: https://issues.apache.org/jira/browse/PROTON-26 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Justin Ross > Attachments: engine-naming-01.patch, > proton-engine-naming-proposal-2.pdf > > > See > https://docs.google.com/spreadsheet/ccc?key=0ArGmVtK1EBOMdEw0bkp4OE5UOWpRRkx3RzVoTjliX0E#gid=0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-26) Engine api naming proposal
[ https://issues.apache.org/jira/browse/PROTON-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468484#comment-13468484 ] Rafael H. Schloming commented on PROTON-26: --- The reason that the trace constants use three letter abbreviations is because they correspond to logging categories that use three letter abbreviations in order to easily prefix the log output with the category while not taking up too much of the line and not messing with the alignment. This might not be super obvious right now because I believe only the RAW category properly prefixes its log messages, however I think this will be useful going forward, especially if we add logging codes, e.g.: DRV-00204: blah > Engine api naming proposal > -- > > Key: PROTON-26 > URL: https://issues.apache.org/jira/browse/PROTON-26 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Justin Ross > Attachments: engine-naming-01.patch, > proton-engine-naming-proposal-2.pdf > > > See > https://docs.google.com/spreadsheet/ccc?key=0ArGmVtK1EBOMdEw0bkp4OE5UOWpRRkx3RzVoTjliX0E#gid=0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
