[ https://issues.apache.org/jira/browse/PROTON-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720696#comment-13720696 ]
Philip Harvey commented on PROTON-366: -------------------------------------- I don't think this patch should be committed without wider review. From a quick check, I notice: - Curly braces should be on new lines as per [https://cwiki.apache.org/confluence/display/qpid/Java+Coding+Standards] - I doubt we really want to add a compile-time dependency on hawtbuf and hawtdispatch-transport to proton-j (or have I misread the patch?) - We've been very careful about additions to proton's public interface so far, so the addition of a command-line utility in proton-j-impl is something that merits discussion on the proton mailing list. - Instead of cluttering the pom with locations of sample data files used to test the utility, should this should all be inside a JUnit test? > Add a protocol dump utility for java > ------------------------------------ > > Key: PROTON-366 > URL: https://issues.apache.org/jira/browse/PROTON-366 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j > Affects Versions: 0.4 > Reporter: Justin Ross > Priority: Minor > Attachments: QPID-4106.patch > > > This bug was originally under the QPID jira instance. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira