[jira] [Commented] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475144#comment-13475144 ] Darryl L. Pierce commented on PROTON-48: Rafi, I wasn't aware of the LIBDIR macro in Cmake. > Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment > - > > Key: PROTON-48 > URL: https://issues.apache.org/jira/browse/PROTON-48 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Darryl L. Pierce > Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch > > > On 64-bit platforms, the libraries need to be installed into a directory > named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets > the build environment specify the directory name, with the default behavior > being what CMake already does it the directory isn't specified. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475059#comment-13475059 ] Andrew Stitcher commented on PROTON-48: --- Ok I see what the patch adds - reworked to more sanely switch from $PREFIX/lib to $PREFIX/ [Note though that specifying LIBDIR directly might be more useful than just the directory name as I think the packaging environment can supply it directly through the __libdir macro, which would automatically be sent into configure, but will have to be sent manually into cmake - at least that's my understanding of how rpmbuild works] > Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment > - > > Key: PROTON-48 > URL: https://issues.apache.org/jira/browse/PROTON-48 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Darryl L. Pierce > Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch > > > On 64-bit platforms, the libraries need to be installed into a directory > named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets > the build environment specify the directory name, with the default behavior > being what CMake already does it the directory isn't specified. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475044#comment-13475044 ] Rafael H. Schloming commented on PROTON-48: --- I didn't really think too hard when applying it, but you raise a good point. Darryl? What's the benefit of overriding PROTON_BLAH instead of just overriding LIBDIR directly? > Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment > - > > Key: PROTON-48 > URL: https://issues.apache.org/jira/browse/PROTON-48 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Darryl L. Pierce > Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch > > > On 64-bit platforms, the libraries need to be installed into a directory > named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets > the build environment specify the directory name, with the default behavior > being what CMake already does it the directory isn't specified. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-48) Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment
[ https://issues.apache.org/jira/browse/PROTON-48?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13475025#comment-13475025 ] Andrew Stitcher commented on PROTON-48: --- This is a completely unnecessary patch you can already specify the name of the lib directory that's the entire purpose of the LIBDIR setting - I don't understand what this extra code adds. Unless I get a cinvincing response I'll revert the this patch. > Adds the PROTON_INSTALL_LIBDIR macro to the Cmake environment > - > > Key: PROTON-48 > URL: https://issues.apache.org/jira/browse/PROTON-48 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Darryl L. Pierce > Attachments: 0001-Adds-the-PROTON_INSTALL_LIBDIR-macro.patch > > > On 64-bit platforms, the libraries need to be installed into a directory > named /usr/lib64. However, CMake by default uses /usr/lib. This patch lets > the build environment specify the directory name, with the default behavior > being what CMake already does it the directory isn't specified. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
