[jira] [Commented] (PROTON-770) Refactor Proton C to eliminate the pn_dispatcher_t class
[ https://issues.apache.org/jira/browse/PROTON-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244749#comment-14244749 ] ASF subversion and git services commented on PROTON-770: Commit 117ac209e084d44b565212745d5c7e478df9c9d0 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=117ac20 ] PROTON-770: Eliminate pn_dispatcher_t: - Moved all useful state from pn_dispatcher_t to pn_transport_t - Only left input frame dispatching in dispatcher.[ch] > Refactor Proton C to eliminate the pn_dispatcher_t class > > > Key: PROTON-770 > URL: https://issues.apache.org/jira/browse/PROTON-770 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The pn_dispatcher_t class has two intertwined purposes - > * To hold some temporary and scratch data used for processing incoming and > outgoing frames. > * To dispatch incoming frames to frame handling code. > It turns out that the first purpose is overhead: The temporary data can be > better passed as parameters to the code that is using it; The scratch data is > duplicated and would be better put in the associated pn_transport_t which is > where is ends up going anyway. > The second purpose turns out to boil down to 1 boolean and some code which > can be handled differently. The boolean is to tell the dispatcher to stop. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-770) Refactor Proton C to eliminate the pn_dispatcher_t class
[ https://issues.apache.org/jira/browse/PROTON-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14244750#comment-14244750 ] ASF subversion and git services commented on PROTON-770: Commit d042c4ed04e44cefa535ad204ab0b9bde2ccc61c in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d042c4e ] Land PROTON-770. > Refactor Proton C to eliminate the pn_dispatcher_t class > > > Key: PROTON-770 > URL: https://issues.apache.org/jira/browse/PROTON-770 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The pn_dispatcher_t class has two intertwined purposes - > * To hold some temporary and scratch data used for processing incoming and > outgoing frames. > * To dispatch incoming frames to frame handling code. > It turns out that the first purpose is overhead: The temporary data can be > better passed as parameters to the code that is using it; The scratch data is > duplicated and would be better put in the associated pn_transport_t which is > where is ends up going anyway. > The second purpose turns out to boil down to 1 boolean and some code which > can be handled differently. The boolean is to tell the dispatcher to stop. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-770) Refactor Proton C to eliminate the pn_dispatcher_t class
[ https://issues.apache.org/jira/browse/PROTON-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242114#comment-14242114 ] ASF subversion and git services commented on PROTON-770: Commit fc9b88eada8c685fb2a003570bf903a9360f48d2 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=fc9b88e ] PROTON-770: Change dispatcher interface (more parameters for frame handlers) - Use transport, frametype and channel - Pass more of the frame directly into the frame handlers > Refactor Proton C to eliminate the pn_dispatcher_t class > > > Key: PROTON-770 > URL: https://issues.apache.org/jira/browse/PROTON-770 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The pn_dispatcher_t class has two intertwined purposes - > * To hold some temporary and scratch data used for processing incoming and > outgoing frames. > * To dispatch incoming frames to frame handling code. > It turns out that the first purpose is overhead: The temporary data can be > better passed as parameters to the code that is using it; The scratch data is > duplicated and would be better put in the associated pn_transport_t which is > where is ends up going anyway. > The second purpose turns out to boil down to 1 boolean and some code which > can be handled differently. The boolean is to tell the dispatcher to stop. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
