[jira] [Commented] (PROTON-814) proton-c: pn_selector_select caches its return code from a previous error
[ https://issues.apache.org/jira/browse/PROTON-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304880#comment-14304880 ] ASF subversion and git services commented on PROTON-814: Commit a85caef8883be36d89093cbd0a0030eba2d57be1 in qpid-proton's branch refs/heads/master from [~dnwe] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=a85caef ] PROTON-814: only return error rc on a failed poll In posix pn_selector_select, if a poll() call returns result == -1 and sets selector->error from the errno, any subsequent pn_selector_select calls on the same selector will return have a return code of the previously cached errno even if they succeed. Closes #6 > proton-c: pn_selector_select caches its return code from a previous error > - > > Key: PROTON-814 > URL: https://issues.apache.org/jira/browse/PROTON-814 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 >Reporter: Dominic Evans >Assignee: Dominic Evans > > In posix pn_selector_select, if a poll() call returns result == -1 and > sets selector->error from the errno, any subsequent pn_selector_select > calls on the same selector will return have a return code of the > previously cached errno even if they succeed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-814) proton-c: pn_selector_select caches its return code from a previous error
[ https://issues.apache.org/jira/browse/PROTON-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304881#comment-14304881 ] ASF GitHub Bot commented on PROTON-814: --- Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/6 > proton-c: pn_selector_select caches its return code from a previous error > - > > Key: PROTON-814 > URL: https://issues.apache.org/jira/browse/PROTON-814 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 >Reporter: Dominic Evans >Assignee: Dominic Evans > > In posix pn_selector_select, if a poll() call returns result == -1 and > sets selector->error from the errno, any subsequent pn_selector_select > calls on the same selector will return have a return code of the > previously cached errno even if they succeed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-814) proton-c: pn_selector_select caches its return code from a previous error
[ https://issues.apache.org/jira/browse/PROTON-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304103#comment-14304103 ] ASF GitHub Bot commented on PROTON-814: --- GitHub user dnwe opened a pull request: https://github.com/apache/qpid-proton/pull/6 PROTON-814: only return error rc on a failed poll In posix pn_selector_select, if a poll() call returns result == -1 and sets selector->error from the errno, any subsequent pn_selector_select calls on the same selector will return have a return code of the previously cached errno even if they succeed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dnwe/qpid-proton fix-proton-814 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/6.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6 commit d3cef91426bbcfc4809f38dbbc87ddd2b3cbdd1e Author: Dominic Evans Date: 2015-02-03T21:56:33Z PROTON-814: only return error rc on a failed poll In posix pn_selector_select, if a poll() call returns result == -1 and sets selector->error from the errno, any subsequent pn_selector_select calls on the same selector will return have a return code of the previously cached errno even if they succeed. > proton-c: pn_selector_select caches its return code from a previous error > - > > Key: PROTON-814 > URL: https://issues.apache.org/jira/browse/PROTON-814 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 >Reporter: Dominic Evans >Assignee: Dominic Evans > > In posix pn_selector_select, if a poll() call returns result == -1 and > sets selector->error from the errno, any subsequent pn_selector_select > calls on the same selector will return have a return code of the > previously cached errno even if they succeed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-814) proton-c: pn_selector_select caches its return code from a previous error
[ https://issues.apache.org/jira/browse/PROTON-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14304106#comment-14304106 ] ASF GitHub Bot commented on PROTON-814: --- Github user dnwe commented on the pull request: https://github.com/apache/qpid-proton/pull/6#issuecomment-72745128 @rhs please can you take a look at this pull request and confirm that you're happy with the change? > proton-c: pn_selector_select caches its return code from a previous error > - > > Key: PROTON-814 > URL: https://issues.apache.org/jira/browse/PROTON-814 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.8 >Reporter: Dominic Evans >Assignee: Dominic Evans > > In posix pn_selector_select, if a poll() call returns result == -1 and > sets selector->error from the errno, any subsequent pn_selector_select > calls on the same selector will return have a return code of the > previously cached errno even if they succeed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
