Re: Jira numbers in commit messages

2013-03-14 Thread Phil Harvey
If I see NO-JIRA then I usually infer that the author considered whether a
Jira was required and decided not.  Without this marker, I can't
distinguish between deliberate and accidental omission of the Jira number.




On 14 March 2013 14:47, Rafael Schloming r...@alum.mit.edu wrote:

 To be honest, I've never really understood the point of the NO-JIRA thing.
 What's the technical difference between NO-JIRA: blah and simply omitting
 the PROTON-xxx? I can't see that it would significantly improve grepability
 since either way you need to run a regex over the whole log string for
 anything that matches PROTON-[0-9]+.

 --Rafael

 On Thu, Mar 14, 2013 at 10:31 AM, Phil Harvey p...@philharveyonline.com
 wrote:

  I notice a fair smattering of recent Proton commits without Jira numbers
 in
  them.  As far as I'm aware, all commits should either contain a Jira
 number
  in the format PROTON-xyz: or, for exceptionally simple changes,
  NO-JIRA:.
 
  Please shout if you disagree.
 
  Thanks
  Phil
 



Re: Jira numbers in commit messages

2013-03-14 Thread Rafael Schloming
Surely either way you need to read the actual log message to distinguish
between correct and incorrect omission of the JIRA number. I would hate to
think you'd let something like NO-JIRA: overhauled user facing API go by
just because it was prefixed. ;-)

--Rafael

On Thu, Mar 14, 2013 at 11:38 AM, Phil Harvey p...@philharveyonline.comwrote:

 If I see NO-JIRA then I usually infer that the author considered whether a
 Jira was required and decided not.  Without this marker, I can't
 distinguish between deliberate and accidental omission of the Jira number.




 On 14 March 2013 14:47, Rafael Schloming r...@alum.mit.edu wrote:

  To be honest, I've never really understood the point of the NO-JIRA
 thing.
  What's the technical difference between NO-JIRA: blah and simply omitting
  the PROTON-xxx? I can't see that it would significantly improve
 grepability
  since either way you need to run a regex over the whole log string for
  anything that matches PROTON-[0-9]+.
 
  --Rafael
 
  On Thu, Mar 14, 2013 at 10:31 AM, Phil Harvey p...@philharveyonline.com
  wrote:
 
   I notice a fair smattering of recent Proton commits without Jira
 numbers
  in
   them.  As far as I'm aware, all commits should either contain a Jira
  number
   in the format PROTON-xyz: or, for exceptionally simple changes,
   NO-JIRA:.
  
   Please shout if you disagree.
  
   Thanks
   Phil
  
 



Re: Jira numbers in commit messages

2013-03-14 Thread Robbie Gemmell
So..NO-JIRA came about for two reasons.

First, as a way to escape the commit-hook level checking we voted that we
wanted in order to semi-enforce that people had a JIRA in their commit log,
because we were down in the ridiculous ~30% inclusion range not so many
years ago. Infra ultimately said the commit-hook approach was too slow to
work across the ASF-wide repo and indicated they considered the situation
as I had originally: its not very hard to self-enforce you have a JIRA in
all but the most trivial (readme etc) changes.

Following that, we kept the NO-JIRA idea anyway for pretty much the reason
Phil suggested, that by using it you are saying that you consider this to
be a change that does not justify a JIRA and are willing to be especially
called out if you are doing 'NO-JIRA: rewrite API' type commits.

I have a script from back then sitting somewhere in the deep dark areas of
my disk that pulls the commit logs and checks who has JIRAs in the
messages, who doesn't, and who NO-JIRA'd somthing to allow seeing what that
was. Ive been planning for a while to find it and run it again as theres
been a fair bit of absue lately. I'll do it in the next week and I'll
include Proton this time.

Robbie


On 14 March 2013 15:54, Rafael Schloming r...@alum.mit.edu wrote:

 Surely either way you need to read the actual log message to distinguish
 between correct and incorrect omission of the JIRA number. I would hate to
 think you'd let something like NO-JIRA: overhauled user facing API go by
 just because it was prefixed. ;-)

 --Rafael

 On Thu, Mar 14, 2013 at 11:38 AM, Phil Harvey p...@philharveyonline.com
 wrote:

  If I see NO-JIRA then I usually infer that the author considered whether
 a
  Jira was required and decided not.  Without this marker, I can't
  distinguish between deliberate and accidental omission of the Jira
 number.
 
 
 
 
  On 14 March 2013 14:47, Rafael Schloming r...@alum.mit.edu wrote:
 
   To be honest, I've never really understood the point of the NO-JIRA
  thing.
   What's the technical difference between NO-JIRA: blah and simply
 omitting
   the PROTON-xxx? I can't see that it would significantly improve
  grepability
   since either way you need to run a regex over the whole log string for
   anything that matches PROTON-[0-9]+.
  
   --Rafael
  
   On Thu, Mar 14, 2013 at 10:31 AM, Phil Harvey 
 p...@philharveyonline.com
   wrote:
  
I notice a fair smattering of recent Proton commits without Jira
  numbers
   in
them.  As far as I'm aware, all commits should either contain a Jira
   number
in the format PROTON-xyz: or, for exceptionally simple changes,
NO-JIRA:.
   
Please shout if you disagree.
   
Thanks
Phil