Re: Building proton-c: cc1: error: unrecognized command line option "-Wvla" (RHEL 5.3)

[Keith W]

On 5 February 2013 17:38, Cliff Jansen  wrote:
> Hmmm.  You raise a good point.
>
> On the one hand, we want people to be policed by these flags if they
> are contributing to the proton-c work.  However, we don't want proton
> to be difficult to build for anybody else.
>
> I will raise a JIRA to have the CMakeLists.txt only set the flags if
> the gcc version can handle it, and print some inspirational message
> otherwise.
>

Thanks Cliff, that sounds perfect.   Do you have a target date in mind
for this? We are currently having to patch the new flag out in order
to build on our Redhat Tikanga boxes.

Re: Building proton-c: cc1: error: unrecognized command line option "-Wvla" (RHEL 5.3)

[Cliff Jansen]

Hmmm.  You raise a good point.

On the one hand, we want people to be policed by these flags if they
are contributing to the proton-c work.  However, we don't want proton
to be difficult to build for anybody else.

I will raise a JIRA to have the CMakeLists.txt only set the flags if
the gcc version can handle it, and print some inspirational message
otherwise.

Cliff

On Tue, Feb 5, 2013 at 2:46 AM, Keith W  wrote:
> Hi all,
>
> I'm getting a problem building proton-c since rev 1441872 (Sunday
> 2013-02-03).  It looks like the introduction of the flag -Wvla has
> caused the problem. I've included full details below.
>
> Do we have a statement regarding the minumum versions of Proton's
> build and runtime dependencies?
>
> Kind regards
>
>
> [ 17%] Building C object proton-c/CMakeFiles/qpid-proton.dir/src/util.c.o
> cd /home/keith/src/live/qpid-proton/build/proton-c && /usr/bin/gcc
> -Dqpid_proton_EXPORTS -fPIC
> -I/home/keith/src/live/qpid-proton/build/proton-c
> -I/home/keith/src/live/qpid-proton/proton-c/include   -Werror -Wall
> -pedantic-errors -Wc++-compat -Wvla -Wsign-compare -Wwrite-strings
> -std=c99 -o CMakeFiles/qpid-proton.dir/src/util.c.o   -c
> /home/keith/src/live/qpid-proton/proton-c/src/util.c
> cc1: error: unrecognized command line option "-Wvla"
> make[2]: *** [proton-c/CMakeFiles/qpid-proton.dir/src/util.c.o] Error 1
>
>
> $ cat /etc/redhat-release
> Red Hat Enterprise Linux Server release 5.3 (Tikanga)
>
>
> $ rpmquery gcc
> gcc-4.1.2-44.el5.x86_64
>
> $ gcc --version
> gcc (GCC) 4.1.2 20080704 (Red Hat 4.1.2-44)
> Copyright (C) 2006 Free Software Foundation, Inc.
> This is free software; see the source for copying conditions.  There is NO
> warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.