Re: RFI: PROTON-1055 (SASL Plain authentication can fail on some brokers)

2016-01-28 Thread Justin Ross
Thanks, Robbie.  Approved.

On Thu, Jan 28, 2016 at 4:47 AM, Robbie Gemmell 
wrote:

> On 27 January 2016 at 21:09, Andrew Stitcher  wrote:
> > This [1] is really an interop bug, but I suspect it will be annoying to
> > anyone using earlier versions of ActiveMQ.
> >
> > The fix is pretty small and seems low risk to me.
> >
> > Andrew
> >
> > [1] https://issues.apache.org/jira/browse/PROTON-1055
>
> I gave this a look, and tested it out applied to the 0.12.0 beta using
> cyrus-casl, and all seemed well, I think including it would be good.
>
> (As an aside, I actually think of it as more than just an interop bug..)
>
> Robbie
>


Re: RFI: PROTON-1055 (SASL Plain authentication can fail on some brokers)

2016-01-28 Thread Robbie Gemmell
On 27 January 2016 at 21:09, Andrew Stitcher  wrote:
> This [1] is really an interop bug, but I suspect it will be annoying to
> anyone using earlier versions of ActiveMQ.
>
> The fix is pretty small and seems low risk to me.
>
> Andrew
>
> [1] https://issues.apache.org/jira/browse/PROTON-1055

I gave this a look, and tested it out applied to the 0.12.0 beta using
cyrus-casl, and all seemed well, I think including it would be good.

(As an aside, I actually think of it as more than just an interop bug..)

Robbie