On 07/20/2015 08:53 PM, Rafael Schloming wrote:
I'm fine going ahead with Gordon's fix. I don't have a lot of time to dig
into the refcounting issue personally right now, but I'd at least leave the
bug open until we have made it through a bit more testing. I have an uneasy
feeling it (or
Sim g...@redhat.com
To: d...@qpid.apache.org
Cc: proton@qpid.apache.org
Sent: Tuesday, July 28, 2015 10:09:07 AM
Subject: Re: proton 0.10 blocker
On 07/20/2015 08:53 PM, Rafael Schloming wrote:
I'm fine going ahead with Gordon's fix. I don't have a lot of time to dig
into the refcounting
PROTON-905 reverted.
- Original Message -
From: Ken Giusti kgiu...@redhat.com
To: proton@qpid.apache.org
Cc: d...@qpid.apache.org
Sent: Tuesday, July 28, 2015 10:49:20 AM
Subject: Re: proton 0.10 blocker
Awww crap.
Let's revert the whole thing then. I always felt that 'fix
On 17 July 2015 at 23:32, Gordon Sim g...@redhat.com wrote:
On 07/17/2015 10:04 PM, Rafael Schloming wrote:
On Fri, Jul 17, 2015 at 12:47 PM, Gordon Sim g...@redhat.com wrote:
On 07/17/2015 08:15 PM, Rafael Schloming wrote:
On Fri, Jul 17, 2015 at 11:56 AM, Gordon Sim g...@redhat.com wrote:
, 2015 12:03:06 PM
Subject: Re: proton 0.10 blocker
On 17 July 2015 at 23:32, Gordon Sim g...@redhat.com wrote:
On 07/17/2015 10:04 PM, Rafael Schloming wrote:
On Fri, Jul 17, 2015 at 12:47 PM, Gordon Sim g...@redhat.com wrote:
On 07/17/2015 08:15 PM, Rafael Schloming wrote
On Thu, Jul 16, 2015 at 7:46 AM, Gordon Sim g...@redhat.com wrote:
On 07/16/2015 02:40 PM, aconway wrote:
Can someone who understand the proton use of refcounts please add some
doc comments to explain the semantics? Apologies if this is already
there and I missed it, tell me to RTFM.
I'm
Hi Gordon,
I did my best to dump some useful info on the refcounting stuff in the
other thread. I also posted a comment on the review. As I said there it
would be helpful to see the stack trace from the crash in order to figure
out if the fix is merely a workaround.
--Rafael
On Wed, Jul 15,
Still digesting the explanation (thanks!) but one follow up question:
On 07/17/2015 04:37 PM, Rafael Schloming wrote:
it isn't actually possible to use the object when there refcount is 0.
What is the purpose of the incref/decref pattern then, e.g. as used in
pn_session_free()? That is
On 07/17/2015 05:36 PM, Rafael Schloming wrote:
Hi Gordon,
I did my best to dump some useful info on the refcounting stuff in the
other thread. I also posted a comment on the review. As I said there it
would be helpful to see the stack trace from the crash in order to figure
out if the fix is
On Fri, Jul 17, 2015 at 10:45 AM, Gordon Sim g...@redhat.com wrote:
Still digesting the explanation (thanks!) but one follow up question:
On 07/17/2015 04:37 PM, Rafael Schloming wrote:
it isn't actually possible to use the object when there refcount is 0.
What is the purpose of the
On 07/17/2015 08:11 PM, Rafael Schloming wrote:
On Fri, Jul 17, 2015 at 10:45 AM, Gordon Sim g...@redhat.com wrote:
Still digesting the explanation (thanks!) but one follow up question:
On 07/17/2015 04:37 PM, Rafael Schloming wrote:
it isn't actually possible to use the object when there
On 07/17/2015 04:37 PM, Rafael Schloming wrote:
Are they really returned with a ref count of 0?
No, indeed they are not. I missed the fact that the finalizer will run
before the object is returned to the application.
On 07/16/2015 02:40 PM, aconway wrote:
The fix mentioned above has this, which make no sense under traditional
refcounting:
pn_incref(endpoint);
pn_decref(endpoint);
Note that this is not added as part of my fix, it is already there. The
simple explanation is that it is a
On 07/16/2015 02:40 PM, aconway wrote:
Can someone who understand the proton use of refcounts please add some
doc comments to explain the semantics? Apologies if this is already
there and I missed it, tell me to RTFM.
I'm not entirely sure I understand it. However having spent a couple of
On Thu, 2015-07-16 at 15:11 +0100, Gordon Sim wrote:
On 07/16/2015 02:40 PM, aconway wrote:
The fix mentioned above has this, which make no sense under
traditional
refcounting:
pn_incref(endpoint);
pn_decref(endpoint);
Note that this is not added as part of my
The latest proton code is causing crashes in qpid-cpp tests that use it.
I've tracked the problem down to the fix for PROTON-905[1] and proposed
an enhancement to that fix, https://reviews.apache.org/r/36509/, which
avoids the crash.
Could someone who understands the logic controlling the
16 matches
Mail list logo
