[Prototype-core] Re: prototype and js-packer

2007-08-08 Thread Mislav Marohnić
On 8/7/07, Andrew Dupont [EMAIL PROTECTED] wrote: No - that'd be incorrect in both cases. Semicolons are needed when a line is ended with the closing brace of a function literal or object literal, but not when a line is ended with the closing brace of a control structure. Agreed, but at

[Prototype-core] Re: prototype and js-packer

2007-08-08 Thread jdalton
Thanx :), Mislav what you saw as semi colons after conditionals was probably a trick of the eyes (though the first patch may have had one as a typo) with code like this: http://pastie.caboo.se/85947 As to semi colons after things like: var foo = function(){ alert('foobar'); }; This example

[Prototype-core] Re: prototype and js-packer

2007-08-08 Thread jdalton
by the way jdalton = John-David Dalton --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype: Core group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group,

[Prototype-core] tests fail in trunk head revision?

2007-08-08 Thread dk
Let me preface this message with the fact that I've never contributed to Prototype before. I've been able to to pull down source from svn trunk and rake it but the tests never seem to all succeed in both IE and Firefox. Is there a stable revision that I should be looking at or is the head of

[Prototype-core] Re: tests fail in trunk head revision?

2007-08-08 Thread Tom Gregory
FWIW, tests are failing for me in Safari (but worked in Firefox): /SVN/prototype/trunk $ svn update Updated to revision 7289. /SVN/prototype/trunk$ rake /SVN/prototype/trunk$ rake test (in /SVN/prototype/trunk) /test/unit/dom.html on Safari: FAILURE /test/unit/form.html on Safari: FAILURE

[Prototype-core] respondToReadyState never called for Complete

2007-08-08 Thread Brad Greenlee
I recently attempted to upgrade Prototype on our Rails project from 1.5.0_rc0 to 1.5.1.1 and RJS stopped working for us. I traced the problem down to this change: http://dev.rubyonrails.org/changeset/5574 It looks like _complete can only be set to true in respondToReadyState(4) (Complete), and