[Prototype-core] Re: use of getBoundingClientRect in prototype

2008-10-22 Thread Andrew Dupont
We're using it in the 1.6.1 branch. It's a bit preliminary, but feel free to help hack on it: http://github.com/savetheclocktower/prototype Cheers, Andrew On Oct 22, 6:27 pm, "Andrew Kaspick" <[EMAIL PROTECTED]> wrote: > Hello, > > I was just wondering why getBoundingClientRect isn't currently

[Prototype-core] Re: use of getBoundingClientRect in prototype

2008-10-22 Thread kangax
On Oct 22, 7:27 pm, "Andrew Kaspick" <[EMAIL PROTECTED]> wrote: > Hello, > > I was just wondering why getBoundingClientRect isn't currently used to > optimize the viewportOffset method in prototype?  Should be way faster > than traversing the dom tree. Yes, it should. We have tons of other stuff

[Prototype-core] Re: Prototype Selector Engine

2008-10-22 Thread Tobie Langel
Thanks for your write-up Diego. I'm actually well aware of your recent work and that of Samuel. Great stuff! (though I disagree with the the way you overly synthesize event bubbling). As I mentioned above, changing selector engine is not a top priority for Prototype right now, and would warrant s

[Prototype-core] Re: Prototype Selector Engine

2008-10-22 Thread Diego Perini
Tobie, would like to contribute with my NWMatcher selector engine if deemed adequate for the task. Would probably need a rewrite to fit style. I hope there is no need to say that Samuel Lebeau already did it in part, he rewrote it in a way that is probably more adequate to Prototype and has a mor

[Prototype-core] Re: Prototype Selector Engine

2008-10-22 Thread Tobie Langel
Proper benchmarking (i.e. something more reliable than slickspeed) would be very useful for making such a decision. Furthermore, I'd hate 1.6.1 to be delayed by such a change, especially given the fact that there's more important stuff to handle first (like the bug backlog, or dropping DOM elemen

[Prototype-core] use of getBoundingClientRect in prototype

2008-10-22 Thread Andrew Kaspick
Hello, I was just wondering why getBoundingClientRect isn't currently used to optimize the viewportOffset method in prototype? Should be way faster than traversing the dom tree. A related blog posting here... http://ejohn.org/blog/getboundingclientrect-is-awesome/ Thanks, Andrew --~--~---

[Prototype-core] Re: Prototype Selector Engine

2008-10-22 Thread Nick Stakenburg
Sizzle[1] is probably closer to a stable release, John mentioned releasing it before the end of the month. Looking at those benchmarks, having something similar wouldn't hurt (1.6.1?). [1] http://github.com/jeresig/sizzle/tree/master -- Nick On 22 okt, 15:58, Simon <[EMAIL PROTECTED]> wrote: >

[Prototype-core] Re: Prototype Selector Engine

2008-10-22 Thread Tobie Langel
>From what I've seen, Peppy relies on mutator events being triggered in IE. So I guess that the results will differ quite a bit once this is fixed. On Oct 22, 9:43 pm, kangax <[EMAIL PROTECTED]> wrote: > On Oct 22, 9:58 am, Simon <[EMAIL PROTECTED]> wrote: > > > Hi everyone, > > recently I heard

[Prototype-core] Re: Prototype Selector Engine

2008-10-22 Thread kangax
On Oct 22, 9:58 am, Simon <[EMAIL PROTECTED]> wrote: > Hi everyone, > recently I heard about Peppy (http://jamesdonaghue.com/?p=40), a new > selector engine that is definetly one of the fastest around (http:// > jamesdonaghue.com/static/peppy/profile/slickspeed/#). > > I was wondering if there was

[Prototype-core] Prototype Selector Engine

2008-10-22 Thread Simon
Hi everyone, recently I heard about Peppy (http://jamesdonaghue.com/?p=40), a new selector engine that is definetly one of the fastest around (http:// jamesdonaghue.com/static/peppy/profile/slickspeed/#). I was wondering if there was a main reason why prototype is so slow compared to it, is it al

[Prototype-core] Re: IE Bug

2008-10-22 Thread SWilk
Karthik wrote: > I am getting error in IE Browser for this line > newDivObj.addClassName( > addClassName is not working in IE Browsers including IE 7.0. Hi, This group is used for prototype.js' development and not for support questions. Next time please ask for help at prototype users group [1]

[Prototype-core] Re: IE Bug

2008-10-22 Thread kangax
Karthik wrote: > I am getting error in IE Browser for this line > > newDivObj.addClassName( > > addClassName is not working in IE Browsers including IE 7.0. > > Could anyone help me out from this? It works perfectly in Firefox. > It's not a bug. You need to extend an element explicitly: $(newD

[Prototype-core] IE Bug

2008-10-22 Thread Karthik
I am getting error in IE Browser for this line newDivObj.addClassName( addClassName is not working in IE Browsers including IE 7.0. Could anyone help me out from this? It works perfectly in Firefox. regards Karthik.R --~--~-~--~~~---~--~~ You received this messa

[Prototype-core] Re: a bug about prototype.js1.6.03

2008-10-22 Thread SWilk
101120 wrote: > i think there is something wrong with prototype.js1.6.03 about > "String.prototype.gsub", i think the right is: > > replace "result += String.interpret(replacement(match));" with "result > += String.interpret(replacement(match[0]));" > > you can test it with the example: > > 'fa