[Prototype-core] Re: out of memory exception in last version of protoculous

2008-05-02 Thread John-David Dalton
Turns out it was a firebug bug and not related to the compressed or minified files. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Prototype: Core" group. To post to this group, send email to prototype-core@google

[Prototype-core] Memory leak in IE; prototype version 1.5.1 and up. Caused by String.prototype.escapeHTML improvements

2008-05-02 Thread ggranum
We are seeing a very large memory leak in IE ( 6 7 and 8) when we open and close dialog windows from within our application. I narrowed it down to the following code change from version 1.5.0 to 1.5.1: -- if (Prototype.Browser.WebKit || Prototype.Browser.IE) Object.extend(String.prot

[Prototype-core] Re: Memory leak in IE; prototype version 1.5.1 and up. Caused by String.prototype.escapeHTML improvements

2008-05-02 Thread kangax
Ok, so attaching dom elements as properties of String.prototype.escapeHTML causes leaks. What about keeping them in a closure? escapeHTML: (function() { var div = document.createElement('div'), text; div.appendChild(text = document.createTextNode('')); return function() { text.data = th

[Prototype-core] Re: Memory leak in IE; prototype version 1.5.1 and up. Caused by String.prototype.escapeHTML improvements

2008-05-02 Thread John-David Dalton
Patch addresses the memory leak: http://github.com/jdalton/prototype/commit/0353246ac2ad439260905799798f0069d9a7d0ca Patch addresses other issues with escapeHTML and unescapeHTML: http://github.com/jdalton/prototype/commit/6010a300c39b0c66394706e9edb8b110b5932d9e Unit tests for the patch: http:/

[Prototype-core] Re: Memory leak in IE; prototype version 1.5.1 and up. Caused by String.prototype.escapeHTML improvements

2008-05-02 Thread kangax
Ah, I missed the "hold on to all references on page unload" part : ) John, wouldn't it make sense to null the references in "purgeListeners" function (since it's already attached to "unload")? - kangax On May 2, 6:30 pm, John-David Dalton <[EMAIL PROTECTED]> wrote: > Patch addresses the memory

[Prototype-core] Re: Memory leak in IE; prototype version 1.5.1 and up. Caused by String.prototype.escapeHTML improvements

2008-05-02 Thread ggranum
I was wondering if some of the code I saw in the upcoming 1.6.0.3 milestone might have addressed this. I should have mentioned that, apologies. The tentative fix I outlined above doesn't seem to leak; the original leak was *very* obvious due to the number of nested frames in the child window that