[Prototype-core] Re: Style Guide for rewrite branch

2008-11-14 Thread Nick Stakenburg
If a feature test ends up being used in various sections (dom, event, string..) deciding on proper placement could become a problem. I think it's easier to keep feature tests in one place. Prototype.BrowserFeatures doesn't seem like the right place for those tests since both features and bugs

[Prototype-core] Re: Style Guide for rewrite branch

2008-11-14 Thread Tobie Langel
Just a couple of short notes: How about not having to run every single one of those tests upfront? If tests are defined in let's say Feature.tests they can be run only when required instead of upfront. That would prevent running complex tests you don't end up using. Let's not prematurely

[Prototype-core] Re: Style Guide for rewrite branch

2008-11-14 Thread artemy tregubenko
On Fri, 14 Nov 2008 01:59:07 +0300, kangax [EMAIL PROTECTED] wrote: My only concern about this pattern is memory usage. There are many functions created during branching process, yet only one is returned/ assigned (and is then used throughout the rest of the application life). Those