[Prototype-core] Re: Bug! Function.bindAsEventListener() appends Event object twice to arguments...

2007-04-28 Thread jdalton

Cool,

ya I was wondering why they used the funcArgs too. Good work 8).

- JD


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Prototype: Core" group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---



[Prototype-core] Re: Bug! Function.bindAsEventListener() appends Event object twice to arguments...

2007-04-27 Thread Mislav Marohnić
On 4/27/07, jdalton <[EMAIL PROTECTED]> wrote:
>
> Thats a bug right?


Yea. Take a look at the event branch, you'll see that it's solved there:
http://dev.rubyonrails.org/browser/spinoffs/prototype/branches/event/src/base.js?rev=6194#L56

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Prototype: Core" group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---



[Prototype-core] Re: Bug! Function.bindAsEventListener() appends Event object twice to arguments...

2007-04-27 Thread jdalton

I mean, most users don't expect that the Event object
is the first and second param and the documentation doesnt mention
that.

The author of the ticket suggested dropping the addition of the event
object.
I know its needed for some versions of IE so thats why my fix attempts
to detect the presence of the Event object
as the first param and if not found adds it then. This would avoid
having the first and second param being the
Event object.



--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Prototype: Core" group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---



[Prototype-core] Re: Bug! Function.bindAsEventListener() appends Event object twice to arguments...

2007-04-27 Thread jdalton

Thats a bug right?


--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Prototype: Core" group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---



[Prototype-core] Re: Bug! Function.bindAsEventListener() appends Event object twice to arguments...

2007-04-27 Thread Mislav Marohnić
On 4/27/07, jdalton <[EMAIL PROTECTED]> wrote:
>
>
> Well. It turns out now that the event object is the first and second
> param


http://dev.rubyonrails.org/ticket/6497

Searching is super!

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"Prototype: Core" group.
To post to this group, send email to prototype-core@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/prototype-core?hl=en
-~--~~~~--~~--~--~---