failing testcase is here:
http://prototype.lighthouseapp.com/projects/8886-prototype/tickets/83
On May 7, 2:21 pm, Viktor Kojouharov <[EMAIL PROTECTED]> wrote:
> will do. but I can't run the test right now, since rake fails with the
> following error:
>
> ** Execute package
> rake aborted!
> Don'
will do. but I can't run the test right now, since rake fails with the
following error:
** Execute package
rake aborted!
Don't know how to build task 'clean_package_source'
I'm not a ruby user, and I've no idea how to fix this. This happens on
a fresh clone.
On May 7, 2:00 pm, Tobie Langel <[EM
Please open a bug report for this (http://prototypejs.org/contribute)
and submit a failing test case.
Thank you.
Tobie
On May 7, 12:49 pm, Viktor Kojouharov <[EMAIL PROTECTED]> wrote:
> That was just to illustrate the problem. I'm not actually calling
> document.createEventObject. I'm calling O
That was just to illustrate the problem. I'm not actually calling
document.createEventObject. I'm calling Object.isHash on the event,
which i get inside the click handler. The event itself is not null, I
can assure you of that. Furthermore, it does have the recordset key,
since I use Object.keys t
Hi again,
The problem imho is that document.createEventObject() returns null or
undefined, therefore, calling recordset on it throws an error.
Not realted to Object.isHash but to your own code.
Try the folowing:
var e = document.createEventObject();
Object.isHash(e && e.recordset);
Which shou
Hi again,
Try testing it in IE(6) with this:
Object.isHash(document.createEventObject().recordset)
On May 7, 1:16 pm, Viktor Kojouharov <[EMAIL PROTECTED]> wrote:
> I can't reproduce it with 'regular' nulls, but it fails every time, if
> I pass it event.recordset. I don't know what that event
I can't reproduce it with 'regular' nulls, but it fails every time, if
I pass it event.recordset. I don't know what that event property is,
probably something specific to IE. But Object.isHash throws an error
with it.
On May 7, 1:09 pm, Tobie Langel <[EMAIL PROTECTED]> wrote:
> I can't reproduce
Hi again,
Added some tests:
http://github.com/sstephenson/prototype/commit/1204b07b0645390e5718be98d3c58b6f5e9b41cf
All pass in IE6.
Best,
Tobie
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
"Prototype: Core" g
I can't reproduce this.
Best,
Tobie
On May 7, 12:03 pm, Viktor Kojouharov <[EMAIL PROTECTED]> wrote:
> As the subject says, if the object, passed to the isHash function is
> null, IE6 will throw an exception. This simple diff fixes the problem:
>
> http://pastie.caboo.se/192906
--~--~-~
