[Proto-Scripty] Re: When to expect code changes to be added to Prototype.
It has been closed by lighthouse robot. It seems normal that there is not much activity on this ticket :(( -- david On 8 sep, 12:28, FigglesKoy figgles...@gmail.com wrote: I managed to find the lighthouse ticket (had to Google it):https://prototype.lighthouseapp.com/projects/8886/tickets/318-wiktor-... . The page lists the link I have above for the code itself and the last milestone change was to 1.6.1. I checked the 1.6.1 milestone and ticket 318 is there and listed as resolved. On Sep 5, 12:17 pm, Rick Waldron waldron.r...@gmail.com wrote: I wasn't previously aware of this enhancement (which is most def. is)... however re: TJ's reply, I think support for something like this is quite appropriate, as i know the jQuery does support the use of multiple selector expressions sep. by commas. Rick On Fri, Sep 4, 2009 at 11:49 AM, T.J. Crowder t...@crowdersoftware.comwrote: Hi, The Lighthouse ticket should still be there. If you filed the ticket, you should be able to see it by searching for all tickets created by you. Hopefully that would shed light on the issue. You've said there's a fix to Prototype...but what you describe is an enhancement, isn't it? Very big difference between enhancements and fixes. It may well be that the Core team didn't think that supporting multiple expressions in that way was appropriate for the project. -- T.J. Crowder tj / crowder software / com www.crowdersoftware.com On Sep 4, 3:10 pm, FigglesKoy figgles...@gmail.com wrote: There's a fix to Prototype that I've been waiting for a while to see. Specifically, that the Element.match method would support commas to support checking for multiple rules in a single call i.e. match ('DIV.aClass, DIV.bClass'). Thing is, this has been fixed online for a while, but it has never made it to a Prototype release and I'm not sure why. The github commit is here (http://github.com/sstephenson/ prototype/commit/afd74ce1c72a17666d8c9d86131463ad73cafe9e) and if I'm reading it correctly, its been there since November of last year. However, even in the latest 1.6.1 release, it is not present. I can no longer find it on the lighthouse page though I did at one time. I believe it was attached to milestone 1.6.0.4, which seems to not exist any more. I can manually add the code in for now but if this won't be in subsequent releases, then I will have to remember to add it back in each time I upgrade. So I guess I'm just looking for some explanation on how to know when/if some code commit will be added to a future release. Thanks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype script.aculo.us group. To post to this group, send email to prototype-scriptaculous@googlegroups.com To unsubscribe from this group, send email to prototype-scriptaculous+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/prototype-scriptaculous?hl=en -~--~~~~--~~--~--~---
[Proto-Scripty] Re: When to expect code changes to be added to Prototype.
@FigglesKoy: Looks like a missed pull, or after Andrew committed that (which automatically closed the ticket) there was a good reason found to leave it out (whatever that might be). You might want to reopen the ticket to put it back on the radar. @Rick: I wasn't saying *I* thought it was a bad idea. :-) -- T.J. On Sep 8, 12:28 pm, david david.brill...@gmail.com wrote: It has been closed by lighthouse robot. It seems normal that there is not much activity on this ticket :(( -- david On 8 sep, 12:28, FigglesKoy figgles...@gmail.com wrote: I managed to find the lighthouse ticket (had to Google it):https://prototype.lighthouseapp.com/projects/8886/tickets/318-wiktor-... . The page lists the link I have above for the code itself and the last milestone change was to 1.6.1. I checked the 1.6.1 milestone and ticket 318 is there and listed as resolved. On Sep 5, 12:17 pm, Rick Waldron waldron.r...@gmail.com wrote: I wasn't previously aware of this enhancement (which is most def. is)... however re: TJ's reply, I think support for something like this is quite appropriate, as i know the jQuery does support the use of multiple selector expressions sep. by commas. Rick On Fri, Sep 4, 2009 at 11:49 AM, T.J. Crowder t...@crowdersoftware.comwrote: Hi, The Lighthouse ticket should still be there. If you filed the ticket, you should be able to see it by searching for all tickets created by you. Hopefully that would shed light on the issue. You've said there's a fix to Prototype...but what you describe is an enhancement, isn't it? Very big difference between enhancements and fixes. It may well be that the Core team didn't think that supporting multiple expressions in that way was appropriate for the project. -- T.J. Crowder tj / crowder software / com www.crowdersoftware.com On Sep 4, 3:10 pm, FigglesKoy figgles...@gmail.com wrote: There's a fix to Prototype that I've been waiting for a while to see. Specifically, that the Element.match method would support commas to support checking for multiple rules in a single call i.e. match ('DIV.aClass, DIV.bClass'). Thing is, this has been fixed online for a while, but it has never made it to a Prototype release and I'm not sure why. The github commit is here (http://github.com/sstephenson/ prototype/commit/afd74ce1c72a17666d8c9d86131463ad73cafe9e) and if I'm reading it correctly, its been there since November of last year. However, even in the latest 1.6.1 release, it is not present. I can no longer find it on the lighthouse page though I did at one time. I believe it was attached to milestone 1.6.0.4, which seems to not exist any more. I can manually add the code in for now but if this won't be in subsequent releases, then I will have to remember to add it back in each time I upgrade. So I guess I'm just looking for some explanation on how to know when/if some code commit will be added to a future release. Thanks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype script.aculo.us group. To post to this group, send email to prototype-scriptaculous@googlegroups.com To unsubscribe from this group, send email to prototype-scriptaculous+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/prototype-scriptaculous?hl=en -~--~~~~--~~--~--~---
[Proto-Scripty] Re: When to expect code changes to be added to Prototype.
I wasn't previously aware of this enhancement (which is most def. is)... however re: TJ's reply, I think support for something like this is quite appropriate, as i know the jQuery does support the use of multiple selector expressions sep. by commas. Rick On Fri, Sep 4, 2009 at 11:49 AM, T.J. Crowder t...@crowdersoftware.comwrote: Hi, The Lighthouse ticket should still be there. If you filed the ticket, you should be able to see it by searching for all tickets created by you. Hopefully that would shed light on the issue. You've said there's a fix to Prototype...but what you describe is an enhancement, isn't it? Very big difference between enhancements and fixes. It may well be that the Core team didn't think that supporting multiple expressions in that way was appropriate for the project. -- T.J. Crowder tj / crowder software / com www.crowdersoftware.com On Sep 4, 3:10 pm, FigglesKoy figgles...@gmail.com wrote: There's a fix to Prototype that I've been waiting for a while to see. Specifically, that the Element.match method would support commas to support checking for multiple rules in a single call i.e. match ('DIV.aClass, DIV.bClass'). Thing is, this has been fixed online for a while, but it has never made it to a Prototype release and I'm not sure why. The github commit is here (http://github.com/sstephenson/ prototype/commit/afd74ce1c72a17666d8c9d86131463ad73cafe9e) and if I'm reading it correctly, its been there since November of last year. However, even in the latest 1.6.1 release, it is not present. I can no longer find it on the lighthouse page though I did at one time. I believe it was attached to milestone 1.6.0.4, which seems to not exist any more. I can manually add the code in for now but if this won't be in subsequent releases, then I will have to remember to add it back in each time I upgrade. So I guess I'm just looking for some explanation on how to know when/if some code commit will be added to a future release. Thanks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype script.aculo.us group. To post to this group, send email to prototype-scriptaculous@googlegroups.com To unsubscribe from this group, send email to prototype-scriptaculous+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/prototype-scriptaculous?hl=en -~--~~~~--~~--~--~---
[Proto-Scripty] Re: When to expect code changes to be added to Prototype.
Hi, The Lighthouse ticket should still be there. If you filed the ticket, you should be able to see it by searching for all tickets created by you. Hopefully that would shed light on the issue. You've said there's a fix to Prototype...but what you describe is an enhancement, isn't it? Very big difference between enhancements and fixes. It may well be that the Core team didn't think that supporting multiple expressions in that way was appropriate for the project. -- T.J. Crowder tj / crowder software / com www.crowdersoftware.com On Sep 4, 3:10 pm, FigglesKoy figgles...@gmail.com wrote: There's a fix to Prototype that I've been waiting for a while to see. Specifically, that the Element.match method would support commas to support checking for multiple rules in a single call i.e. match ('DIV.aClass, DIV.bClass'). Thing is, this has been fixed online for a while, but it has never made it to a Prototype release and I'm not sure why. The github commit is here (http://github.com/sstephenson/ prototype/commit/afd74ce1c72a17666d8c9d86131463ad73cafe9e) and if I'm reading it correctly, its been there since November of last year. However, even in the latest 1.6.1 release, it is not present. I can no longer find it on the lighthouse page though I did at one time. I believe it was attached to milestone 1.6.0.4, which seems to not exist any more. I can manually add the code in for now but if this won't be in subsequent releases, then I will have to remember to add it back in each time I upgrade. So I guess I'm just looking for some explanation on how to know when/if some code commit will be added to a future release. Thanks. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Prototype script.aculo.us group. To post to this group, send email to prototype-scriptaculous@googlegroups.com To unsubscribe from this group, send email to prototype-scriptaculous+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/prototype-scriptaculous?hl=en -~--~~~~--~~--~--~---