[Proto-Scripty] Re: sound.js bug

2008-12-05 Thread Jerod Venema
The second argument should be an anonymous object. This should work:

play('http://myurl.com/sound.wav', { replace: true });

On Fri, Dec 5, 2008 at 1:29 PM, Bill Walton [EMAIL PROTECTED] wrote:

 I think I've found a bug in the latest release of sound.js.

 This is the code in sound.js

 play: function(url){
   if(!Sound._enabled) return;
   var options = Object.extend({
 track: 'global', url: url, replace: false
   }, arguments[1] || {});



 In order to get the replace to work (to eliminate double-ding), I had to
 change it to...

   play: function(url){
 if(!Sound._enabled) return;
 var options = Object.extend({
   track: 'global', url: url, replace: arguments[1] || {} });

 I'm not real strong in JavaScript, but it looks to me like replace is
 hardcoded in the lates release.  At least, I couldn't get it to change.  Am
 I doing something wrong?  Or is this a bug?

 TIA from Texas!
 Bill


 



-- 
Jerod Venema
Frozen Mountain Software
http://www.frozenmountain.com/
919-368-5105

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Prototype  script.aculo.us group.
To post to this group, send email to prototype-scriptaculous@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/prototype-scriptaculous?hl=en
-~--~~~~--~~--~--~---



[Proto-Scripty] Re: sound.js bug

2008-12-05 Thread Jerod Venema
D'you have the code up somewhere that I can take a look at? If not, I'll set
one up...

On Fri, Dec 5, 2008 at 7:26 PM, bill walton [EMAIL PROTECTED] wrote:


 Hi Jerod,

 Update below.  I would really appreciate your, or anyone else's,
 feedback/help on this.  I figured making three simple sounds would be
 simple.  ;-(

 On Dec 5, 1:53 pm, Jerod Venema [EMAIL PROTECTED] wrote:
  The second argument should be an anonymous object. This should work:
 
  play('http://myurl.com/sound.wav', { replace: true });
 
 
  On Fri, Dec 5, 2008 at 1:29 PM, Bill Walton [EMAIL PROTECTED]
 wrote:
   I think I've found a bug in the latest release of sound.js.
 
   This is the code in sound.js
 
   play: function(url){
 if(!Sound._enabled) return;
 var options = Object.extend({
   track: 'global', url: url, replace: false
 }, arguments[1] || {});
 
   In order to get the replace to work (to eliminate double-ding), I had
 to
   change it to...
 
 play: function(url){
   if(!Sound._enabled) return;
   var options = Object.extend({
 track: 'global', url: url, replace: arguments[1] || {} });

 The code that immediately follows the above is this...

if(options.replace  this.tracks[options.track]) {
  $R(0, this.tracks[options.track].id).each(function(id){
var sound = $('sound_'+options.track+'_'+id);
sound.Stop  sound.Stop();
sound.remove();
  });
  this.tracks[options.track] = null;
}

 In FF2, walking through the script with a breakpoint set on the '$R'
 line, I see this in the 'watch' window (the right pane in the FireBug
 panel):

 with my code it shows ...

 New watch expression...
 + this   Object tracks=Object _enabled=true template=Object
 - optionsObject track=global
 url=../sounds/item_found.wav
  - replace  Object replace=true
   replace   true
track global
url ../sounds/item_found.wav
 url ../sounds/item_found.wav


 with latest sound.js code it shows ...

 New watch expression...
 + thisObject tracks=Object _enabled=true template=Object
 - optionsObject track=global
 url=../sounds/item_found.wav
  replace true
  trackglobal
  url../sounds/item_found.wav
 url  ../sounds/item_found.wav

 I looks like sound.js is not creating the anonymous object.  Or am I
 misunderstanding what I'm seeing?

 Thanks,
 Bill
 



-- 
Jerod Venema
Frozen Mountain Software
http://www.frozenmountain.com/
919-368-5105

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Prototype  script.aculo.us group.
To post to this group, send email to prototype-scriptaculous@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/prototype-scriptaculous?hl=en
-~--~~~~--~~--~--~---