Re: PATCH for review

2017-03-27 Thread Ben Pfaff
On Fri, Mar 24, 2017 at 08:40:01PM +0100, John Darrington wrote: > On Fri, Mar 24, 2017 at 12:30:20PM -0700, Ben Pfaff wrote: > > That adds a reference to html.at, but what's in html.at? > > Ahh sorry. Updated patch follows: Seems reasonable, thanks. _

Re: PATCH for review

2017-03-24 Thread John Darrington
On Fri, Mar 24, 2017 at 12:30:20PM -0700, Ben Pfaff wrote: That adds a reference to html.at, but what's in html.at? Ahh sorry. Updated patch follows: From fa1e2f50efc0b7b8a9436b40568eadf03feae9dc Mon Sep 17 00:00:00 2001 From: John Darrington Date: Fri, 24 Mar 2017 17:40:39 +0100 Su

Re: PATCH for review

2017-03-24 Thread Ben Pfaff
On Fri, Mar 24, 2017 at 07:49:39PM +0100, John Darrington wrote: > On Fri, Mar 24, 2017 at 11:08:55AM -0700, Ben Pfaff wrote: > On Fri, Mar 24, 2017 at 05:47:42PM +0100, John Darrington wrote: > > This fix avoids a bug where the driver would enter a tight loop when > rendering cells >

Re: PATCH for review

2017-03-24 Thread John Darrington
On Fri, Mar 24, 2017 at 11:08:55AM -0700, Ben Pfaff wrote: On Fri, Mar 24, 2017 at 05:47:42PM +0100, John Darrington wrote: > This fix avoids a bug where the driver would enter a tight loop when rendering cells > with zero height or width. This appears to add a new HTML o

Re: PATCH for review

2017-03-24 Thread Ben Pfaff
On Fri, Mar 24, 2017 at 05:47:42PM +0100, John Darrington wrote: > This fix avoids a bug where the driver would enter a tight loop when > rendering cells > with zero height or width. This appears to add a new HTML output driver testsuite, but it doesn't include the html.at file.

Re: patch for review

2013-10-03 Thread John Darrington
On Wed, Oct 02, 2013 at 09:56:05PM -0700, Ben Pfaff wrote: On Wed, Oct 02, 2013 at 04:39:06PM +0200, John Darrington wrote: > I'd appreciate a review of this patch before I push it. Thanks. The old code and the new code make sense to me, I think. It's not obvious to me h

Re: patch for review

2013-10-02 Thread Ben Pfaff
On Wed, Oct 02, 2013 at 04:39:06PM +0200, John Darrington wrote: > I'd appreciate a review of this patch before I push it. Thanks. The old code and the new code make sense to me, I think. It's not obvious to me how it will simplify upcoming code (or what that code will do), but it seems fine. I

Re: Re: Patch for review

2013-05-24 Thread John Darrington
On Mon, May 20, 2013 at 01:54:47PM +0200, Harry Thijssen wrote: In my new MSWindows build, importing a spreadsheet file, results in getting the comma-separated-value wizard. Was that your intention? The "Text Import Dialog" has been generalised to a "Import Dialog". That is to say

Re: Patch for review

2013-05-24 Thread Ben Pfaff
I didn't realize that it used a missing function. Of course, then it makes sense to apply your original patch. Thanks! On Fri, May 24, 2013 at 04:17:49PM +0200, John Darrington wrote: > It would certainly make sense to follow what the Gtk devs are doing where > possible. > However that patch we

Re: Patch for review

2013-05-24 Thread John Darrington
It would certainly make sense to follow what the Gtk devs are doing where possible. However that patch we can't apply to master, because it uses a function which does not exist in Gtk2.16 which is what we depend upon. I'll think about starting a Gtk3-transition branch and apply it to that. J' O

Re: Patch for review

2013-05-20 Thread Ben Pfaff
On Mon, May 20, 2013 at 07:33:19AM +0200, John Darrington wrote: > A small patch - I think it is safe. But a second opinion would be > appreciated. It looks OK at first glance. But here is the corresponding patch from the GTK+ repository that makes the same change to GtkTreeView. It might be be

Re: Re: Patch for review

2013-05-20 Thread Harry Thijssen
<20130518152952.ga12...@blp.benpfaff.org> > On Wed, May 15, 2013 at 07:16:58PM +0200, John Darrington wrote: > > Here is a patch for review. It implements another "page" in the Import > Assistant to facilitate > > the import of spreadsheets using th

Re: Patch for review

2013-05-18 Thread Ben Pfaff
On Wed, May 15, 2013 at 07:16:58PM +0200, John Darrington wrote: > Here is a patch for review. It implements another "page" in the Import > Assistant to facilitate > the import of spreadsheets using the GUI. Thank you. This looks OK to me. Also, I think it's a very useful new feature. ___

Re: Patch for review

2013-05-15 Thread Ben Pfaff
On Wed, May 15, 2013 at 07:16:58PM +0200, John Darrington wrote: > Here is a patch for review. It implements another "page" in the Import > Assistant to facilitate > the import of spreadsheets using the GUI. Thanks for working on this feature! I've been away for a few days at a conference. I'l

Re: Patch for review

2013-04-25 Thread Ben Pfaff
On Fri, Apr 26, 2013 at 07:54:12AM +0200, John Darrington wrote: > On Thu, Apr 25, 2013 at 10:35:15AM -0700, Ben Pfaff wrote: > > I don't think I'd be sad if we got rid of all the .q files eventually. > > There are only 3 left. I don't think it would be a very onerous task. True.

Re: Patch for review

2013-04-25 Thread John Darrington
On Thu, Apr 25, 2013 at 10:35:15AM -0700, Ben Pfaff wrote: I don't think I'd be sad if we got rid of all the .q files eventually. There are only 3 left. I don't think it would be a very onerous task. J' -- PGP Public key ID: 1024D/2DE827B3 fingerprint = 8797 A26D 0854 2EAB 028

Re: Patch for review

2013-04-25 Thread Ben Pfaff
On Thu, Apr 25, 2013 at 06:40:19PM +0200, John Darrington wrote: > Here is a patch which changes list.q into list.c - it seemed to me > that this .q file wasn't bringing us much benefit. Seems reasonable to me, as long as the tests still pass. I don't think I'd be sad if we got rid of all the .q

Re: Patch for review

2013-04-16 Thread Ben Pfaff
Thanks! On Tue, Apr 16, 2013 at 1:17 PM, John Darrington < j...@darrington.wattle.id.au> wrote: > Thanks. > > I've pushed it with all your suggestions included, except that I have > not bothered to replace select with poll. Personally I find select > easier to understand, although it is a litt

Re: Patch for review

2013-04-16 Thread John Darrington
Thanks. I've pushed it with all your suggestions included, except that I have not bothered to replace select with poll. Personally I find select easier to understand, although it is a little more verbose. J' On Mon, Apr 15, 2013 at 10:07:34PM -0700, Ben Pfaff wrote: This looks good to

Re: Patch for review

2013-04-15 Thread Ben Pfaff
On Sun, Apr 14, 2013 at 05:37:19PM +0200, John Darrington wrote: > This patch should be self-explanitory, but profound enough to warrant > a review. This looks good to me. I have some nits to pick: According to Google, "interruptible" is the correct spelling (not -able). The code would be a lit

Re: patch for review: Fix error message for bad characters in syntax files.

2009-03-27 Thread Ben Pfaff
Thanks, I pushed both of these. John Darrington writes: > Fine by me. > > On Thu, Mar 26, 2009 at 09:13:57PM -0700, Ben Pfaff wrote: > commit 0aebb03b1f9c3a4a0dd99b715f13dc044540a0bd > Author: Ben Pfaff > Date: Thu Mar 26 21:11:12 2009 -0700 John Darrington writes: > Fine by

Re: patch for review: Fix error message for bad characters in syntax files.

2009-03-26 Thread John Darrington
Fine by me. On Thu, Mar 26, 2009 at 09:13:57PM -0700, Ben Pfaff wrote: This is aimed at "stable". commit 0aebb03b1f9c3a4a0dd99b715f13dc044540a0bd Author: Ben Pfaff Date: Thu Mar 26 21:11:12 2009 -0700 Fix error message for bad characters in syntax files.

Re: patch for review: Fix memory leak in wilcoxon_execute().

2009-03-26 Thread John Darrington
Fine by me. On Thu, Mar 26, 2009 at 09:29:22PM -0700, Ben Pfaff wrote: This is aimed at "stable". Comments? commit f500d6df5351c40c4758673372c95c653e1fdc01 Author: Ben Pfaff Date: Sun Jan 18 20:10:43 2009 -0800 Fix memory leak in wilcoxon_execute().

Re: patch for review: Fix memory leak in wilcoxon_execute().

2009-03-26 Thread Ben Pfaff
Ben Pfaff writes: > This is aimed at "stable". Comments? Actually, it won't apply to stable. It's aimed at master. -- Ben Pfaff http://benpfaff.org ___ pspp-dev mailing list pspp-dev@gnu.org http://lists.gnu.org/mailman/listinfo/pspp-dev