[ptxdist] [PATCH] [coreutils] Remove unused library libstdbuf.so

2010-06-22 Thread Alexander Stein
Is the libstdbuf.so from coreutils really used in some applets? The first 
install_copy in coreutils.targetinstall is to install this library to 
/usr/lib/coreutils/libstdbuf.so
It seems to me, that no coreutils applet link itself to libstdbuf.so. I ran the 
following command from the packages/coreutils-8.2 directory where all applets 
should be installed.
 # find . -type f -perm -1 | xargs readelf -a | grep NEEDED | sort | uniq
 0x0001 (NEEDED) Shared library: [libc.so.6]
 0x0001 (NEEDED) Shared library: [libgcc_s.so.1]
 0x0001 (NEEDED) Shared library: [libm.so.6]
 0x0001 (NEEDED) Shared library: [librt.so.1]

In my opinion, this should be removed at all.

Signed-off-by: Alexander Stein alexander.st...@systec-electronic.com
---
 rules/coreutils.make |2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/rules/coreutils.make b/rules/coreutils.make
index f85598a..7ee1da6 100644
--- a/rules/coreutils.make
+++ b/rules/coreutils.make
@@ -90,8 +90,6 @@ $(STATEDIR)/coreutils.targetinstall:
@$(call install_fixup, coreutils,DEPENDS,)
@$(call install_fixup, coreutils,DESCRIPTION,missing)
 
-   @$(call install_copy, coreutils, 0, 0, 0644, -, 
/usr/lib/coreutils/libstdbuf.so)
-
 ifdef PTXCONF_COREUTILS_ECHO
@$(call install_copy, coreutils, 0, 0, 0755, -, /usr/bin/echo)
 endif
-- 
1.7.1


-- 
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH] [coreutils] Remove unused library libstdbuf.so

2010-06-22 Thread Marc Kleine-Budde
Alexander Stein wrote:
 Is the libstdbuf.so from coreutils really used in some applets? The first 
 install_copy in coreutils.targetinstall is to install this library to 
 /usr/lib/coreutils/libstdbuf.so
 It seems to me, that no coreutils applet link itself to libstdbuf.so. I ran 
 the following command from the packages/coreutils-8.2 directory where all 
 applets should be installed.
 # find . -type f -perm -1 | xargs readelf -a | grep NEEDED | sort | uniq
 0x0001 (NEEDED) Shared library: [libc.so.6]
 0x0001 (NEEDED) Shared library: [libgcc_s.so.1]
 0x0001 (NEEDED) Shared library: [libm.so.6]
 0x0001 (NEEDED) Shared library: [librt.so.1]
 
 In my opinion, this should be removed at all.

what about dynamic loading via dlopen()?

Marc

-- 
Pengutronix e.K.  | Marc Kleine-Budde   |
Industrial Linux Solutions| Phone: +49-231-2826-924 |
Vertretung West/Dortmund  | Fax:   +49-5121-206917- |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |



signature.asc
Description: OpenPGP digital signature
-- 
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] [PATCH] [coreutils] Remove unused library libstdbuf.so

2010-06-22 Thread Michael Olbrich
On Tue, Jun 22, 2010 at 01:36:16PM +0200, Marc Kleine-Budde wrote:
 Alexander Stein wrote:
  Is the libstdbuf.so from coreutils really used in some applets? The first 
  install_copy in coreutils.targetinstall is to install this library to 
  /usr/lib/coreutils/libstdbuf.so
  It seems to me, that no coreutils applet link itself to libstdbuf.so. I ran 
  the following command from the packages/coreutils-8.2 directory where all 
  applets should be installed.
  # find . -type f -perm -1 | xargs readelf -a | grep NEEDED | sort | uniq
  0x0001 (NEEDED) Shared library: [libc.so.6]
  0x0001 (NEEDED) Shared library: [libgcc_s.so.1]
  0x0001 (NEEDED) Shared library: [libm.so.6]
  0x0001 (NEEDED) Shared library: [librt.so.1]
  
  In my opinion, this should be removed at all.
 
 what about dynamic loading via dlopen()?

it is used by stdbuf as a LD_PRELOAD library. The correct fix would be to
use ifdef PTXCONF_COREUTILS_STDBUF

mol

-- 
Pengutronix e.K.   | |
Industrial Linux Solutions | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

-- 
ptxdist mailing list
ptxdist@pengutronix.de