Re: [ptxdist] (EXT) Re: [PATCH] kmscube: switch to https URL

2020-02-15 Thread Michael Olbrich
On Fri, Feb 14, 2020 at 09:53:41AM +0100, Matthias Schiffer wrote:
> On Fri, 2020-02-14 at 09:40 +0100, Michael Olbrich wrote:
> > On Thu, Feb 13, 2020 at 06:22:03PM +0100, Matthias Schiffer wrote:
> > > From: Markus Niebel 
> > > 
> > > Signed-off-by: Markus Niebel 
> > > Signed-off-by: Matthias Schiffer  > > >
> > > ---
> > >  rules/kmscube.make | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/rules/kmscube.make b/rules/kmscube.make
> > > index a6d5d0150..94a2f31fa 100644
> > > --- a/rules/kmscube.make
> > > +++ b/rules/kmscube.make
> > > @@ -18,7 +18,7 @@ PACKAGES-$(PTXCONF_KMSCUBE) += kmscube
> > >  KMSCUBE_VERSION  := 2017-03-13-g803bac5
> > >  KMSCUBE  := kmscube-$(KMSCUBE_VERSION)
> > >  KMSCUBE_MD5  := 781a59ab2d1d245e99a49df7c3dc1876
> > > -KMSCUBE_URL  :=
> > > git://anongit.freedesktop.org/mesa/kmscube;tag=$(KMSCUBE_VERSION)
> > > +KMSCUBE_URL  := 
> > > https://gitlab.freedesktop.org/mesa/kmscube.git;tag=$(KMSCUBE_VERSION
> > > )
> > 
> > With gitlab, we can avoid git entirely:
> > 
> > 
> https://gitlab.freedesktop.org/mesa/kmscube/-/archive/$(KMSCUBE_VERSION)/$(KMSCUBE).$(KMSCUBE_SUFFIX
> > )
> > 
> > Should work.
> > 
> > Michael
> 
> Are these archive downloads guaranteed to have stable MD5 sums with
> Gitlab? I know that the OpenWrt project generally avoids archive
> downloads from Github for this reason.

We use those all the time (for github and gitlab) and I've not had any
problems with this. It's just a 'git archive' anyways: The md5 sum doesn't
even change from the current one.

Michael

> Matthias
> 
> 
> > 
> > >  KMSCUBE_SUFFIX   := tar.gz
> > >  KMSCUBE_SOURCE   := $(SRCDIR)/$(KMSCUBE).$(KMSCUBE_SUFFIX)
> > >  KMSCUBE_DIR  := $(BUILDDIR)/$(KMSCUBE)
> > > -- 
> > > 2.17.1
> > > 
> > > 
> > > ___
> > > ptxdist mailing list
> > > ptxdist@pengutronix.de
> > > 
> > 
> > 
> 
> 
> ___
> ptxdist mailing list
> ptxdist@pengutronix.de
> 

-- 
Pengutronix e.K.   | |
Steuerwalder Str. 21   | http://www.pengutronix.de/  |
31137 Hildesheim, Germany  | Phone: +49-5121-206917-0|
Amtsgericht Hildesheim, HRA 2686   | Fax:   +49-5121-206917- |

___
ptxdist mailing list
ptxdist@pengutronix.de


Re: [ptxdist] (EXT) Re: [PATCH] kmscube: switch to https URL

2020-02-14 Thread Matthias Schiffer
On Fri, 2020-02-14 at 09:40 +0100, Michael Olbrich wrote:
> On Thu, Feb 13, 2020 at 06:22:03PM +0100, Matthias Schiffer wrote:
> > From: Markus Niebel 
> > 
> > Signed-off-by: Markus Niebel 
> > Signed-off-by: Matthias Schiffer  > >
> > ---
> >  rules/kmscube.make | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rules/kmscube.make b/rules/kmscube.make
> > index a6d5d0150..94a2f31fa 100644
> > --- a/rules/kmscube.make
> > +++ b/rules/kmscube.make
> > @@ -18,7 +18,7 @@ PACKAGES-$(PTXCONF_KMSCUBE) += kmscube
> >  KMSCUBE_VERSION:= 2017-03-13-g803bac5
> >  KMSCUBE:= kmscube-$(KMSCUBE_VERSION)
> >  KMSCUBE_MD5:= 781a59ab2d1d245e99a49df7c3dc1876
> > -KMSCUBE_URL:=
> > git://anongit.freedesktop.org/mesa/kmscube;tag=$(KMSCUBE_VERSION)
> > +KMSCUBE_URL:= 
> > https://gitlab.freedesktop.org/mesa/kmscube.git;tag=$(KMSCUBE_VERSION
> > )
> 
> With gitlab, we can avoid git entirely:
> 
> 
https://gitlab.freedesktop.org/mesa/kmscube/-/archive/$(KMSCUBE_VERSION)/$(KMSCUBE).$(KMSCUBE_SUFFIX
> )
> 
> Should work.
> 
> Michael

Are these archive downloads guaranteed to have stable MD5 sums with
Gitlab? I know that the OpenWrt project generally avoids archive
downloads from Github for this reason.

Matthias


> 
> >  KMSCUBE_SUFFIX := tar.gz
> >  KMSCUBE_SOURCE := $(SRCDIR)/$(KMSCUBE).$(KMSCUBE_SUFFIX)
> >  KMSCUBE_DIR:= $(BUILDDIR)/$(KMSCUBE)
> > -- 
> > 2.17.1
> > 
> > 
> > ___
> > ptxdist mailing list
> > ptxdist@pengutronix.de
> > 
> 
> 


___
ptxdist mailing list
ptxdist@pengutronix.de