Re: before/after editaction

2012-01-04 Thread Ojan Vafai
On Thu, Oct 20, 2011 at 7:02 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 20, 2011 at 6:57 PM, Ryosuke Niwa rn...@webkit.org wrote: I don't think we can make such an assumption. People mutate DOM on input event all the time: http://codesearch.google.com/#search/q=%20oninput=type=cs

Re: before/after editaction

2011-10-20 Thread Ryosuke Niwa
On Thu, Oct 13, 2011 at 7:20 PM, Ojan Vafai o...@chromium.org wrote: Overall I really like the proposal (both having the events and Jonas's addition to include them in the undo transaction). We'd fire the afterEditAction exactly everywhere we currently fire the input event though. Instead of

Re: before/after editaction

2011-10-20 Thread Ryosuke Niwa
On Thu, Oct 20, 2011 at 6:35 PM, Ojan Vafai o...@chromium.org wrote: On Thu, Oct 20, 2011 at 1:06 PM, Ryosuke Niwa rn...@webkit.org wrote: On Thu, Oct 13, 2011 at 7:20 PM, Ojan Vafai o...@chromium.org wrote: Overall I really like the proposal (both having the events and Jonas's addition to

Re: before/after editaction

2011-10-20 Thread Ryosuke Niwa
On Thu, Oct 20, 2011 at 6:57 PM, Ryosuke Niwa rn...@webkit.org wrote: I don't think we can make such an assumption. People mutate DOM on input event all the time: http://codesearch.google.com/#search/q=%20oninput=type=cs Including any DOM mutations in the on-going transaction would mean that

Re: before/after editaction

2011-10-13 Thread Ojan Vafai
On Tue, Aug 30, 2011 at 6:39 PM, Jonas Sicking jo...@sicking.cc wrote: On Tue, Aug 30, 2011 at 5:07 PM, Ryosuke Niwa rn...@webkit.org wrote: On Tue, Aug 30, 2011 at 4:34 PM, Darin Adler da...@apple.com wrote: My question was not about the undo command. I meant that if I implemented a

Re: before/after editaction

2011-09-07 Thread Karl Dubost
Le 31 août 2011 à 03:39, Jonas Sicking a écrit : The one thing that this doesn't solve is what to do in cases when the page wants to replace the current action with a manual transaction rather than the managed one usually created. Ideas for how to solve that are welcome. Is there also an

Re: before/after editaction

2011-09-07 Thread Olli Pettay
On 08/31/2011 02:00 AM, Ryosuke Niwa wrote: Greetings all, During the very constructive meeting in Toronto http://ehsanakhgari.org/blog/2011-08-31/future-editing-web, we came to a conclusion that we want events that fire before after user editing action and execCommand take place. Let us call

Re: before/after editaction

2011-09-07 Thread Aryeh Gregor
On Wed, Sep 7, 2011 at 5:47 AM, Olli Pettay olli.pet...@helsinki.fi wrote: What happens if beforeeditaction tears down the document, or changes the document significantly or closes the window etc. (Those a generic problems with before* events) It shouldn't make any difference. The behavior of

Re: before/after editaction

2011-08-30 Thread Ryosuke Niwa
On Tue, Aug 30, 2011 at 4:08 PM, Darin Adler da...@apple.com wrote: How would this work with undo? That's a debatable point. Presumably, we'll be adding undo/redo events as well so we could not fire before/after edit action events for execCommand('undo') and execCommand('redo'). I know it's

Re: before/after editaction

2011-08-30 Thread Darin Adler
On Aug 30, 2011, at 4:13 PM, Ryosuke Niwa wrote: On Tue, Aug 30, 2011 at 4:08 PM, Darin Adler da...@apple.com wrote: How would this work with undo? That's a debatable point. Presumably, we'll be adding undo/redo events as well so we could not fire before/after edit action events for

Re: before/after editaction

2011-08-30 Thread Ryosuke Niwa
On Tue, Aug 30, 2011 at 4:34 PM, Darin Adler da...@apple.com wrote: My question was not about the undo command. I meant that if I implemented a handler for the aftereditaction event that changed b tags to strong tags, how would the undo machinery undo what I had done? Ah, I see. So UA won't

Re: before/after editaction

2011-08-30 Thread Jonas Sicking
On Tue, Aug 30, 2011 at 5:07 PM, Ryosuke Niwa rn...@webkit.org wrote: On Tue, Aug 30, 2011 at 4:34 PM, Darin Adler da...@apple.com wrote: My question was not about the undo command. I meant that if I implemented a handler for the aftereditaction event that changed b tags to strong tags, how