Re: [UndoManager] Re-introduce DOMTransaction interface?

2012-07-06 Thread James Graham
On 07/06/2012 02:01 AM, Ryosuke Niwa wrote: On Thu, Jul 5, 2012 at 4:27 PM, Ojan Vafai o...@chromium.org wrote: In your version, you need to remember the order of the arguments, which requires you looking it up each time. If we do decide to add the DOMTransaction constructor back, we should

Re: [UndoManager] What should a native automatic transaction expose?

2012-07-06 Thread Ojan Vafai
On Wed, Jul 4, 2012 at 3:43 PM, Ryosuke Niwa rn...@webkit.org wrote: Hi, In section 3.3 [1], we mention that the user editing actions and drag and drop need to be implemented as automatic DOM transactions. But it seems odd to expose executeAutomatic function in this case especially for drag

Re: [UndoManager] Re-introduce DOMTransaction interface?

2012-07-06 Thread Ryosuke Niwa
On Fri, Jul 6, 2012 at 1:46 AM, James Graham jgra...@opera.com wrote: On 07/06/2012 02:01 AM, Ryosuke Niwa wrote: On Thu, Jul 5, 2012 at 4:27 PM, Ojan Vafai o...@chromium.org wrote: In your version, you need to remember the order of the arguments, which requires you looking it up each

Re: [UndoManager] Re-introduce DOMTransaction interface?

2012-07-06 Thread Ryosuke Niwa
On Jul 6, 2012 3:06 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 7/5/12 3:05 PM, Ryosuke Niwa wrote: Also, I think consistency matters a lot here. I'm not aware of any other Web-facing API that takes a pure object with callback functions.

[XHR] What referrer to use when making requests

2012-07-06 Thread Jonas Sicking
It's currently not specified what the 'referer' request header should be set to when making requests using XMLHttpRequest. For example if an XHR object is created by one document, and then passes the object to a second document which calls xhr.open. Or if a page creates a XHR object and then calls

Re: [UndoManager] Re-introduce DOMTransaction interface?

2012-07-06 Thread Jonas Sicking
On Wed, Jul 4, 2012 at 5:39 PM, Ryosuke Niwa rn...@webkit.org wrote: On Jul 4, 2012 5:26 PM, Olli Pettay olli.pet...@helsinki.fi wrote: On 07/05/2012 03:11 AM, Ryosuke Niwa wrote: On Wed, Jul 4, 2012 at 5:00 PM, Olli Pettay olli.pet...@helsinki.fi mailto:olli.pet...@helsinki.fi wrote:

Re: [UndoManager] Re-introduce DOMTransaction interface?

2012-07-06 Thread Jonas Sicking
On Fri, Jul 6, 2012 at 3:18 PM, Ryosuke Niwa rn...@webkit.org wrote: On Jul 6, 2012 3:06 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 7/5/12 3:05 PM, Ryosuke Niwa wrote: Also, I think consistency matters a lot here. I'm not aware of any other Web-facing API that takes a pure object with

Re: [UndoManager] Re-introduce DOMTransaction interface?

2012-07-06 Thread Ryosuke Niwa
On Thu, Jul 5, 2012 at 4:40 PM, Yuval Sadan sadan.yu...@gmail.com wrote: t = undoManager.transact(foobar, function() { ... }); t.onredo = function() { /* custom redo */ }; t.execute(); Whether onundo/onredo are assigned upon execute() is well defined, so basing behavior on that is