Re: Tests for new shadow DOM API

[河内 隆仁]

Hi,

Thanks Ryosuke for starting contributing tests to shadow-dom/ and moving
the old ones under untriaged/.

I would like to continue triaging old tests in untriaged/ directory.
The general rule of thumb (for me) for working on them are:

- Remove tests that test out-of-date features (e.g. attributes that is
removed from spec)
- If the test is doing something valid, carefully examine what is tested
and whether it is not
  duplicate of other tests (outside of untriaged/*). If it is a duplicate,
remove it.
- If the test passes above 2 bullets, then rewrite so that the test runs in
more sane way and
  submit for review, and remove the original once the new test lands.

And I'm happy to review any new or triaged test, please add @TakayoshiKochi
in your pull request.

Thank you!

On Fri, Sep 4, 2015 at 5:13 PM, Ms2ger  wrote:

> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Hi Ryosuke,
>
> On 09/03/2015 10:06 PM, Ryosuke Niwa wrote:
> > Hi all,
> >
> > Where should we put tests for new shadow DOM API?  It looks like
> > the tests in
> > https://github.com/w3c/web-platform-tests/tree/master/shadow-dom/shado
> w-trees
> >
> >
>  - -trees>
> > are mostly obsolete and I'm not certain how many of them could be
> > adopted for the new API.
> >
> > Would it make sense to rename this old one to
> > "deprecated-shadow-don" and then create a new top-level directory
> > "shadow-dom"?  We can then migrate or write new tests there.
> >
>
> If you believe a significant fraction of the existing tests is out of
> date with the specification, I'd suggest moving them all into
> `shadow-dom/untriaged` and adding a `README` file there to explain the
> situation.
>
> HTH
> Ms2ger
> -BEGIN PGP SIGNATURE-
>
> iQEcBAEBAgAGBQJV6VK2AAoJEOXgvIL+s8n2asAIAJEXWz8vyAGqPI6BFNNYQYXb
> 4i/knAt1/GEeiUOzjzbwJG38NRtGr9cZO0MCYW8S13gzzqKbtdCWwF0FbBvzvMR1
> OHqkdR7tLo/aLV00GQzrLSgNDnqQ2M1+P/lq5QUU53DsbpTM2Ih0P1pjDsvaLs75
> TZFggKN8UKhvjQrKuL1wjtCSKrdkemXKbdl2FfWgXj1hsUklNwKSmTd8Hr+g6FaS
> eK+l74G7xhxbqwKvIo8MgcLjwNYJG5hPJWoP6T9b9rBnE4W+x8J9ojcVVMuCWz/4
> 0GOGvgyRXwobDcKsAcBomNhTruOC8pqNVn6e84oScOyNf8QRP6GDjyj/a2jd71I=
> =Z5oS
> -END PGP SIGNATURE-
>
>


-- 
Takayoshi Kochi

Re: Tests for new shadow DOM API

[Ms2ger]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hi Ryosuke,

On 09/03/2015 10:06 PM, Ryosuke Niwa wrote:
> Hi all,
> 
> Where should we put tests for new shadow DOM API?  It looks like
> the tests in 
> https://github.com/w3c/web-platform-tests/tree/master/shadow-dom/shado
w-trees
>
> 

> are mostly obsolete and I'm not certain how many of them could be 
> adopted for the new API.
> 
> Would it make sense to rename this old one to
> "deprecated-shadow-don" and then create a new top-level directory
> "shadow-dom"?  We can then migrate or write new tests there.
> 

If you believe a significant fraction of the existing tests is out of
date with the specification, I'd suggest moving them all into
`shadow-dom/untriaged` and adding a `README` file there to explain the
situation.

HTH
Ms2ger
-BEGIN PGP SIGNATURE-

iQEcBAEBAgAGBQJV6VK2AAoJEOXgvIL+s8n2asAIAJEXWz8vyAGqPI6BFNNYQYXb
4i/knAt1/GEeiUOzjzbwJG38NRtGr9cZO0MCYW8S13gzzqKbtdCWwF0FbBvzvMR1
OHqkdR7tLo/aLV00GQzrLSgNDnqQ2M1+P/lq5QUU53DsbpTM2Ih0P1pjDsvaLs75
TZFggKN8UKhvjQrKuL1wjtCSKrdkemXKbdl2FfWgXj1hsUklNwKSmTd8Hr+g6FaS
eK+l74G7xhxbqwKvIo8MgcLjwNYJG5hPJWoP6T9b9rBnE4W+x8J9ojcVVMuCWz/4
0GOGvgyRXwobDcKsAcBomNhTruOC8pqNVn6e84oScOyNf8QRP6GDjyj/a2jd71I=
=Z5oS
-END PGP SIGNATURE-

Re: Tests for new shadow DOM API

[Ryosuke Niwa]

I think many of them are still relevant.  The key problem I have at the moment 
is that I can't tell which ones are relevant and which ones aren't.  So I 
wanted to create a new directory and migrate or delete the existing tests over 
time.

> On Sep 3, 2015, at 1:19 PM, Travis Leithead  
> wrote:
> 
> Why not deprecate/remove the existing tests in the current folder structure? 
> Presumably we can replace them with new tests that are aligned with the 
> recent spec changes?
>  
> If the existing tests really aren’t relevant anymore, I don’t see a reason to 
> keep them around.
>  
> From: rn...@apple.com [mailto:rn...@apple.com] 
> Sent: Thursday, September 3, 2015 1:07 PM
> To: public-webapps 
> Subject: Tests for new shadow DOM API
>  
> Hi all,
>  
> Where should we put tests for new shadow DOM API?  It looks like the tests in 
> https://github.com/w3c/web-platform-tests/tree/master/shadow-dom/shadow-trees 
> 
>  are mostly obsolete and I'm not certain how many of them could be adopted 
> for the new API.
>  
> Would it make sense to rename this old one to "deprecated-shadow-don" and 
> then create a new top-level directory "shadow-dom"?  We can then migrate or 
> write new tests there.
>  
> - R. Niwa
>  

RE: Tests for new shadow DOM API

[Travis Leithead]

Why not deprecate/remove the existing tests in the current folder structure? 
Presumably we can replace them with new tests that are aligned with the recent 
spec changes?

If the existing tests really aren't relevant anymore, I don't see a reason to 
keep them around.

From: rn...@apple.com [mailto:rn...@apple.com]
Sent: Thursday, September 3, 2015 1:07 PM
To: public-webapps 
Subject: Tests for new shadow DOM API

Hi all,

Where should we put tests for new shadow DOM API?  It looks like the tests in 
https://github.com/w3c/web-platform-tests/tree/master/shadow-dom/shadow-trees 
are mostly obsolete and I'm not certain how many of them could be adopted for 
the new API.

Would it make sense to rename this old one to "deprecated-shadow-don" and then 
create a new top-level directory "shadow-dom"?  We can then migrate or write 
new tests there.

- R. Niwa