Re: [Pulp-dev] Pull Request builder job changes for plugins

2017-06-15 Thread Brian Bouterse
@dkliban, I think that is a good solution. Since it's currently using the latest GA version of core, all we need to do is extend the current job as you describe. I rewrite the issue [0] to reflect that last part of the work. This is on the current sprint at NEW so I imagine it will get picked up

Re: [Pulp-dev] Pull Request builder job changes for plugins

2017-06-05 Thread Dennis Kliban
What if we ran our plugin unit tests against both the latest GA build and nightly build of core? If the tests pass with the GA version, the job is marked as successful. If not, core packages are upgraded to the latest nightly and unit tests are run again. If the unit tests fail again, the job is

Re: [Pulp-dev] Pull Request builder job changes for plugins

2017-06-04 Thread Brian Bouterse
After thinking about this more, I realized that for the remainder of Pulp2 at least, we need to have the plugin unittest runner test against the nightly version of core and not the latest GA. Using the GAs won't work because not only is the 'I need unreleased code from platform' a problem with the

Re: [Pulp-dev] Pull Request builder job changes for plugins

2017-06-02 Thread Brian Bouterse
That is a good point, and one we are giving some thought to through convo on #pulp-dev and the issue [0]. The case of a plugin needing an unreleased change from core would fail with this change. It's a tradeoff though because if we go with nightlies as the version of core that is used, whenever

Re: [Pulp-dev] Pull Request builder job changes for plugins

2017-06-02 Thread Michael Hrivnak
What about cases where a plugin wants to use something that's new in the unreleased core? The master branch of a plugin will usually be released with the master branch of the core in the next 2.y release for example. That seems like a normal scenario; is it facilitated somehow with this testing

[Pulp-dev] Pull Request builder job changes for plugins

2017-06-02 Thread Dennis Kliban
In an effort to resolve issue 2751[0], I updated the PR builder job for plugins. Each PR for a plugin will now be tested against the latest stable release of the core found here[1]. This will ensure that the plugin is maintaining compatibility with the latest stable core and that we are only