Re: [Pulp-dev] Importer Name

2018-03-23 Thread David Davis
I was one of the voices of dissent on this but I am more of a -0/+0 than a -1. David On Fri, Mar 23, 2018 at 2:56 PM, Dana Walker wrote: > FWIW, I've looked them over and think they're good, but given the +/- 1's > discussion on IRC, you may want to get further grooming

Re: [Pulp-dev] Importer Name

2018-03-23 Thread Dana Walker
FWIW, I've looked them over and think they're good, but given the +/- 1's discussion on IRC, you may want to get further grooming consensus still. --Dana Dana Walker Associate Software Engineer Red Hat On Fri, Mar 23, 2018 at 1:51 PM, Austin

Re: [Pulp-dev] Importer Name

2018-03-16 Thread Austin Macdonald
Ive created tasks to do this work. Rename: https://pulp.plan.io/issues/3488 Move sync_mode, remove download_policy https://pulp.plan.io/issues/3492 Each of these has corresponding plugin tasks, which are related to them. On Thu, Mar 15, 2018 at 4:16 PM, David Davis

Re: [Pulp-dev] Importer Name

2018-03-15 Thread David Davis
Austin and Jeff, Thanks for the responses. I am happy with moving forward and opening an issue in redmine for this change I think I am +0 on dropping the fields. However, if we start to get complaints from our users, I think we should consider adding them back. David On Wed, Mar 14, 2018 at

Re: [Pulp-dev] Importer Name

2018-03-15 Thread Jeff Ortel
In pulp3, users need to keep track for a number of things.  For example, without auto publish, users need to keep track of which importer(s) and publishers need to be used for sync/publish workflows.  I fully expect that users using the API will be maintaining some kind of

Re: [Pulp-dev] Importer Name

2018-03-13 Thread Austin Macdonald
> > On Mon, Mar 12, 2018 at 9:50 AM, Justin Sherrill > wrote: > >> I'm fairly apathetic to a name change. It would be annoying to us in >> katello land, but not really a huge deal either way. I don't think >> importer a bad name, as it does hold configuration around

Re: [Pulp-dev] Importer Name

2018-03-12 Thread Jeff Ortel
On 03/08/2018 10:13 AM, Austin Macdonald wrote: Motivation: The name "importer" carries some inaccurate implications. 1) Importers should "import". Tasks like "sync" will do the actual importing. The object only holds the configuration that happens to be used by sync tasks. 2) Sync tasks on

Re: [Pulp-dev] Importer Name

2018-03-12 Thread Justin Sherrill
On 03/08/2018 11:13 AM, Austin Macdonald wrote: Motivation: The name "importer" carries some inaccurate implications. 1) Importers should "import". Tasks like "sync" will do the actual importing. The object only holds the configuration that happens to be used by sync tasks. 2) Sync tasks on

Re: [Pulp-dev] Importer Name

2018-03-10 Thread David Davis
I’m probably -0 on changing the name from Importer to Remote. I think Remote is a better name but I worry about changing the data model too much in respect to Pulp 2. The more we diverge from Pulp 2, the more work we create for stuff like Katello. The word “importer" appears 500 times in their

Re: [Pulp-dev] Importer Name

2018-03-10 Thread Daniel Alley
+1 +1 On Fri, Mar 9, 2018 at 3:28 PM, Brian Bouterse wrote: > I left some responses inline. > > On Thu, Mar 8, 2018 at 11:13 AM, Austin Macdonald > wrote: > >> Motivation: >> The name "importer" carries some inaccurate implications. >> 1) Importers

Re: [Pulp-dev] Importer Name

2018-03-09 Thread Brian Bouterse
I left some responses inline. On Thu, Mar 8, 2018 at 11:13 AM, Austin Macdonald wrote: > Motivation: > The name "importer" carries some inaccurate implications. > 1) Importers should "import". Tasks like "sync" will do the actual > importing. The object only holds the