Re: [Pulp-dev] pulp 3 PR testing with pulp-smash

> If only pulpcore tests are run we could get into a situation where the PR breaks the plugin API and we don't learn this until after the code is merged. This. We want to know if changes to pulpcore break plugins. Intentional breaking changes should be unusual, and in those cases, I think it's

Re: [Pulp-dev] pulp 3 PR testing with pulp-smash

Yea, it’s a bit unclear, but Pulp 3. David On Fri, Feb 23, 2018 at 10:34 AM, Robin Chan wrote: > Really basic question, but to be clear, these are changes for Pulp 2 or > Pulp 3? > > On Thu, Feb 22, 2018 at 5:40 PM, Dennis Kliban wrote: > >> We are

Re: [Pulp-dev] pulp 3 PR testing with pulp-smash

Really basic question, but to be clear, these are changes for Pulp 2 or Pulp 3? On Thu, Feb 22, 2018 at 5:40 PM, Dennis Kliban wrote: > We are currently using the Jenkins GitHub PR builder plugin to perform the > API calls at the end of the job. I don't think this plugin

Re: [Pulp-dev] pulp 3 PR testing with pulp-smash

We are currently using the Jenkins GitHub PR builder plugin to perform the API calls at the end of the job. I don't think this plugin currently supports reporting multiple checks from one job. On Thu, Feb 22, 2018 at 5:37 PM, David Davis wrote: > In theory, we could have

Re: [Pulp-dev] pulp 3 PR testing with pulp-smash

In theory, we could have one jenkins job that makes two calls to Github’s status API—one for the pulpcore smash test result and one for the pulp_file smash test. That said, I am fine with 2 jenkins jobs too. David On Thu, Feb 22, 2018 at 5:32 PM, Dennis Kliban wrote: > On

Re: [Pulp-dev] pulp 3 PR testing with pulp-smash

On Thu, Feb 22, 2018 at 5:21 PM, Daniel Alley wrote: > Would it be possible to have the required tests be Pulp core only, but to > have an expanded set of non-mandatory smash tests which includes pulp_file? > > Which would mean, the pulp_file smash test results would be there

Re: [Pulp-dev] pulp 3 PR testing with pulp-smash

Would it be possible to have the required tests be Pulp core only, but to have an expanded set of non-mandatory smash tests which includes pulp_file? Which would mean, the pulp_file smash test results would be there as a visual indicator, but wouldn't cause problems over the next few months