PulseAudio Marge Bot pushed to branch master at PulseAudio / pulseaudio
Commits: 411c0870 by Igor V. Kovalenko at 2021-06-01T20:34:54+03:00 alsa-mixer: prevent double-free on decibel fixes object key When decibel fixes object is cloned, there is only a shallow copy of `key` string member of original object. This may lead to double-free crash reported in pipewire tracker https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1125 Fix this by doing a deep copy of `key` string to maintain correct ownership. Part-of: <https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/569> - - - - - 1 changed file: - src/modules/alsa/alsa-mixer.c Changes: ===================================== src/modules/alsa/alsa-mixer.c ===================================== @@ -3571,6 +3571,7 @@ finish: * object. */ e->db_fix = pa_xnewdup(pa_alsa_decibel_fix, db_fix, 1); e->db_fix->profile_set = NULL; + e->db_fix->key = pa_xstrdup(db_fix->key); e->db_fix->name = pa_xstrdup(db_fix->name); e->db_fix->db_values = pa_xmemdup(db_fix->db_values, (db_fix->max_step - db_fix->min_step + 1) * sizeof(long)); } View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/411c087095e1cb8e9d3ef5b1c850a98b81f7fa44 -- View it on GitLab: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/411c087095e1cb8e9d3ef5b1c850a98b81f7fa44 You're receiving this email because of your account on gitlab.freedesktop.org.
_______________________________________________ pulseaudio-commits mailing list pulseaudio-commits@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-commits
