On Sat, 2012-08-18 at 05:13 +0200, David Henningsson wrote:
> On 08/17/2012 05:09 PM, Tanu Kaskinen wrote:
> > Besides making the code a bit cleaner, this also gets rid of
> > a few "cast increases required alignment of target type"
> > warnings.
>
> Looks good. Thanks!
Thanks for review, I've pu
On Mon, 2012-08-20 at 09:43 +0200, David Henningsson wrote:
> On 08/19/2012 01:06 PM, Tanu Kaskinen wrote:
> > Hi,
> >
> > While reviewing a rewind related patch, I noticed that I don't
> > understand the rewinding code thoroughly, even though I have studied it
> > a few times in the past. I decide
On Mon, 2012-08-20 at 09:37 +0200, David Henningsson wrote:
> On 08/19/2012 01:55 PM, Tanu Kaskinen wrote:
> > The sink has different frame size than the sink input, so
> > the max_rewind value of the sink input needs to be converted
> > when setting the sink max_rewind value.
> >
> > The conversio
The sink has different frame size than the sink input, so
the max_request and max_rewind values of the sink input need
to be converted when setting the sink max_request and
max_rewind values.
The conversion is already done correctly in
sink_input_update_max_request_cb() and
sink_input_update_max_r
On Wed, 2012-08-22 at 09:14 +0800, Raymond Yau wrote:
> 2012-8-19 下午7:17 於 "Tanu Kaskinen" 寫道：
> >
> > Hi,
> >
> > While reviewing a rewind related patch, I noticed that I don't
> > understand the rewinding code thoroughly, even though I have studied it
> > a few times in the past. I decided that
On Wed, 2012-08-22 at 08:01 +0800, rong deng wrote:
> 2012/8/22 Tanu Kaskinen :
> > Hi Deng,
> >
> > On Sat, 2012-07-07 at 22:49 +0800, Deng Zhengrong wrote:
> >> As discussed, this might not handle the microsoft compilers well. But let
> >> me
> >> post this series of patches and think out a bett
2012-8-19 下午7:17 於 "Tanu Kaskinen" 寫道：
>
> Hi,
>
> While reviewing a rewind related patch, I noticed that I don't
> understand the rewinding code thoroughly, even though I have studied it
> a few times in the past. I decided that I should write a wiki page for
> the code so that working with it wo
2012/8/22 Tanu Kaskinen :
> Hi Deng,
>
> On Sat, 2012-07-07 at 22:49 +0800, Deng Zhengrong wrote:
>> As discussed, this might not handle the microsoft compilers well. But let me
>> post this series of patches and think out a better way to handle it. Or... we
>> don't change it at all.
>
> The patch
Hi Deng,
On Sat, 2012-07-07 at 22:49 +0800, Deng Zhengrong wrote:
> As discussed, this might not handle the microsoft compilers well. But let me
> post this series of patches and think out a better way to handle it. Or... we
> don't change it at all.
The patches didn't reach the list. (I thought
On Thu, 2012-08-16 at 13:08 +0200, Mikel Astiz wrote:
> From: Mikel Astiz
>
> Else clause should be in the same line as the closing brace.
Pushed both patches, thanks!
--
Tanu
___
pulseaudio-discuss mailing list
pulseaudio-discuss@lists.freedesktop.
On Fri, 2012-08-17 at 08:12 +0200, Mikel Astiz wrote:
> From: Mikel Astiz
>
> Add support for hfgw card profile in module-bluetooth-policy, just like
> a2dp_source in handled.
>
> In this case also the sink needs to be connected using module-loopback.
Ack.
--
Tanu
___
On Fri, 2012-08-17 at 08:12 +0200, Mikel Astiz wrote:
> From: Mikel Astiz
>
> Instead of focusing on a2dp_source only, prepare the module to support
> several profiles. It will be possible to enable/disable each of them
> using module arguments.
> ---
> src/modules/bluetooth/module-bluetooth-pol
On Fri, 2012-08-17 at 08:12 +0200, Mikel Astiz wrote:
> From: Mikel Astiz
>
> Property bluetooth.profile did make a distinction between A2DP sink and
> source roles but on the contrary did not separate HFP roles (headset vs
> gateway). For consistency, they should both behave similarly.
>
> This
Le mardi 21 août 2012 14:32:06 Thomas Martitz, vous avez écrit :
> Am 21.08.2012 08:51, schrieb Rémi Denis-Courmont:
> > Le mardi 21 août 2012 00:50:34 Thomas Martitz, vous avez écrit :
> >> There are tons of warnings, most of them because the function is not
> >> recognized as printf-like.
> >
>
Am 21.08.2012 08:51, schrieb Rémi Denis-Courmont:
Le mardi 21 août 2012 00:50:34 Thomas Martitz, vous avez écrit :
There are tons of warnings, most of them because the function is not
recognized as printf-like.
Removing checks looks very fishy.
To use C99 and/or GNU format specifiers on MingW,
Le mardi 21 août 2012 00:50:34 Thomas Martitz, vous avez écrit :
> There are tons of warnings, most of them because the function is not
> recognized as printf-like.
Removing checks looks very fishy.
To use C99 and/or GNU format specifiers on MingW, you need to use the
gnuprintf attribute instead
Hi Thomas,
"git send-email --dry-run" is a very neat thing :)
cheers,
daniel
On Mon, Aug 20, 2012 at 11:50:28PM +0200, Thomas Martitz wrote:
> From: Thomas Martitz
>
> GIT: [PATCH v2 0/6] *** SUBJECT HERE ***
> GIT: [PATCH v2 1/6] gccmacro: Disable printf-like format checking on
> GIT: [PATCH
17 matches
Mail list logo
