Re: [pulseaudio-discuss] jackdbus module, pulse fails to conform on device reservation API

2013-01-13 Thread Ian Malone
On 3 December 2012 04:07, Brendan Jones wrote: > On 12/02/2012 11:42 PM, Tanu Kaskinen wrote: >> >> Thanks, I'm now able to reproduce the bug. I will try to find the root >> cause. >> > Thanks Tanu! Let me know what we can do to help. Fedora is a release behind > you guys for F18 (we will not be

Re: [pulseaudio-discuss] [PATCH 1/2] sconv: Change/fix conversion to/from float32

2013-01-13 Thread Tanu Kaskinen
On Sun, 2013-01-13 at 14:53 +0100, Peter Meerwald wrote: > > > @@ -115,18 +115,16 @@ void pa_sconv_s16le_from_float32ne(unsigned n, > > > const float *a, int16_t *b) { > > > #if SWAP_WORDS == 1 > > > for (; n > 0; n--) { > > > int16_t s; > > > -float v = *(a++); > > > +

Re: [pulseaudio-discuss] [PATCH] reserve-monitor: Don't trigger on our own events

2013-01-13 Thread Ian Malone
On 11 January 2013 14:57, David Henningsson wrote: > On 01/11/2013 02:37 PM, Brendan Jones wrote: >> >> On 01/11/2013 02:04 PM, David Henningsson wrote: >>> >>> This fixes a bug where pulseaudio would give up the device (due to >>> a request from JACK), but then immediately grab it again because >

Re: [pulseaudio-discuss] [PATCH 1/2] sconv: Change/fix conversion to/from float32

2013-01-13 Thread Peter Meerwald
Hello Tanu, thank you for reviewing the code, my comments are inline > > use (1<<15) instead of 0x7fff as a factor when converting from s16 to > > float32 > > use (1<<31) instead of 0x7fff as a factor when converting from s32 to > > float32 > > Signed-off-by: Peter Meerwald > > --- > > s