Re: [pulseaudio-discuss] [PATCHv2 27/60] bluetooth: Create pa_bluetooth_transport for BlueZ 5 support

2013-08-20 Thread Tanu Kaskinen
On Mon, 2013-08-19 at 13:44 -0300, João Paulo Rechi Vita wrote: On Fri, Aug 16, 2013 at 12:32 PM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote: From: João Paulo Rechi Vita jprv...@openbossa.org Create the

Re: [pulseaudio-discuss] [PATCHv2 30/60] bluetooth: Implement org.bluez.MediaEndpoint1.SetConfiguration()

2013-08-20 Thread Tanu Kaskinen
On Mon, 2013-08-19 at 13:57 -0300, João Paulo Rechi Vita wrote: On Sun, Aug 18, 2013 at 6:03 AM, Tanu Kaskinen tanu.kaski...@linux.intel.com wrote: On Tue, 2013-08-13 at 01:54 -0300, jprv...@gmail.com wrote: From: João Paulo Rechi Vita jprv...@openbossa.org ---

Re: [pulseaudio-discuss] [PATCH] module-tunnel-sink-new: add a rewrite of module-tunnel using libpulse

2013-08-20 Thread Tanu Kaskinen
On Mon, 2013-08-19 at 07:41 +0200, Alexander Couzens wrote: Old module-tunnel shares duplicated functionality with libpulse because it is implementing pulse protocol again. module-tunnel-sink-new uses libpulse to connect to the remote server Signed-off-by: Alexander Couzens lyn...@fe80.eu

Re: [pulseaudio-discuss] [PATCH] add module-tunnel-sink-new v4

2013-08-20 Thread Tanu Kaskinen
On Mon, 2013-08-19 at 07:30 +0200, Alexander Couzens wrote: I hope i did'nt forget too much. Not much, but something. I recommend copying my review to a text file, and removing those pieces of feedback that you have addressed. When the file is empty, you know you have addressed everything. --

Re: [pulseaudio-discuss] [PATCH 1/2] client-conf-x11|client-conf: refactor cookie loaders

2013-08-20 Thread Tanu Kaskinen
client-conf is sufficient for the commit prefix, instead of client-conf-x11|client-conf. (Sorry, I know there's no way for you to know what the prefix should be, other than trial and error...) On Tue, 2013-08-13 at 11:36 +0200, Alexander Couzens wrote: Signed-off-by: Alexander Couzens

Re: [pulseaudio-discuss] [PATCH 2/2] context: add cookie loaders + setter

2013-08-20 Thread Tanu Kaskinen
On Tue, 2013-08-13 at 11:41 +0200, Alexander Couzens wrote: I'm not sure if these 3 seperate calls for cookie loading are better than creating a pa_context_get_conf() call and operating on it. I think it's better to keep pa_client_conf as a private interface. Signed-off-by: Alexander

Re: [pulseaudio-discuss] Pulseaudio on raspberrypi

2013-08-20 Thread Alex Schenkman
Jim, Have you tried using RTP instead of a tunnel? http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Network/#index2h3 On Mon, Aug 5, 2013 at 11:51 AM, Alex Schenkman a...@schenkman.info wrote: Hi Jim, I am also interested in this setup. You have come further than me,

Re: [pulseaudio-discuss] [PATCH 2/2] context: add cookie loaders + setter

2013-08-20 Thread Alexander Couzens
We need to expose the cookie size to clients somehow. A simple #define should be good enough. The problem with a #define in the public API is that it can't be changed without breaking compatibility, but I don't think we can change the cookie size anyway without breaking compatibility between