[pulseaudio-discuss] Simultaneous Audio Out

2013-09-29 Thread Randy Broman
I have an AMD system with Sabertooth 990FX motherboard, running Kubuntu 12.04 and KDE 4.11.1. Chipset is AMD990FX/SB950, and audio spec is Realtek ALC892 8-channel Hi Def audio. I have audio outputs connected to the analog out ports, and digital coax out to a mini-card connected to the

[pulseaudio-discuss] [PATCH] build-sys: Add an Android-friendly build system

2013-09-29 Thread Arun Raghavan
Some notes: * This depends on 'androgenizer', a tool to generate Android-style Android.mk files from an autotools build system. * This assumes that PA is run as the system daemon and configures accordingly. * In the Android build, libltdl is likely not available when configure is being

Re: [pulseaudio-discuss] [PATCH v5 16/39] bluetooth: Protect from a misbehaving bluetoothd

2013-09-29 Thread Tanu Kaskinen
On Tue, 2013-09-24 at 19:45 -0300, jprv...@gmail.com wrote: @@ -745,6 +748,15 @@ static void parse_interfaces_and_properties(pa_bluetooth_discovery *y, DBusMessa dbus_message_iter_next(element_i); } +PA_HASHMAP_FOREACH(d, y-devices, state) +if (!d-adapter

Re: [pulseaudio-discuss] [PATCH v5 36/39] bluetooth: Fail to load driver if discovery module is not loaded

2013-09-29 Thread Tanu Kaskinen
On Tue, 2013-09-24 at 19:45 -0300, jprv...@gmail.com wrote: diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c index 36d7174..013cce5 100644 --- a/src/modules/bluetooth/module-bluez5-device.c +++

[pulseaudio-discuss] [PATCH 0/5] Bluetooth polishing

2013-09-29 Thread Tanu Kaskinen
Here are some small fixes to issues that I found while reviewing the big Bluetooth patch set from João. Tanu Kaskinen (5): bluetooth: Remove adapter_remove_all() bluetooth: Fix variable constness bluetooth: Fix notifying about new devices bluetooth: Remove device_remove_all() bluetooth:

[pulseaudio-discuss] [PATCH 2/5] bluetooth: Fix variable constness

2013-09-29 Thread Tanu Kaskinen
The string points to memory inside a DBusMessage, so we don't own the string. --- src/modules/bluetooth/bluez5-util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/modules/bluetooth/bluez5-util.c b/src/modules/bluetooth/bluez5-util.c index 2be15d8..eaff4b1 100644 ---

[pulseaudio-discuss] [PATCH 4/5] bluetooth: Remove device_remove_all()

2013-09-29 Thread Tanu Kaskinen
The function did two things: set device_info_valid to -1 and called device_free() for each device in the hashmap. Setting device_info_valid to -1 was unnecessary. The main purpose of that was to fire DEVICE_CONNECTION_CHANGED as a side effect, but that hook is fired anyway in device_free(), as a

[pulseaudio-discuss] [PATCH 3/5] bluetooth: Fix notifying about new devices

2013-09-29 Thread Tanu Kaskinen
Normally devices are created and their properties are parsed before creating any transports for the device, and the DEVICE_CONNECTION_CHANGED hook is fired when the first transport is created. It's possible, however, that a transport is created before the device that it belongs to, and in this

[pulseaudio-discuss] [PATCH 5/5] bluetooth: Set device_info_valid to -1 when the device's adapter disappears

2013-09-29 Thread Tanu Kaskinen
When parsing device properties, missing adapter will result in device_info_valid being set to -1. It is then logical that if the adapter goes missing at a later point, device_info_valid gets set to -1. --- src/modules/bluetooth/bluez5-util.c | 4 +++- 1 file changed, 3 insertions(+), 1

[pulseaudio-discuss] [PATCH 1/5] bluetooth: Remove adapter_remove_all()

2013-09-29 Thread Tanu Kaskinen
The function was redundant, because all it did was call adapter_free() for each adapter in the hashmap, and that can be delegated to pa_hashmap when freeing or emptying it. --- src/modules/bluetooth/bluez5-util.c | 20 1 file changed, 4 insertions(+), 16 deletions(-) diff

Re: [pulseaudio-discuss] [PATCH 1/3] hashmap: Add a key+value iterator

2013-09-29 Thread Tanu Kaskinen
On Fri, 2013-09-20 at 17:27 +0530, Arun Raghavan wrote: --- src/pulsecore/hashmap.h | 4 1 file changed, 4 insertions(+) diff --git a/src/pulsecore/hashmap.h b/src/pulsecore/hashmap.h index ae030ed..e42732a 100644 --- a/src/pulsecore/hashmap.h +++ b/src/pulsecore/hashmap.h @@ -85,6

Re: [pulseaudio-discuss] [PATCH] build-sys: Add an Android-friendly build system

2013-09-29 Thread Thomas Martitz
Am 29.09.2013 14:22, schrieb Arun Raghavan: Some notes: * This depends on 'androgenizer', a tool to generate Android-style Android.mk files from an autotools build system. * This assumes that PA is run as the system daemon and configures accordingly. * In the Android build, libltdl is